mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-31 22:15:23 +00:00
Code Issues Releases Wiki Activity

[#2834] Addressed review comments

Browse Source
This commit is contained in:
Piotrek Zadroga
2023-05-26 15:19:55 +02:00
parent c1ea0a3e9c
commit a45fb0f0dc
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
doc/sphinx/man/perfdhcp.8.rst
View File

@@ -365,8 +365,7 @@ The following options only apply for DHCPv6 (i.e. when ``-6`` is given).
specifies the option code and the hexstring is a hexadecimal string that specifies the option code and the hexstring is a hexadecimal string that
defines the content of the option. Care should be taken as ``perfdhcp`` defines the content of the option. Care should be taken as ``perfdhcp``
does not offer any kind of logic behind those options; they are simply does not offer any kind of logic behind those options; they are simply
inserted into packets and sent as is. Be careful not to duplicate inserted into packets and sent as is. Please notice that ``encapsulation-level:``
options that are already inserted. Please notice that ``encapsulation-level:``
is optional and if omitted, default encapsulation-level value 1 is used. is optional and if omitted, default encapsulation-level value 1 is used.
For example, to insert client class identifier (option code 60) with a For example, to insert client class identifier (option code 60) with a
string "docsis" at first level of encapsulation, use "--or 60,646f63736973" string "docsis" at first level of encapsulation, use "--or 60,646f63736973"

10
src/bin/perfdhcp/tests/command_options_unittest.cc
View File

@@ -1005,3 +1005,13 @@ TEST_F(CommandOptionsTest, UseRelayV6OptionsWithEncapsulationLevelValueTwo) {
EXPECT_THROW(process(opt, "perfdhcp -6 -A1 --or 2:32,00000E10 -l ethx all"), isc::InvalidParameter); EXPECT_THROW(process(opt, "perfdhcp -6 -A1 --or 2:32,00000E10 -l ethx all"), isc::InvalidParameter);
} }
TEST_F(CommandOptionsTest, UseRelayV6OptionsDuplicated) {
CommandOptions opt;
// multiple relayed options with the same option code are supported.
EXPECT_NO_THROW(process(opt, "perfdhcp -6 -A1 --or 1:32,00000E10 --or 32,00000E11 -l ethx all"));
EXPECT_TRUE(opt.isUseRelayedV6());
EXPECT_EQ(2, opt.getRelayOpts().size());
}