mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-30 13:37:55 +00:00
Code Issues Releases Wiki Activity

[#1074] minor changes

Browse Source
This commit is contained in:
Razvan Becheriu 2020-02-05 22:45:39 +02:00
parent ce77c1fc81
commit a67b77a7cc
3 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib/dhcpsrv/tests/cql_host_data_source_unittest.cc
View File

@ -190,8 +190,8 @@ TEST(CqlHostDataSource, OpenDatabase) {
// Ensure we have the proper schema with no transient data. // Ensure we have the proper schema with no transient data.
createCqlSchema(); createCqlSchema();
// Check that host manager open the database opens correctly and tidy up. // Check that host manager opens the database correctly and tidy up. If it
// If it fails, print the error message. // fails, print the error message.
try { try {
HostMgr::create(); HostMgr::create();
EXPECT_NO_THROW(HostMgr::addBackend(validCqlConnectionString())); EXPECT_NO_THROW(HostMgr::addBackend(validCqlConnectionString()));
@ -203,7 +203,7 @@ TEST(CqlHostDataSource, OpenDatabase) {
<< "*** before the CQL tests will run correctly.\n"; << "*** before the CQL tests will run correctly.\n";
} }
// Check that host manager open the database opens correctly with a longer // Check that host manager opens the database correctly with a longer
// timeout. If it fails, print the error message. // timeout. If it fails, print the error message.
try { try {
// CQL specifies the timeout values in ms, not seconds. Therefore // CQL specifies the timeout values in ms, not seconds. Therefore
@ -221,7 +221,7 @@ TEST(CqlHostDataSource, OpenDatabase) {
} }
// Check that attempting to get an instance of the host data source when // Check that attempting to get an instance of the host data source when
// none is set throws an exception. // none is set returns empty pointer.
EXPECT_FALSE(HostMgr::instance().getHostDataSource()); EXPECT_FALSE(HostMgr::instance().getHostDataSource());
// Check that wrong specification of backend throws an exception. // Check that wrong specification of backend throws an exception.

16
src/lib/dhcpsrv/tests/mysql_host_data_source_unittest.cc
View File

@ -163,8 +163,8 @@ TEST(MySqlHostDataSource, OpenDatabase) {
destroyMySQLSchema(); destroyMySQLSchema();
createMySQLSchema(); createMySQLSchema();
// Check that host manager open the database opens correctly and tidy up. // Check that host manager opens the database correctly and tidy up. If it
// If it fails, print the error message. // fails, print the error message.
try { try {
HostMgr::create(); HostMgr::create();
EXPECT_NO_THROW(HostMgr::addBackend(validMySQLConnectionString())); EXPECT_NO_THROW(HostMgr::addBackend(validMySQLConnectionString()));
@ -176,7 +176,7 @@ TEST(MySqlHostDataSource, OpenDatabase) {
<< "*** before the MySQL tests will run correctly.\n"; << "*** before the MySQL tests will run correctly.\n";
} }
// Check that host manager open the database opens correctly with a longer // Check that host manager opens the database correctly with a longer
// timeout. If it fails, print the error message. // timeout. If it fails, print the error message.
try { try {
string connection_string = validMySQLConnectionString() + string(" ") + string connection_string = validMySQLConnectionString() + string(" ") +
@ -192,7 +192,7 @@ TEST(MySqlHostDataSource, OpenDatabase) {
} }
// Check that attempting to get an instance of the host data source when // Check that attempting to get an instance of the host data source when
// none is set throws an exception. // none is set returns empty pointer.
EXPECT_FALSE(HostMgr::instance().getHostDataSource()); EXPECT_FALSE(HostMgr::instance().getHostDataSource());
// Check that wrong specification of backend throws an exception. // Check that wrong specification of backend throws an exception.
@ -251,8 +251,8 @@ TEST(MySqlHostDataSource, OpenDatabaseMultiThreading) {
destroyMySQLSchema(); destroyMySQLSchema();
createMySQLSchema(); createMySQLSchema();
// Check that host manager open the database opens correctly and tidy up. // Check that host manager opens the database correctly and tidy up. If it
// If it fails, print the error message. // fails, print the error message.
try { try {
HostMgr::create(); HostMgr::create();
EXPECT_NO_THROW(HostMgr::addBackend(validMySQLConnectionString())); EXPECT_NO_THROW(HostMgr::addBackend(validMySQLConnectionString()));
@ -264,7 +264,7 @@ TEST(MySqlHostDataSource, OpenDatabaseMultiThreading) {
<< "*** before the MySQL tests will run correctly.\n"; << "*** before the MySQL tests will run correctly.\n";
} }
// Check that host manager open the database opens correctly with a longer // Check that host manager opens the database correctly with a longer
// timeout. If it fails, print the error message. // timeout. If it fails, print the error message.
try { try {
string connection_string = validMySQLConnectionString() + string(" ") + string connection_string = validMySQLConnectionString() + string(" ") +
@ -280,7 +280,7 @@ TEST(MySqlHostDataSource, OpenDatabaseMultiThreading) {
} }
// Check that attempting to get an instance of the host data source when // Check that attempting to get an instance of the host data source when
// none is set throws an exception. // none is set returns empty pointer.
EXPECT_FALSE(HostMgr::instance().getHostDataSource()); EXPECT_FALSE(HostMgr::instance().getHostDataSource());
// Check that wrong specification of backend throws an exception. // Check that wrong specification of backend throws an exception.

16
src/lib/dhcpsrv/tests/pgsql_host_data_source_unittest.cc
View File

@ -161,8 +161,8 @@ TEST(PgSqlHostDataSource, OpenDatabase) {
destroyPgSQLSchema(); destroyPgSQLSchema();
createPgSQLSchema(); createPgSQLSchema();
// Check that host manager open the database opens correctly and tidy up. // Check that host manager opens the database correctly and tidy up. If it
// If it fails, print the error message. // fails, print the error message.
try { try {
HostMgr::create(); HostMgr::create();
EXPECT_NO_THROW(HostMgr::addBackend(validPgSQLConnectionString())); EXPECT_NO_THROW(HostMgr::addBackend(validPgSQLConnectionString()));
@ -174,7 +174,7 @@ TEST(PgSqlHostDataSource, OpenDatabase) {
<< "*** before the PostgreSQL tests will run correctly.\n"; << "*** before the PostgreSQL tests will run correctly.\n";
} }
// Check that host manager open the database opens correctly with a longer // Check that host manager opens the database correctly with a longer
// timeout. If it fails, print the error message. // timeout. If it fails, print the error message.
try { try {
string connection_string = validPgSQLConnectionString() + string(" ") + string connection_string = validPgSQLConnectionString() + string(" ") +
@ -190,7 +190,7 @@ TEST(PgSqlHostDataSource, OpenDatabase) {
} }
// Check that attempting to get an instance of the host data source when // Check that attempting to get an instance of the host data source when
// none is set throws an exception. // none is set returns empty pointer.
EXPECT_FALSE(HostMgr::instance().getHostDataSource()); EXPECT_FALSE(HostMgr::instance().getHostDataSource());
// Check that wrong specification of backend throws an exception. // Check that wrong specification of backend throws an exception.
@ -246,8 +246,8 @@ TEST(PgSqlHostDataSource, OpenDatabaseMultiThreading) {
destroyPgSQLSchema(); destroyPgSQLSchema();
createPgSQLSchema(); createPgSQLSchema();
// Check that host manager open the database opens correctly and tidy up. // Check that host manager opens the database correctly and tidy up. If it
// If it fails, print the error message. // fails, print the error message.
try { try {
HostMgr::create(); HostMgr::create();
EXPECT_NO_THROW(HostMgr::addBackend(validPgSQLConnectionString())); EXPECT_NO_THROW(HostMgr::addBackend(validPgSQLConnectionString()));
@ -259,7 +259,7 @@ TEST(PgSqlHostDataSource, OpenDatabaseMultiThreading) {
<< "*** before the PostgreSQL tests will run correctly.\n"; << "*** before the PostgreSQL tests will run correctly.\n";
} }
// Check that host manager open the database opens correctly with a longer // Check that host manager opens the database correctly with a longer
// timeout. If it fails, print the error message. // timeout. If it fails, print the error message.
try { try {
string connection_string = validPgSQLConnectionString() + string(" ") + string connection_string = validPgSQLConnectionString() + string(" ") +
@ -275,7 +275,7 @@ TEST(PgSqlHostDataSource, OpenDatabaseMultiThreading) {
} }
// Check that attempting to get an instance of the host data source when // Check that attempting to get an instance of the host data source when
// none is set throws an exception. // none is set returns empty pointer.
EXPECT_FALSE(HostMgr::instance().getHostDataSource()); EXPECT_FALSE(HostMgr::instance().getHostDataSource());
// Check that wrong specification of backend throws an exception. // Check that wrong specification of backend throws an exception.