mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-09-02 15:05:16 +00:00
Code Issues Releases Wiki Activity

[1688] use BOOST_FOREACH instead of dedicated for loops.

Browse Source 
this could be slightly more efficient because it avoids redundant calls
to vector::end().  In my experiments I actually didn't see much difference,
but it doesn't harm anyway.
This commit is contained in:
JINMEI Tatuya
2012-03-21 23:33:23 -07:00
parent 4ad96ab57e
commit a6d9e2bc94
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/bin/auth/query.cc
View File

@@ -85,21 +85,18 @@ Query::ResponseCreator::create(Message& response,
assert(added_.empty()); assert(added_.empty());
// Add the RRsets to the message. The order of sections is important, // Add the RRsets to the message. The order of sections is important,
// as the RRsetInserter remembers RRsets added and will not add // as the ResponseCreator remembers RRsets added and will not add
// duplicates. Adding in the order answer, authory, additional will // duplicates. Adding in the order answer, authory, additional will
// guarantee that if there are duplicates, the single RRset added will // guarantee that if there are duplicates, the single RRset added will
// appear in the most important section. // appear in the most important section.
std::vector<isc::dns::ConstRRsetPtr>::const_iterator i; BOOST_FOREACH(const ConstRRsetPtr& rrset, answers) {
for (i = answers.begin(); i != answers.end(); ++i) { addRRset(response, Message::SECTION_ANSWER, rrset, dnssec);
addRRset(response, Message::SECTION_ANSWER, *i, dnssec);
} }
BOOST_FOREACH(const ConstRRsetPtr& rrset, authorities) {
for (i = authorities.begin(); i != authorities.end(); ++i) { addRRset(response, Message::SECTION_AUTHORITY, rrset, dnssec);
addRRset(response, Message::SECTION_AUTHORITY, *i, dnssec);
} }
BOOST_FOREACH(const ConstRRsetPtr& rrset, additionals) {
for (i = additionals.begin(); i != additionals.end(); ++i) { addRRset(response, Message::SECTION_ADDITIONAL, rrset, dnssec);
addRRset(response, Message::SECTION_ADDITIONAL, *i, dnssec);
} }
} }