mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-31 22:15:23 +00:00
Code Issues Releases Wiki Activity

[#1764] Address comments

Browse Source
This commit is contained in:
Francis Dupont
2024-08-21 20:35:35 +02:00
parent 134615472c
commit bb6a1d3b8f
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/lib/http/tests/Makefile.am
View File

@@ -50,6 +50,7 @@ libhttp_unittests_SOURCES += http_client_unittests.cc
libhttp_unittests_SOURCES += http_server_test.h libhttp_unittests_SOURCES += http_server_test.h
libhttp_unittests_SOURCES += http_server_unittests.cc libhttp_unittests_SOURCES += http_server_unittests.cc
if HAVE_OPENSSL if HAVE_OPENSSL
libhttp_unittests_SOURCES += tls_response_creator_test.h
libhttp_unittests_SOURCES += tls_server_unittests.cc libhttp_unittests_SOURCES += tls_server_unittests.cc
libhttp_unittests_SOURCES += tls_client_unittests.cc libhttp_unittests_SOURCES += tls_client_unittests.cc
endif endif

4
src/lib/http/tests/http_client_test.h
View File

@@ -859,13 +859,13 @@ public:
io_service_->stop(); io_service_->stop();
} }
// We should have 1 connect. // We should have 2 connects.
EXPECT_EQ(2, monitor.connect_cnt_); EXPECT_EQ(2, monitor.connect_cnt_);
// We should have 2 handshakes when TLS is enabled. // We should have 2 handshakes when TLS is enabled.
if (client_context_) { if (client_context_) {
EXPECT_EQ(2, monitor.handshake_cnt_); EXPECT_EQ(2, monitor.handshake_cnt_);
} }
// We should have 0 closes // We should have 1 close.
EXPECT_EQ(1, monitor.close_cnt_); EXPECT_EQ(1, monitor.close_cnt_);
// We should have a valid fd. // We should have a valid fd.
ASSERT_GT(monitor.registered_fd_, -1); ASSERT_GT(monitor.registered_fd_, -1);

2
src/lib/http/tests/http_server_test.h
View File

@@ -545,7 +545,7 @@ public:
ASSERT_TRUE(client->isConnectionAlive()); ASSERT_TRUE(client->isConnectionAlive());
// Run IO service for 1000ms. The idle time is set to 500ms, so // Run IO service for 1000ms. The idle time is set to 500ms, so
// the connection should be closed by the server while we wait here. // the connection should be closed by the server while we wait here.
runIOService(1000); runIOService(1000);
// Make sure the connection has been closed. // Make sure the connection has been closed.

1
src/lib/http/tests/tls_server_unittests.cc
View File

@@ -78,7 +78,6 @@ TEST_F(HttpsListenerTest, listen) {
testListen(); testListen();
} }
// This test verifies that persistent HTTP connection can be established when // This test verifies that persistent HTTP connection can be established when
// "Connection: Keep-Alive" header value is specified. // "Connection: Keep-Alive" header value is specified.
TEST_F(HttpsListenerTest, keepAlive) { TEST_F(HttpsListenerTest, keepAlive) {