mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-30 21:45:37 +00:00
Code Issues Releases Wiki Activity

[#1818] Addressed review comments, minor cleanup.

Browse Source 
Minor UT clean up:
src/hooks/dhcp/high_availability/tests/ha_mt_unittest.cc
src/lib/http/tests/mt_client_unittests.cc
This commit is contained in:
Thomas Markwalder
2021-05-17 10:46:46 -04:00
parent 35bc17e593
commit beb731f6b1
2 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/hooks/dhcp/high_availability/tests/ha_mt_unittest.cc
View File

@@ -181,10 +181,6 @@ TEST_F(HAMtServiceTest, multiThreadingBasics) {
// Enable DHCP multi-threading configuration in CfgMgr with 3 threads. // Enable DHCP multi-threading configuration in CfgMgr with 3 threads.
setDHCPMultiThreadingConfig(true, 3); setDHCPMultiThreadingConfig(true, 3);
/// @todo this is a hack... we have chicken-egg... CmdHttpListener won't
/// start if MT is not enabled BUT that happens after config hook point
MultiThreadingMgr::instance().setMode(true);
// Create the HA configuration // Create the HA configuration
HAConfigPtr ha_config(new HAConfig()); HAConfigPtr ha_config(new HAConfig());
HAConfigParser parser; HAConfigParser parser;

8
src/lib/http/tests/mt_client_unittests.cc
View File

@@ -494,13 +494,7 @@ public:
} }
// Loop until the clients are done, an error occurs, or the time runs out. // Loop until the clients are done, an error occurs, or the time runs out.
while (getRRCount() < expected_requests_) { runIOService(expected_requests_);
// Always call restart() before we call run();
io_service_.restart();
// Run until a client stops the service.
io_service_.run();
}
// Client should stop without issue. // Client should stop without issue.
ASSERT_NO_THROW(client_->stop()); ASSERT_NO_THROW(client_->stop());