mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-29 13:07:50 +00:00
Code Issues Releases Wiki Activity

[3908] Addressed last comments

Browse Source
This commit is contained in:
Francis Dupont 2016-11-04 18:33:10 +01:00
parent e981ca8fe1
commit c14e40f952
3 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/cryptolink/botan_hmac.cc
View File

@ -194,8 +194,6 @@ public:
if (digest_.empty()) { if (digest_.empty()) {
digest_ = hmac_->final(); digest_ = hmac_->final();
} }
// digest_.size() == size by construction
// if you are not convinced, add an assert()
return (Botan::same_mem(&digest_[0], return (Botan::same_mem(&digest_[0],
static_cast<const unsigned char*>(sig), static_cast<const unsigned char*>(sig),
len)); len));

12
src/lib/cryptolink/openssl_common.h
View File

@ -36,17 +36,11 @@ public:
explicit SecBuf() : vec_(std::vector<T>()) {} explicit SecBuf() : vec_(std::vector<T>()) {}
explicit SecBuf(size_t n, const T& value = T()) : explicit SecBuf(size_t n, const T& value = T()) : vec_(n, value) {}
vec_(std::vector<T>(n, value))
{}
SecBuf(iterator first, iterator last) : SecBuf(iterator first, iterator last) : vec_(first, last) {}
vec_(std::vector<T>(first, last))
{}
SecBuf(const_iterator first, const_iterator last) : SecBuf(const_iterator first, const_iterator last) : vec_(first, last) {}
vec_(std::vector<T>(first, last))
{}
SecBuf(const std::vector<T>& x) : vec_(x) {} SecBuf(const std::vector<T>& x) : vec_(x) {}

2
src/lib/cryptolink/openssl_hmac.cc
View File

@ -163,8 +163,6 @@ public:
if (len > size) { if (len > size) {
len = size; len = size;
} }
// digest.size() == size by construction
// if you are not convinced, add an assert()
return (digest.same(sig, len)); return (digest.same(sig, len));
} }