mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-30 13:37:55 +00:00
Code Issues Releases Wiki Activity

[#1928] Use EXPECT_EQ instead of ASSERT_EQ

Browse Source
This commit is contained in:
Marcin Siodelski 2021-07-20 12:03:25 +02:00
parent 43ce058995
commit c38c2f21b6
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/lib/mysql/tests/mysql_connection_unittest.cc
View File

@ -547,7 +547,7 @@ TEST_F(MySqlConnectionTest, transactions) {
auto result = rawStatement("SELECT COUNT(*) FROM mysql_connection_test"); auto result = rawStatement("SELECT COUNT(*) FROM mysql_connection_test");
ASSERT_EQ(1, result.size()); ASSERT_EQ(1, result.size());
ASSERT_EQ(1, result[0].size()); ASSERT_EQ(1, result[0].size());
ASSERT_EQ("2", result[0][0]); EXPECT_EQ("2", result[0][0]);
// Add third row but roll back the transaction. We should still have // Add third row but roll back the transaction. We should still have
// two rows in the table. // two rows in the table.
@ -556,7 +556,7 @@ TEST_F(MySqlConnectionTest, transactions) {
conn_.rollback(); conn_.rollback();
ASSERT_EQ(1, result.size()); ASSERT_EQ(1, result.size());
ASSERT_EQ(1, result[0].size()); ASSERT_EQ(1, result[0].size());
ASSERT_EQ("2", result[0][0]); EXPECT_EQ("2", result[0][0]);
// Nested transaction. The inner transaction should be ignored and the outer // Nested transaction. The inner transaction should be ignored and the outer
// transaction rolled back. We should still have two rows in the database. // transaction rolled back. We should still have two rows in the database.
@ -569,7 +569,7 @@ TEST_F(MySqlConnectionTest, transactions) {
result = rawStatement("SELECT COUNT(*) FROM mysql_connection_test"); result = rawStatement("SELECT COUNT(*) FROM mysql_connection_test");
ASSERT_EQ(1, result.size()); ASSERT_EQ(1, result.size());
ASSERT_EQ(1, result[0].size()); ASSERT_EQ(1, result[0].size());
ASSERT_EQ("2", result[0][0]); EXPECT_EQ("2", result[0][0]);
// Nested transaction. The inner transaction is rolled back but this should // Nested transaction. The inner transaction is rolled back but this should
// be ignored because nested transactions are not supported. We should // be ignored because nested transactions are not supported. We should
@ -583,7 +583,7 @@ TEST_F(MySqlConnectionTest, transactions) {
result = rawStatement("SELECT COUNT(*) FROM mysql_connection_test"); result = rawStatement("SELECT COUNT(*) FROM mysql_connection_test");
ASSERT_EQ(1, result.size()); ASSERT_EQ(1, result.size());
ASSERT_EQ(1, result[0].size()); ASSERT_EQ(1, result[0].size());
ASSERT_EQ("4", result[0][0]); EXPECT_EQ("4", result[0][0]);
} }
TEST_F(MySqlConnectionWithPrimaryKeyTest, select) { TEST_F(MySqlConnectionWithPrimaryKeyTest, select) {