mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-09-03 15:35:17 +00:00
Code Issues Releases Wiki Activity

[4206b] Added unit tests for malfromed client id in getLabel.

Browse Source
This commit is contained in:
Marcin Siodelski
2015-12-11 16:13:18 +01:00
parent a158b3d5f2
commit cea271d0ee
2 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/lib/dhcp/tests/pkt4_unittest.cc
View File

@@ -1024,6 +1024,19 @@ TEST_F(Pkt4Test, getLabel) {
} }
// Test that empty client identifier option doesn't cause an exception from
// Pkt4::getLabel.
TEST_F(Pkt4Test, getLabelEmptyClientId) {
Pkt4 pkt(DHCPOFFER, 1234);
// Create empty client identifier option.
OptionPtr empty_opt(new Option(Option::V4, DHO_DHCP_CLIENT_IDENTIFIER));
pkt.addOption(empty_opt);
EXPECT_EQ("[hwtype=1 ], cid=[no info], tid=0x4d2"
" (malformed client-id)", pkt.getLabel());
}
// Tests that the variant of makeLabel which doesn't include transaction // Tests that the variant of makeLabel which doesn't include transaction
// id produces expected output. // id produces expected output.
TEST_F(Pkt4Test, makeLabelWithoutTransactionId) { TEST_F(Pkt4Test, makeLabelWithoutTransactionId) {

11
src/lib/dhcp/tests/pkt6_unittest.cc
View File

@@ -1530,4 +1530,15 @@ TEST_F(Pkt6Test, getLabel) {
} }
// Test that empty client identifier option doesn't cause an exception from
// Pkt6::getLabel.
TEST_F(Pkt6Test, getLabelEmptyClientId) {
// Create a packet.
Pkt6 pkt(DHCPV6_SOLICIT, 0x2312);
// Add empty client idenitifier option.
pkt.addOption(OptionPtr(new Option(Option::V6, D6O_CLIENTID)));
EXPECT_EQ("duid=[no info], tid=0x2312", pkt.getLabel());
}
} }