mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-09-03 15:35:17 +00:00
Code Issues Releases Wiki Activity

[#2658] address review comments

Browse Source
This commit is contained in:
Andrei Pavel
2023-05-17 19:09:39 +03:00
parent ea9698b5a8
commit d5704c8cca
2 changed files with 6 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/bin/dhcp4/tests/fqdn_unittest.cc
View File

@@ -908,21 +908,6 @@ public:
ASSERT_TRUE(obs) << "cannot find: " << stats_name; ASSERT_TRUE(obs) << "cannot find: " << stats_name;
EXPECT_EQ(exp_value, obs->getInteger().first); EXPECT_EQ(exp_value, obs->getInteger().first);
} }
/// @brief Checks the value of a big integer statistic for a given subnet.
///
/// @param subnet_id identifier of a subnet for which the statistic should be checked
/// @param name statistic name (e.g. "total-nas", "total-pds", ...)
/// @param exp_value expected value of the statistic
///
/// @return Number of assigned addresses for a subnet.
void checkBigSubnetStat(const SubnetID& subnet_id, const std::string& name, int64_t exp_value) const {
// Retrieve statistics name, e.g. subnet[1234].assigned-addresses.
const std::string stats_name = StatsMgr::generateName("subnet", subnet_id, name);
ObservationPtr obs = StatsMgr::instance().getObservation(stats_name);
ASSERT_TRUE(obs) << "cannot find: " << stats_name;
EXPECT_EQ(exp_value, obs->getBigInteger().first);
}
}; };
// Tests the following scenario: // Tests the following scenario:

8
src/lib/cc/data.h
View File

@@ -215,7 +215,8 @@ public:
/// @name pure virtuals, every derived class must implement these /// @name pure virtuals, every derived class must implement these
/// @return true if the other ElementPtr has the same type and value /// @return true if the other ElementPtr has the same value and the same
/// type (or a different and compatible type), false otherwise.
virtual bool equals(const Element& other) const = 0; virtual bool equals(const Element& other) const = 0;
/// Converts the Element to JSON format and appends it to /// Converts the Element to JSON format and appends it to
@@ -656,7 +657,10 @@ public:
/// stringstream. /// stringstream.
void toJSON(std::ostream& ss) const override; void toJSON(std::ostream& ss) const override;
/// @brief Checks whether the other Element has the same type and value. /// @brief Checks whether the other Element is equal.
///
/// @return true if the other ElementPtr has the same value and the same
/// type (or a different and compatible type), false otherwise.
bool equals(const Element& other) const override; bool equals(const Element& other) const override;
private: private: