mir/kea
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-10-03 13:16:15 +00:00
Code Issues Releases Wiki Activity

[#115,!48] exception throwing replaced with gentler error logs

Browse Source
This commit is contained in:
Tomek Mrugalski
2018-11-08 02:58:25 +07:00
parent 9c17656551
commit e7d240e268
4 changed files with 25 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/lib/database/database_connection.cc
View File

@@ -10,6 +10,7 @@
#include <database/database_connection.h>
#include <database/db_exceptions.h>
#include <database/db_log.h>
#include <database/db_messages.h>
#include <exceptions/exceptions.h>
#include <boost/algorithm/string.hpp>
@@ -174,8 +175,8 @@ DatabaseConnection::toElement(const ParameterMap& params) {
int_value = boost::lexical_cast<int64_t>(value);
result->set(keyword, isc::data::Element::create(int_value));
} catch (...) {
isc_throw(ToElementError, "invalid DB access "
<< "integer parameter: " << keyword << "=" << value);
LOG_ERROR(database_logger, DATABASE_TO_JSON_ERROR)
.arg("integer").arg(keyword).arg(value);
}
} else if ((keyword == "persist") ||
(keyword == "readonly") ||
@@ -186,8 +187,8 @@ DatabaseConnection::toElement(const ParameterMap& params) {
} else if (value == "false") {
result->set(keyword, isc::data::Element::create(false));
} else {
isc_throw(ToElementError, "invalid DB access "
<< "boolean parameter: " << keyword << "=" << value);
LOG_ERROR(database_logger, DATABASE_TO_JSON_ERROR)
.arg("boolean").arg(keyword).arg(value);
}
} else if ((keyword == "type") ||
(keyword == "user") ||
@@ -198,8 +199,8 @@ DatabaseConnection::toElement(const ParameterMap& params) {
(keyword == "keyspace")) {
result->set(keyword, isc::data::Element::create(value));
} else {
isc_throw(ToElementError, "unknown DB access parameter: "
<< keyword << "=" << value);
LOG_ERROR(database_logger, DATABASE_TO_JSON_ERROR)
.arg("unknown").arg(keyword).arg(value);
}
}