mirror of
https://gitlab.isc.org/isc-projects/kea
synced 2025-08-22 09:57:41 +00:00
[#3287] address review
This commit is contained in:
parent
3efbe09a45
commit
f11dd59433
@ -152,14 +152,14 @@ list_commands_test() {
|
|||||||
|
|
||||||
# shellcheck disable=SC2086
|
# shellcheck disable=SC2086
|
||||||
# SC2086: Double quote to prevent globbing and word splitting.
|
# SC2086: Double quote to prevent globbing and word splitting.
|
||||||
# Reason: we spcifically want ${arguments} to split because there may be multiple words in it.
|
# Reason: we specifically want ${arguments} to split because there may be multiple words in it.
|
||||||
tmp="echo | ${shell_bin_path}/${shell_bin} --port 8443 \
|
tmp="echo | ${shell_bin_path}/${shell_bin} --port 8443 \
|
||||||
${arguments} > ${tmpfile_path}/shell-stdout.txt"
|
${arguments} > ${tmpfile_path}/shell-stdout.txt"
|
||||||
echo "Executing kea-shell ($tmp)"
|
echo "Executing kea-shell ($tmp)"
|
||||||
|
|
||||||
# shellcheck disable=SC2086
|
# shellcheck disable=SC2086
|
||||||
# SC2086: Double quote to prevent globbing and word splitting.
|
# SC2086: Double quote to prevent globbing and word splitting.
|
||||||
# Reason: we spcifically want ${arguments} to split because there may be multiple words in it.
|
# Reason: we specifically want ${arguments} to split because there may be multiple words in it.
|
||||||
echo | ${shell_bin_path}/${shell_bin} --port 8443 \
|
echo | ${shell_bin_path}/${shell_bin} --port 8443 \
|
||||||
${arguments} > ${tmpfile_path}/shell-stdout.txt
|
${arguments} > ${tmpfile_path}/shell-stdout.txt
|
||||||
EXIT_CODE=$?
|
EXIT_CODE=$?
|
||||||
|
@ -90,7 +90,7 @@ for file in ${files}; do
|
|||||||
# 4. replace all '[ <DATA> ]' with '[ "<DATA>" ]' where DATA contains: '-' and 'A-Za-z0-9' and ' '
|
# 4. replace all '[ <DATA> ]' with '[ "<DATA>" ]' where DATA contains: '-' and 'A-Za-z0-9' and ' '
|
||||||
# 5. replace all ' <DATA>:' with ' "<DATA>":'
|
# 5. replace all ' <DATA>:' with ' "<DATA>":'
|
||||||
# 6. replace all ': <DATA>' with ': "<DATA>"'
|
# 6. replace all ': <DATA>' with ': "<DATA>"'
|
||||||
# 7. replace ' ...' with ' "placeholder": "value"
|
# 7. replace ' ...' with ' "placeholder": "value"'
|
||||||
# 8. replace ', ... ' with ' '
|
# 8. replace ', ... ' with ' '
|
||||||
# 9. replace ' <DATA>' with ' "placeholder": "value"'
|
# 9. replace ' <DATA>' with ' "placeholder": "value"'
|
||||||
# 10. replace ' <DATA>' with ' "placeholder"'
|
# 10. replace ' <DATA>' with ' "placeholder"'
|
||||||
|
@ -85,7 +85,7 @@ $header
|
|||||||
EOF
|
EOF
|
||||||
# shellcheck disable=SC2016
|
# shellcheck disable=SC2016
|
||||||
# SC2016: Expressions don't expand in single quotes, use double quotes for that.
|
# SC2016: Expressions don't expand in single quotes, use double quotes for that.
|
||||||
# Reason: we spcifically do not want $0 to expand.
|
# Reason: we specifically do not want $0 to expand.
|
||||||
@AWK@ '/^.+$/ { print " ",$0 }; /^$/ { print } ' $output.2 >> $output.3
|
@AWK@ '/^.+$/ { print " ",$0 }; /^$/ { print } ' $output.2 >> $output.3
|
||||||
cat $output.3
|
cat $output.3
|
||||||
else
|
else
|
||||||
|
Loading…
x
Reference in New Issue
Block a user