2
0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-09-02 23:15:20 +00:00

[2206] Update doc comments to remove redundant bits

Also correct comments where wrong, and add a code comment for
ZoneTableSegment::create().
This commit is contained in:
Mukund Sivaraman
2012-10-03 09:33:54 +05:30
parent 1ab6aafab6
commit f2b62e2480
3 changed files with 27 additions and 23 deletions

View File

@@ -21,7 +21,11 @@ namespace memory {
ZoneTableSegment* ZoneTableSegment*
ZoneTableSegment::create(const isc::data::Element&) { ZoneTableSegment::create(const isc::data::Element&) {
return (new ZoneTableSegmentLocal); /// FIXME: For now, we always return ZoneTableSegmentLocal. This
/// should be updated eventually to parse the passed Element
/// argument and construct a corresponding ZoneTableSegment
/// implementation.
return (new ZoneTableSegmentLocal);
} }
} // namespace memory } // namespace memory

View File

@@ -27,35 +27,37 @@ namespace isc {
namespace datasrc { namespace datasrc {
namespace memory { namespace memory {
/// \brief Zone Table Header Class /// \brief Memory-management independent entry point that contains a
/// pointer to a zone table in memory.
///
/// An instance of this type lives inside a ZoneTableSegment
/// implementation. It contains an offset pointer to the zone table (a
/// map from domain names to zone locators) in memory.
struct ZoneTableHeader { struct ZoneTableHeader {
boost::interprocess::offset_ptr<ZoneTable> table; boost::interprocess::offset_ptr<ZoneTable> table;
}; };
/// \brief Zone Table Segment Class /// \brief Manages a ZoneTableHeader, an entry point into a table of
/// zones
/// ///
/// This class specifies an interface for derived implementations which /// This class specifies an interface for derived implementations which
/// return a pointer to an object of type ZoneTableHeader, an entry /// return a pointer to an object of type ZoneTableHeader, an entry
/// point of some memory image regardless of the underlying memory /// point into a table of zones regardless of the underlying memory
/// management implementation. /// management implementation. Derived classes would implement the
/// interface for specific memory-implementation behavior.
class ZoneTableSegment { class ZoneTableSegment {
public: public:
/// \brief Destructor /// \brief Destructor
virtual ~ZoneTableSegment() {} virtual ~ZoneTableSegment() {}
/// \brief Return a ZoneTableHeader for the zone table segment. /// \brief Return the ZoneTableHeader for the zone table segment.
/// ///
/// Returns a ZoneTableHeader that contains a pointer to the zone /// \return Returns the ZoneTableHeader for this zone table segment.
/// table data in memory.
///
/// \return Returns a ZoneTableHeader for this zone table segment.
virtual ZoneTableHeader* getHeader() = 0; virtual ZoneTableHeader* getHeader() = 0;
/// \brief Return the MemorySegment for the zone table segment. /// \brief Return the MemorySegment for the zone table segment.
/// ///
/// Returns the MemorySegment used in this zone table segment. /// \return Returns the ZoneTableHeader for this zone table segment.
///
/// \return Returns a ZoneTableHeader for this zone table segment.
virtual isc::util::MemorySegment& getMemorySegment() = 0; virtual isc::util::MemorySegment& getMemorySegment() = 0;
/// \brief Create a subclass depending on the memory segment model /// \brief Create a subclass depending on the memory segment model

View File

@@ -22,7 +22,7 @@ namespace isc {
namespace datasrc { namespace datasrc {
namespace memory { namespace memory {
/// \brief MemorySegmentLocal based Zone Table Segment class /// \brief Local implementation of ZoneTableSegment class
/// ///
/// This class specifies a concrete implementation for a /// This class specifies a concrete implementation for a
/// MemorySegmentLocal based ZoneTableSegment. Please see the /// MemorySegmentLocal based ZoneTableSegment. Please see the
@@ -32,19 +32,17 @@ public:
/// \brief Destructor /// \brief Destructor
virtual ~ZoneTableSegmentLocal() {} virtual ~ZoneTableSegmentLocal() {}
/// \brief Return a ZoneTableHeader for the zone table segment. /// \brief Return the ZoneTableHeader for the local zone table
/// segment implementation.
/// ///
/// Returns a ZoneTableHeader that contains a pointer to the zone /// \return Returns the ZoneTableHeader for this zone table segment.
/// table data in memory.
///
/// \return Returns a ZoneTableHeader for this zone table segment.
virtual ZoneTableHeader* getHeader(); virtual ZoneTableHeader* getHeader();
/// \brief Return the MemorySegment for the zone table segment. /// \brief Return the MemorySegment for the local zone table segment
/// implementation.
/// ///
/// Returns the MemorySegment used in this zone table segment. /// \return Returns the MemorySegment for this zone table segment (a
/// /// MemorySegmentLocal instance).
/// \return Returns a ZoneTableHeader for this zone table segment.
virtual isc::util::MemorySegment& getMemorySegment(); virtual isc::util::MemorySegment& getMemorySegment();
private: private: