Thomas Markwalder
36b8bfd263
[ #3831 ] Error on bad lease file path
...
/doc/examples/kea4/all-keys-netconf.json
/doc/examples/kea4/all-keys.json
/doc/examples/kea4/dhcpv4-over-dhcpv6.json
/doc/examples/kea6/all-keys-netconf.json
/doc/examples/kea6/all-keys.json
/doc/examples/kea6/dhcpv4-over-dhcpv6.json
Remove "/tmp" from lease file names
/src/bin/admin/tests/memfile_tests.sh.in
/src/bin/dhcp4/tests/dhcp4_process_tests.sh.in
/src/bin/dhcp6/tests/dhcp6_process_tests.sh.in
export KEA_DHCP_DATA_DIR
/src/bin/shell/tests/dhcp4_basic_auth_tests.sh.in
/src/bin/shell/tests/dhcp6_basic_auth_tests.sh.in
/src/bin/shell/tests/shell_dhcp4_process_tests.sh.in
/src/bin/shell/tests/shell_dhcp6_process_tests.sh.in
/src/bin/shell/tests/tls_dhcp4_process_tests.sh.in
/src/bin/shell/tests/tls_dhcp6_process_tests.sh.in
/src/lib/dhcpsrv/dhcpsrv_messages.*
Replace WARN message with DHCPSRV_MEMFILE_FAILED_TO_OPEN error
/src/lib/dhcpsrv/memfile_lease_mgr.cc
Memfile_LeaseMgr::getDefaultLeaseFilePath()
- uses CfgMgr::getDataDir()
Memfile_LeaseMgr::initLeaseFilePath()
- call CfgMgr::validatePath() without try-catch
Memfile_LeaseMgr::factory()
- log error and rethrow
/src/lib/dhcpsrv/tests/cfgmgr_unittest.cc
Added use of EnvVarWrapper
/src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
Updated tests
TEST_F(MemfileLeaseMgrTest, defaultDataDir)
TEST_F(MemfileLeaseMgrTest, dataDirEnvVarOverride)
TEST_F(MemfileLeaseMgrTest, dataDirExplicitOveride)
- new tests
/src/lib/testutils/Makefile.am
Added env_var_wrapper.*
2025-05-16 12:20:43 +03:00
Thomas Markwalder
98ba652fbc
[ #3831 ] Fix UT Makefile.am files
2025-05-16 12:20:43 +03:00
Thomas Markwalder
26c63d4a14
[ #3831 ] Replaced CfgMgr::data_dir_ with PathChecker
...
/src/bin/dhcp4/tests/dhcp4_test_utils.cc
UpdatedModified BaseServerTest
/src/bin/dhcp4/tests/meson.build
Added DHCP_DATA_DIR
/src/bin/dhcp6/dhcp6_messages.*
DHCP6_DATA_DIRECTORY_DEPRECATED - new message
/src/bin/dhcp6/dhcp6_parser.yy
Add warning to data_dir parsing
/src/bin/dhcp6/json_config_parser.cc
Emit a warning if config contains data-directory
/src/bin/dhcp6/tests/Makefile.am
Added DHCP_DATA_DIR
/src/bin/dhcp6/tests/config_parser_unittest.cc
TEST_F(Dhcp6ParserTest, testDataDir) - updated test
/src/bin/dhcp6/tests/dhcp6_test_utils.cc
UpdatedModified BaseServerTest
/src/bin/dhcp6/tests/hooks_unittest.cc
LoadUnloadDhcpv6SrvTest now derives from BaseServerTest
/src/bin/dhcp6/tests/meson.build
Added DHCP_DATA_DIR
/src/lib/dhcpsrv/cfgmgr.*
Replace Optional<string> datadir_ with PathChecker
data_dir_checker_
CfgMgr::getDataDir() - updated
CfgMgr::validatePath() - added
/src/lib/dhcpsrv/srv_config.cc
SrvConfig::toElement() - remove output of data-directory
/src/lib/dhcpsrv/tests/Makefile.am
Added DHCP_DATA_DIR
/src/lib/dhcpsrv/tests/cfg_duid_unittest.cc
Updated absolutePath()
/src/lib/dhcpsrv/tests/cfgmgr_unittest.cc
Updated tests
/src/lib/dhcpsrv/tests/csv_lease_file4_unittest.cc
/src/lib/dhcpsrv/tests/csv_lease_file6_unittest.cc
/src/lib/dhcpsrv/tests/lease_file_loader_unittest.cc
/src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
Updated absolutePath()
/src/lib/dhcpsrv/tests/meson.build
Added DHCP_DATA_DIR
2025-05-16 12:20:43 +03:00
Thomas Markwalder
2f304f6ca7
[ #3831 ] Refactored FileManager into PathChecker
...
Refactored to internally support env variable and explicit paths
modified:
src/lib/hooks/hooks_parser.cc
src/lib/hooks/hooks_parser.h
src/lib/util/filesystem.cc
src/lib/util/filesystem.h
src/lib/util/tests/filesystem_unittests.cc
2025-05-16 12:20:43 +03:00
Thomas Markwalder
f42a77238d
[ #3830 ] Fixed netconf UT tests
...
/src/bin/netconf/tests/Makefile.am
/src/bin/netconf/tests/meson.build
Added NETCONF_HOOKS_TEST_PATH
/src/bin/netconf/tests/netconf_cfg_mgr_unittests.cc
NetconfParserTest - added set and reset of hooks path
TEST_F(NetconfParserTest, configParseHooks) - call setHooksTestPath()
2025-05-16 12:20:43 +03:00
Andrei Pavel
707981812e
[ #3832 ] Meson: Add install_umask=0027
...
This makes directories 750 and files 640 by default.
2025-05-16 12:20:43 +03:00
Francis Dupont
03aac8f424
[ #3832 ] Reindented
2025-05-16 12:20:43 +03:00
Francis Dupont
919d3cbbb6
[ #3832 ] Extra fix
2025-05-16 12:20:43 +03:00
Francis Dupont
e214d62395
[ #3832 ] Added umask to admin and keactrl
2025-05-16 12:20:43 +03:00
Francis Dupont
d91aa4203c
[ #3832 ] Added umask 0027 setting
2025-05-16 12:20:43 +03:00
Francis Dupont
923990b389
[ #3832 ] Checkpoint: removed #3050 and fixes
2025-05-16 12:20:43 +03:00
Thomas Markwalder
3403f15dc7
[ #3830 ] Removed obsolete UT
...
modified: dhcp_parsers_unittest.cc
2025-05-16 12:20:43 +03:00
Thomas Markwalder
8121c96c1a
[ #3830 ] Fix release mention in ARM
...
modified: hooks.rst
2025-05-16 12:20:42 +03:00
Thomas Markwalder
5caceadf72
[ #3830 ] Addressed further review comments
...
Minor cleanup and fixed hooks partesr UTs
modified: src/lib/hooks/hooks_parser.h
modified: src/lib/hooks/tests/hooks_manager_unittest.cc
2025-05-16 12:20:42 +03:00
Francis Dupont
8196e0cadf
[ #3830 ] Small fixes
2025-05-16 12:20:42 +03:00
Thomas Markwalder
dd87e1d30f
[ #3830 ] Updated the ARM
2025-05-16 12:20:42 +03:00
Thomas Markwalder
e4fad9f2bf
[ #3830 ] Addressed review comments
...
src/lib/util/filesystem.cc
Replaced use of std::filesystem with isc:util::Path
src/lib/hooks/hooks_parser.cc
src/lib/hooks/hooks_parser.h
HooksLibrariesParser::getHooksPath() - provides the
ability to set it to an explicit value
Updated A LOT of UTs:
src/bin/agent/tests/ca_cfg_mgr_unittests.cc
src/bin/agent/tests/ca_process_tests.sh.in
src/bin/agent/tests/get_config_unittest.cc
src/bin/agent/tests/test_callout_libraries.h.in
src/bin/d2/tests/d2_cfg_mgr_unittests.cc
src/bin/d2/tests/d2_process_tests.sh.in
src/bin/d2/tests/d2_process_unittests.cc
src/bin/d2/tests/get_config_unittest.cc
src/bin/d2/tests/test_callout_libraries.h.in
src/bin/d2/tests/test_configured_libraries.h.in
src/bin/dhcp4/tests/config_parser_unittest.cc
src/bin/dhcp4/tests/ctrl_dhcp4_srv_unittest.cc
src/bin/dhcp4/tests/dhcp4_process_tests.sh.in
src/bin/dhcp4/tests/hooks_unittest.cc
src/bin/dhcp4/tests/http_control_socket_unittest.cc
src/bin/dhcp4/tests/test_libraries.h.in
src/bin/dhcp6/tests/config_parser_unittest.cc
src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc
src/bin/dhcp6/tests/dhcp6_process_tests.sh.in
src/bin/dhcp6/tests/hooks_unittest.cc
src/bin/dhcp6/tests/http_control_socket_unittest.cc
src/bin/dhcp6/tests/test_libraries.h.in
src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
src/lib/dhcpsrv/tests/test_libraries.h.in
src/lib/hooks/tests/Makefile.am
src/lib/hooks/tests/hooks_manager_unittest.cc
src/lib/hooks/tests/test_libraries.h.in
src/lib/process/cfgrpt/tests/config_report_unittests.cc
src/lib/util/tests/filesystem_unittests.cc
2025-05-16 12:20:42 +03:00
Thomas Markwalder
ad245f5f7a
[ #3830 ] Updated ChangeLog
2025-05-16 12:20:42 +03:00
Thomas Markwalder
73e50310d6
[ #3830 ] Fix ChangeLog spaces
2025-05-16 12:20:42 +03:00
Thomas Markwalder
4f8b1dc282
[ #3830 ] Added ChangeLog entry file
...
new file: 3830-CVE-2025-32801-Allow-loading-hook--ibraries-only-from-default-path
2025-05-16 12:20:42 +03:00
Thomas Markwalder
433593f231
[ #3830 ] Updated ARM
...
modified: doc/sphinx/arm/hooks.rst
modified: src/lib/hooks/tests/hooks_manager_unittest.cc
modified: src/lib/util/tests/filesystem_unittests.cc
2025-05-16 12:20:42 +03:00
Thomas Markwalder
4afdeb7719
[ #3830 ] Hook libraries must load from default hook dir
...
/src/lib/util/filesystem.*
FileManager::validatePath() - new class and function
/src/lib/hooks/hooks_parser.*
HooksLibrariesParser::validatePath() - new wrapper around FileManager::validatePath()
HooksLibrariesParser::parse() - now uses validatePath()
/src/lib/hooks/tests/hooks_manager_unittest.cc
TEST(HooksParser, validatePathEnforcePath)
TEST(HooksParser, validatePathEnforcePathFalse) - new tests
/src/lib/util/tests/filesystem_unittests.cc
TEST(FileManager, validatePathEnforcePath)
TEST(FileManager, validatePathEnforcePathFalse) - new tests
2025-05-16 12:20:42 +03:00
Andrei Pavel
121b71ae2f
[ #3789 ] Extend the change to upgrade scripts down to Kea 2.6
2025-05-16 11:20:13 +03:00
Andrei Pavel
5683641bf3
[ #3789 ] Extend the change to upgrade scripts down to Kea 2.6
2025-05-14 09:46:40 +03:00
Andrei Pavel
f5bcf91497
[ #3789 ] Check only major version in upgrade scripts to allow for intermediary backported schema changes
2025-05-14 09:32:39 +03:00
Andrei Pavel
e8e51c4235
[ #3734 ] Replace non-POSIX "cp -T"
2025-05-09 18:23:00 +03:00
Andrei Pavel
980ff2dfd2
[ #3866 ] Meson: Fix SOURCE_OF_INSTALLATION when git is not installed
2025-05-06 11:50:33 +03:00
Andrei Pavel
0ffbaa27a9
[ #3866 ] Meson: disable b_lundef to fix sanitizers
2025-05-05 08:14:43 +03:00
Andrei Pavel
bef3018afb
[ #3866 ] Meson: reinstall.sh now looks into the srcdir for YANG modules
2025-05-05 08:14:43 +03:00
Doug Freed
fca5b10f4d
[ #3870 ] Forward port Suzanne's fixes from #3869
2025-05-01 12:35:53 -05:00
Wlodek Wencel
b0f28fc21f
[ #3868 ] bump up version in meson.build
2025-04-30 12:05:58 -05:00
Andrei Pavel
ec56ec8bdb
[ #3864 ] More release changes
2025-04-29 12:36:24 +03:00
Wlodek Wencel
8f1a25b640
[ #3864 ] release changes
2025-04-29 01:30:27 -05:00
Wlodek Wencel
215a653d47
[ #3863 ] lib version bump up
2025-04-29 07:12:56 +02:00
Andrei Pavel
2ff28294aa
[ #3763 ] Add ChangeLog entry
2025-04-28 14:53:19 +00:00
Andrei Pavel
60f8b468d6
[ #3763 ] Add precautionary continue handlers to lease AUPD triggers
2025-04-28 14:53:19 +00:00
Andrei Pavel
5c9c66c715
[ #3732 ] Meson: Fix devel docs
2025-04-28 09:41:17 +03:00
Andrei Pavel
f86f509606
[ #3732 ] Do not run fuzz jobs on MR creation
2025-04-28 09:41:16 +03:00
Andrei Pavel
737181c480
[ #3732 ] Meson: Fix devel
2025-04-27 16:57:19 +03:00
Andrei Pavel
cc9a1fd5df
[ #3732 ] Fix tee in ld.so.conf in fuzzing
2025-04-27 16:56:40 +03:00
Andrei Pavel
92d57a18a8
[ #3732 ] Switch Clusterfuzzlite to Meson
2025-04-26 22:26:08 +03:00
Andrei Pavel
7c00eb6c9c
[ #3732 ] Do not run fuzz jobs on MR creation
2025-04-26 10:42:27 +03:00
Andrei Pavel
ef10de4ff2
[ #3732 ] Meson: Create HTML devel docs in build directory not in source directory
2025-04-26 07:55:17 +03:00
Andrei Pavel
df1c04ca1f
[ #3732 ] Fix NETCONF rpaths
2025-04-25 18:45:15 +03:00
Andrei Pavel
a3f69d7430
[ #3732 ] Meson: Make gtest simple dependency + fallback
...
The gtest.cc compiler check misleadingly fails on some systems...
2025-04-25 18:45:15 +03:00
Andrei Pavel
4a9fcdb2f5
[ #3732 ] Migrate tools/print-generated-files.sh away from autotools
2025-04-25 09:33:06 +03:00
Andrei Pavel
3133dc2b58
[ #3732 ] Meson: Remove GTEST_DEP from src/lib/process
2025-04-24 22:44:57 +03:00
Andrei Pavel
f75f951dba
[ #3732 ] Meson: Fix GTest detection
2025-04-24 16:04:31 +03:00
Andrei Pavel
2b9efcd908
[ #3732 ] Meson: Fix postgresql fallback
2025-04-24 16:04:30 +03:00
Andrei Pavel
6cc2e1fbc7
[ #3732 ] Fix meson.sh
2025-04-24 16:04:30 +03:00
