Changes to be committed:
new file: changelog_unreleased/3921-restrictions-on-log-directory-break-syslog-logging
modified: src/lib/process/log_parser.cc
modified: src/lib/process/tests/log_parser_unittests.cc
/src/bin/dhcp4/dhcp4_srv.cc
Dhcpv4Srv::processLocalizedQuery4() - pass in current host to callout
/src/bin/dhcp4/tests/hooks_unittest.cc
Update UTs to check for host argument
/src/hooks/dhcp/ping_check/ping_check_callouts.cc
lease4_offer() - pass host argument to PingCheckMgr::shouldPing()
/src/hooks/dhcp/ping_check/ping_check_mgr.*
PingCheckMgr::shouldPing() - added host parameter and altered
logic to skip ping if lease is active or reserved
/src/hooks/dhcp/ping_check/tests/ping_check_mgr_unittests.cc
Updated UTs
Fixed minor comments, updated error text in two UTs.
new file: changelog_unreleased/3659-enable-lease-caching-as-default
modified: src/lib/dhcpsrv/tests/cfg_subnets4_unittest.cc
modified: src/lib/dhcpsrv/tests/cfg_subnets6_unittest.cc
modified: src/lib/testutils/test_to_element.cc
modified: src/lib/testutils/test_to_element.h
/doc/sphinx/arm/dhcp4-srv.rst
/doc/sphinx/arm/dhcp4-srv.rst
Updated Lease Caching section
/src/hooks/dhcp/subnet_cmds/tests/subnet4_cmds_unittest.cc
/src/hooks/dhcp/subnet_cmds/tests/subnet6_cmds_unittest.cc
/src/lib/dhcpsrv/tests/cfg_subnets4_unittest.cc
/src/lib/dhcpsrv/tests/cfg_subnets6_unittest.cc
/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
/src/lib/dhcpsrv/tests/network_unittest.cc
/src/lib/dhcpsrv/tests/shared_network_parser_unittest.cc
/src/lib/dhcpsrv/parsers/base_network_parser.cc
BaseNetworkParser::parseCacheParams() - altered parsing to
permit threshold of 0.0
/src/lib/dhcpsrv/parsers/simple_parser4.cc
/src/lib/dhcpsrv/parsers/simple_parser6.cc
Set global default for threshold to 0.25
/src/lib/testutils/test_to_element.*
assertEqWithDiff() - new variant that ASSERT when not equivalent
Working, have some UTs that still need to be fixed
/doc/examples/kea4/advanced.json
/doc/examples/kea4/all-keys-netconf.json
/doc/examples/kea4/all-keys-netconf.json
/doc/examples/kea4/all-keys.json
/doc/examples/kea4/comments.json
/doc/examples/kea4/config-backend.json
/doc/examples/kea4/ha-load-balancing-server1-mt-with-tls.json
/doc/examples/kea4/ha-load-balancing-server2-mt.json
/doc/examples/kea6/advanced.json
/doc/examples/kea6/all-keys-netconf.json
/doc/examples/kea6/all-keys.json
/doc/examples/kea6/comments.json
/doc/examples/kea6/config-backend.json
/doc/examples/kea6/ha-hot-standby-server1-with-tls.json
/doc/examples/kea6/ha-hot-standby-server2.json
removed /tmp path from socket-name
/src/bin/dhcp4/tests/config_parser_unittest.cc
/src/bin/dhcp4/tests/ctrl_dhcp4_srv_unittest.cc
/src/bin/dhcp4/tests/dhcp4_srv_unittest.cc
/src/bin/dhcp4/tests/dhcp4_test_utils.cc
/src/bin/dhcp4/tests/dhcp4_test_utils.h
/src/bin/dhcp6/tests/config_parser_unittest.cc
/src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc
/src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
/src/bin/dhcp6/tests/dhcp6_test_utils.cc
/src/bin/dhcp6/tests/dhcp6_test_utils.h
updated tests
/src/lib/config/Makefile.am
/src/lib/config/meson.build
defined CONTROL_SOCKET_DIR
/src/lib/config/tests/unix_command_config_unittests.cc
/src/lib/config/tests/unix_command_mgr_unittests.cc
updated tests
/src/lib/config/unix_command_config.*
UnixCommandConfig - added PathChecker singleton and methods
to set and validate socket path/permissions
/src/lib/util/filesystem.*
Added getPermsissions() and hasPermsission()
/src/lib/util/tests/filesystem_unittests.cc
new permissions tests
/src/lib/dhcpsrv/Makefile.am
Changed LEGAL_LOG_DIR to use log vs lib
/src/lib/dhcpsrv/legal_log_mgr.*
LegalLogMgr - added PathChecker singleton and funcs
/src/lib/dhcpsrv/meson.build
Defined LEGAL_LOG_DIR
/src/lib/util/filesystem.*
PathChecker::validateDirectory() - new func
/src/lib/util/tests/filesystem_unittests.cc
TEST(PathChecker, validateDirectoryEnforcePath)
TEST(PathChecker, validateDirectoryEnforcePathFalse) - new tests