Marcin Siodelski
1d0b6efdc9
[#642,!373] Do not allow to update the logical server 'all'.
2019-06-27 14:51:31 -04:00
Marcin Siodelski
72bc8cc964
[#642,!373] Addressed review comments.
...
- Don't allow for deleting logical server 'all'.
- Additional tests to make sure that other servers aren't affected by deletion.
- Added note that getAll() doesn't return logical server all.
2019-06-27 14:51:31 -04:00
Francis Dupont
9346fb8859
[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] Changed new schema to 8.1 (vs 9.0) and addressed trivial comments
2019-06-27 14:51:31 -04:00
Francis Dupont
a621db7001
[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] Restored missing space (indent)
2019-06-27 14:51:31 -04:00
Francis Dupont
75a976fc7c
[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] Minor comment fixes in hook header files
2019-06-27 14:51:31 -04:00
Francis Dupont
dee370a744
[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] Extra space in indent
2019-06-27 14:51:31 -04:00
Francis Dupont
e890662f7a
[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] spelling
2019-06-27 14:51:31 -04:00
Francis Dupont
6ff46f1842
[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] overriden -> overridden (in src, not fixed in doc
2019-06-27 14:51:31 -04:00
Francis Dupont
4e4573397d
[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] spelling
2019-06-27 14:51:31 -04:00
Francis Dupont
feca2ffb39
[642-update-mysql-cb-with-calls-to-set-delete-and-retrieve-servers] spelling
2019-06-27 14:51:31 -04:00
Marcin Siodelski
0a648a9efb
[#642,!373] Explained how globals are fetched for various selectors.
2019-06-27 14:51:31 -04:00
Marcin Siodelski
4503644458
[#642,!373] Added log messages for functions deleting servers.
2019-06-27 14:51:31 -04:00
Marcin Siodelski
87c78496b2
[#642,!373] Server tags supported for global params in MySQL CB.
2019-06-27 14:51:31 -04:00
Marcin Siodelski
90a950d108
[#642,!373] Extended StampedElement to hold multiple server tags.
2019-06-27 14:51:31 -04:00
Marcin Siodelski
4b491c0850
[#642,!373] Check that it is possible to delete global param for server tag
2019-06-27 14:51:31 -04:00
Marcin Siodelski
3b6df1cffb
[#642,!373] Global parameters may be associated with server tags.
2019-06-27 14:51:31 -04:00
Marcin Siodelski
ad8a7cd71f
[#642,!373] Updated MySQL Config Backend with simple server mgmt functions.
2019-06-27 14:51:31 -04:00
Francis Dupont
8ca1021809
[616-error-msgs-contain-references-to-config-file-while-config-backend-is-used] Added ChangeLog entry fro better messages on config from CB failure
2019-06-27 19:59:12 +02:00
Francis Dupont
637e9f03cc
[616-error-msgs-contain-references-to-config-file-while-config-backend-is-used] Addressed comment
2019-06-27 19:32:49 +02:00
Francis Dupont
94fd660ecb
[616-error-msgs-contain-references-to-config-file-while-config-backend-is-used] Split commit block to add CB indication in log/error messages
2019-06-27 19:32:49 +02:00
Francis Dupont
ca63c5a217
[616-error-msgs-contain-references-to-config-file-while-config-backend-is-used] Improved messages (but still not found the bug)
2019-06-27 19:32:49 +02:00
Francis Dupont
14f48f4970
[616-error-msgs-contain-references-to-config-file-while-config-backend-is-used] Removed unused DCTL_CCSESSION_STARTING
2019-06-27 19:29:15 +02:00
Vicky Risk
7688e47c4e
Update .gitlab/issue_templates/bug_report.md
2019-06-27 10:48:10 -04:00
Thomas Markwalder
71c223b239
[#691,!395] Updated ChangeLog
2019-06-27 07:52:05 -04:00
Thomas Markwalder
4a0b024bc6
[#691,!395] More review comments
...
src/hooks/dhcp/high_availability/ha_messages.mes
Removed HA_SERVICE_CONNECT_INVALID_SOCKET message
src/hooks/dhcp/high_availability/ha_service.cc
HAService::clientConnectHandler() - now just avoids registering
an invalid FD with no log and return(true)
src/lib/http/client.cc
Added commen in Connection::close()
src/lib/http/tests/server_client_unittests.cc
Removed invalid FD failure in test
2019-06-27 07:50:55 -04:00
Marcin Siodelski
a45c0acdc8
[#691,!395] Fixed a typo in the server_client_unittest.cc for HTTP.
2019-06-27 07:50:55 -04:00
Marcin Siodelski
88a60903a3
[#691,!395] Removed spurious dot from the test comment.
2019-06-27 07:50:55 -04:00
Marcin Siodelski
d0265b1d23
[#691,!395] Fixed a typo in the IfaceMgr header.
2019-06-27 07:50:55 -04:00
Marcin Siodelski
25da59f6c0
[#691,!395] Fixed a typo in the http client header.
2019-06-27 07:50:55 -04:00
Marcin Siodelski
d05ce7e648
[#691,!395] Removed debug leftovers from ha service.
2019-06-27 07:50:55 -04:00
Marcin Siodelski
2278a9ad85
[#691,!395] Updated copyright date in src/config/timeouts.h.
2019-06-27 07:50:55 -04:00
Thomas Markwalder
1d512fc605
[#691,!395] Review comments 4
...
src/lib/http/tests/server_client_unittests.cc
TEST_F(HttpClientTest, connectCloseCallbacks) - test now
verifies callback invocations
2019-06-27 07:50:54 -04:00
Thomas Markwalder
99ed96bcad
[#691,!395] Review comments 3
...
IfaceMgr and unit tests clean up.
2019-06-27 07:50:54 -04:00
Thomas Markwalder
cb11b477da
[#691,!395] Review comments 2
...
src/hooks/dhcp/high_availability/ha_messages.mes
HA_SERVICE_CONNECT_INVALID_SOCKET - new message
src/hooks/dhcp/high_availability/ha_service.cc
HAService::clientConnectHandler() - added negative fd logic
src/lib/http/client.cc
Connection::closeCallback() - new method that wraps invocation
of close callback in try-catch.
src/lib/http/http_messages.mes
HTTP_CONNECTION_CLOSE_CALLBACK_FAILED - new message
2019-06-27 07:50:54 -04:00
Thomas Markwalder
de3af2b8ec
[#691,!395] Addressed review comments 1
...
Added TIMEOUT_DEFAULT_HTTP_CLIENT_REQUEST
Removed virtual from callback declarations
Added commentary to http/client.h
2019-06-27 07:50:54 -04:00
Thomas Markwalder
dbd6a288db
Apply suggestion to ChangeLog
2019-06-27 07:50:54 -04:00
Thomas Markwalder
8c8d0cd6b3
[#691,!395] Added ChangeLog entry
2019-06-27 07:50:13 -04:00
Thomas Markwalder
22ac8440ea
[#691,!395] Added bad socket purge to IfaceMgr
...
src/lib/dhcp/iface_mgr.cc
IfaceMgr::purgeBadSockets() - new function to validate
external sockets and unregister any that are invalid.
IfaceMgr::receive4Indirect()
IfaceMgr::receive4Direct()
IfaceMgr::receive6Indirect()
IfaceMgr::receive6Direct() - added logic to all
purgeBadSockets() when select fails with EBADF
src/lib/dhcp/tests/iface_mgr_unittest.cc
TEST_F(IfaceMgrTest, purgeExternalSockets4)
TEST_F(IfaceMgrTest, purgeExternalSockets6) - new tests
to verify bad socket purging
src/lib/http/client.cc
Move close_callback_ reset back to Connection::close()
2019-06-27 07:49:11 -04:00
Thomas Markwalder
ff3d254d65
[#691,!395] HAService now registers HTTP client sockets with InterfaceMgr
...
src/hooks/dhcp/high_availability/ha_service.cc
HAService
clientConnectHandler() - new client connection connect callback
clientCloseHandler() - new client connection close callback
asyncSendLeaseUpdate()
asyncSendHeartbeat()
asyncDisableDHCPService()
asyncEnableDHCPService()
asyncSyncLeasesInternal() - added new call backs to
HttpClient::asyncSendRequest() invocation
src/lib/http/client.cc
Connection::resetState() - added reset of close callback
2019-06-27 07:49:10 -04:00
Thomas Markwalder
770aeae623
[#691,!395] Add Connection socket exposure and close_callback handler
...
Addes close_callback and exposes Connectin's TCP socket to it
and connect_callback.
src/lib/http/client.h b/src/lib/http/client.h
HttpClient:
Added second parameter, socket FD, to ConnectHandler
Added CloseHandler typedef
asyncSendRequest() - added close_callback parameter
src/lib/http/client.cc
Connection - added close_callback parameter to all
methods that accept connect_callback parameter
Added invocation of close_callback wherever the connection's
socket is closed.
src/lib/http/tests/server_client_unittests.cc
TEST_F(HttpClientTest, connectCloseCallbacks) - new test that
verifies connect and close callback operations
2019-06-27 07:49:10 -04:00
Michal Nowikowski
9240a766ba
hammer: fixed handling repos over https
2019-06-27 00:00:11 -04:00
Francis Dupont
0b258bb3b8
[621-pd-pool-fields-are-not-described-in-kea6-all-keys-current-json] Addressed comment
2019-06-26 15:05:47 +02:00
Francis Dupont
fe46afb551
[621-pd-pool-fields-are-not-described-in-kea6-all-keys-current-json] Added description of pd-pool current all keys example
2019-06-26 15:05:47 +02:00
Francis Dupont
9b5a5b37d4
[685-log-the-expected-subnet-id-as-well-as-the-actual-subnet-id-when-the-sanity-checker-identifies-a-problem] Added ChangeLog entry for sanity-checker logs
2019-06-26 14:53:21 +02:00
Francis Dupont
5367cd1196
[685-log-the-expected-subnet-id-as-well-as-the-actual-subnet-id-when-the-sanity-checker-identifies-a-problem] Improved SanityChecker logs
2019-06-26 14:51:04 +02:00
Francis Dupont
e5c3a8004a
[694-add-valid-lifetime-to-dhcp4_lease_alloc-and-dhcp6_lease_alloc-logging] Added ChangeLog entry for DHCP*_LEASE_ALLOC improvement
2019-06-26 12:17:03 +02:00
Francis Dupont
845d6e8366
[694-add-valid-lifetime-to-dhcp4_lease_alloc-and-dhcp6_lease_alloc-logging] Added the unit (seconds)
2019-06-26 06:09:37 -04:00
Francis Dupont
20cd73860b
[694-add-valid-lifetime-to-dhcp4_lease_alloc-and-dhcp6_lease_alloc-logging] Added lease valid lifetime to DHCP*_LEASE_ALLOC logs
2019-06-26 06:09:37 -04:00
Francis Dupont
e34d0e7048
[682-keactrl-unable-to-kill-kea-processes] Force localstatedir value
2019-06-25 15:00:32 +02:00
Francis Dupont
93d3a878a9
[682-keactrl-unable-to-kill-kea-processes] Added expansion of runstatdir when it includes localstatedir
2019-06-25 14:56:42 +02:00