by specifying -Qunused-arguments. Also, as a cleanup for better organization
I moved compiler specific settings to earlier part of configure.ac, where
this workaround was added.
This reverts commit daf81c8846bf0b4e4308068a019c96beb09c5199.
I believe the sense of the change is correct, but it has effects on
other OSes, so it's probably better to use clang specific workaround
(will commit it later).
Valgrind complains (probably rightfully so) that memory is leaking in death-tests. This has been reported upstream, but is not addressed yet, and may not be in the near future, if at all (one response was don't use EXPECT_DEATH).
So I added a checker function, *if* valgrind headers are available, that returns true if the tests are run under valgrind. Death tests are now ignored if so.
Note that we should be very careful about using this; and only use it for things we are sure valgrind can't help, since it is possible to do things differently when using valgrind, which kind of defeats its purpose
this works around a bit awkward installation setup where there's a link
from "python3" to "python3.x" but not from "python3-config" to the
corresponding "python3.x-config". That happens for recent versions of
Homebrew.
- moved b10-config_test.db from src/bin/stats/tests to
src/bin/stats/tests/testdata
- renamed its name to b10-config.db
- changed its format to multiline
These changes are due to the reviewer's comment.
Finally! This one was big.
With some minor updates to catch up to the changes after merge.
Conflicts:
src/bin/auth/auth_srv.cc
src/bin/auth/auth_srv.h
src/bin/auth/tests/auth_srv_unittest.cc
src/lib/datasrc/client_list.cc
src/lib/datasrc/tests/client_list_unittest.cc
When built from source it uses GTEST_HAS_PTHREAD.
See $GTEST_SOURCE/include/gtest/internal/gtest-port.h
which defines it for solaris, linux, hpux (which BIND 10 doesn't know yet).
In particular make it work with default --with-gtest-source which is "yes".
And also set the distcheck options the same (but not completely
tested due to #1910).
This is incomplete and not all tested.
Added --with-gtest-source=PATH for location of the googletest source.
Also tested old method (--with-gtest not source) with gtest 1.6.0.
