2
0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-30 13:37:55 +00:00

9621 Commits

Author SHA1 Message Date
Michal 'vorner' Vaner
a29df11575 [1577] Port the in-memory loop to database findNSEC3
The high-level logic of finding it is similar, so we take the loop from
the in-memory data source and adapt it to the database.
2012-04-12 14:11:25 +02:00
Jelte Jansen
56338ac70f [1789] more review comments
in xfrin
- add note about lack of thread-safety
- add note about from-source temporariness
- add test for case-insensitive class strings
- directly replace _memory_zones
2012-04-12 12:51:35 +02:00
JINMEI Tatuya
2d99288b34 [1579] more cleanups, mostly editorial ones.
- indentation
- spelling: 'other else' should be 'otherwise'
- constify
- avoid using an unnecessary temporary variable
2012-04-11 18:02:33 -07:00
JINMEI Tatuya
52ee8a2874 [1579] another editorial fix: spacing. 2012-04-11 17:27:53 -07:00
JINMEI Tatuya
33f9ea32c6 [1579] made some definitions of ZoneFinder private.
They are only used for FindDNSSECContext, which is part of ZoneFinder
and can refer to its private members.
2012-04-11 17:20:30 -07:00
JINMEI Tatuya
ed4c07d55c [1579] various style fixes.
- () for return
- indentation
- brace position
- and a few other small things
2012-04-11 17:15:42 -07:00
JINMEI Tatuya
283053c1a3 [master] fixed build failure with SunStudio.
(the intent of the change should be obvious from the diff.)
2012-04-11 16:37:18 -07:00
Jelte Jansen
f173bdf07e [master] fix linker problem in lib/cc unit test
move GTEST_LDADD to the end of the list, so that the source tree libs get linked instead of those installed in the same location as gtest
(reviewed on jabber by jinmei)
2012-04-11 23:33:15 +00:00
JINMEI Tatuya
7ce8291439 [1789] editorial nits: folded long lines, removed redundant spaces. 2012-04-11 15:48:07 -07:00
JINMEI Tatuya
5c9b7307a5 [master] added changelogs for a couple of piggy-backed fixes in #1791 2012-04-11 10:35:16 -07:00
Jeremy C. Reed
77b918b706 [trac1579] re-add removed character
I assume the previous change was an accident.
2012-04-11 12:28:35 -05:00
JINMEI Tatuya
0c0e8a5f4d [master] Merge branch 'trac1791' 2012-04-11 09:47:40 -07:00
haikuo zhang
4eeff0e79d [1579] adjust codes for the flag in the find function. Using a helper class to
deal with the flag.
2012-04-11 23:30:29 +08:00
Michal 'vorner' Vaner
a98fc15799 [1577] Reuse more code in findNSEC3
The internal function used to create normal RRs when looking them up is
reused for the ones from NSEC3 namespace as well.
2012-04-11 16:57:40 +02:00
Jelte Jansen
94077743ff [1789] address review comments
All in xfrin memory zones handlers;
- normalize zone name and class
- provide strong exception guarantee in _set_memory_zones
- fix comment in _set_db_file
- make _auth_config_update 'protected'

And in the tests:
- extracted memory zones update tests to own class
- added tests for bad data
- added tests for normalization
2012-04-11 16:31:45 +02:00
Michal 'vorner' Vaner
b407617f16 [1577] Test findNSEC3 throws on non-NSEC3 zone
Just confirming it throws in case there's no NSEC3PARAM to compute the
hash by.
2012-04-11 10:46:16 +02:00
Michal 'vorner' Vaner
76f364b152 [1577] First shot at the findNSEC3 implementation
This one is wrong in many ways. It assumes (without checking) it gets an
exact match, it does not check any wrong data, it expects given order of
results. But it passes the minimal test now, and can be used as a base
for improving the implementation.
2012-04-11 10:35:49 +02:00
JINMEI Tatuya
6d7a20689e [1781] unrelated cleanup: reorder header files per guideline and constify. 2012-04-10 18:29:03 -07:00
JINMEI Tatuya
d12134b3a9 [1791] fixed one remaining regression: 'separate_rrs' case was broken.
added a test for that case to confirm the regression and the fix.
also introduced some more cleanups: removed rdata_txt_ so we simplify the
code further, made isSameType static class function (it doesn't refer to
any class attributes), constified separate_rrs_.
2012-04-10 14:57:38 -07:00
JINMEI Tatuya
55cecba6f3 [1491] (editorial) removed white spaces in a blank line. 2012-04-10 11:02:50 -07:00
Michal 'vorner' Vaner
7ef140c77f [1577] Validate the findNSEC3 input
We check the name comes from inside the zone.
2012-04-10 15:58:33 +02:00
Jelte Jansen
7a0dc75cee [1789] keep list of 'sqlite3' type memory ds zones in xfrin 2012-04-10 14:51:56 +02:00
Jelte Jansen
61446fd400 [master] Merge branch 'trac1845' 2012-04-10 10:56:02 +02:00
JINMEI Tatuya
9ad569a0f5 [1792] added a simple lettuce for the "inmemory w/ SQLite3 backend" scenario.
right now it does a simple check for loading and query response from the loaded
zone.  this is intended to be used for the inmemory-from-xfrin scenarios.
2012-04-09 17:04:36 -07:00
JINMEI Tatuya
9b060a79e2 [1792] added support for "sqlite3" filetype of inmemory zone. 2012-04-09 16:35:57 -07:00
JINMEI Tatuya
501c5f296f [1792] added supplemental utility for tests using SQLite3 backend.
it creates a temporary SQLite3 DB file from a shared template with a specified
stream of zone data.  this will help reduce the number of pre-generated DB
files in the repository (which will be subject to upgrading the schema).
2012-04-09 16:34:16 -07:00
JINMEI Tatuya
99adadb049 [1791] comment update.
the revised comment didn't make sense in the generalized context of
test_client.  the updated comment clarifies that.
2012-04-09 16:30:42 -07:00
JINMEI Tatuya
e267a6928a [1791] moved <cstdlib> to test_client.cc now the latter calls system(). 2012-04-09 16:26:11 -07:00
JINMEI Tatuya
08d1332164 [1792] moved rwtest.sqlite3 under lib/testutils so that it can be shared.
it's going to be used in subsequent auth tests.
2012-04-09 15:55:30 -07:00
JINMEI Tatuya
7610a7bace [1791] updated the log description for mismatched TTLs.
it didn't seem correct to say "it's not allowed on the wire".  this
restriction is more about the definition of the RRset concept, rather than
what we'd see in the wire.  also added a reference to the relevant RFC (2181).
2012-04-09 13:27:23 -07:00
JINMEI Tatuya
0996aa92a1 [1791] more cleanup: remove variable 'rdata' and make it a member variable.
this way we can also avoid creating the same RDATA twice.  textual row
variables were renamed to *_txt_ for consistency.
2012-04-09 13:21:08 -07:00
JINMEI Tatuya
f1f0bc0044 [1791] fixed the bug in database iterator wrt RRs of mixed TTLs.
the previous version didn't always reset it to the smallest TTL; the new test
added in the previous commit uncovered it.  this version passed that test.
also made some cleanups in the code reducing temporary variables for better
readability.
2012-04-09 13:05:36 -07:00
JINMEI Tatuya
fb9b8cd9f1 [1791] added a database iterator test that would uncover an (unrelated) bug.
it checks the case for RRsets with the TTL of the first RR is later than that
of the second.  The original implementation has a bug in this case, but the
previous test was insufficient and fail to discover it.
2012-04-09 11:10:49 -07:00
Michal 'vorner' Vaner
16a1358aa2 [1577] Port a NSEC3 test from memory to database
One test is taken and ported to the database. It does compile partially
(the rest is commented out for now) and does not pass. Also, another
function moved to common file.
2012-04-09 16:46:03 +02:00
Michal 'vorner' Vaner
c02b9f4c1f [1577] Move TestNSEC3HashCreator to separate file
I want to reuse it in another test, so taking the help mock class out.
2012-04-09 15:21:33 +02:00
JINMEI Tatuya
aaf4fb3d70 [1792] unrelated cleanup: constify and fold a long line
just noticed them and the changes are small, so I did it here.
2012-04-05 21:34:01 -07:00
JINMEI Tatuya
2397c86b17 [1792] unrelated style fix per guideline. should be obvious from the diff. 2012-04-05 17:37:29 -07:00
JINMEI Tatuya
2fa92e2396 [1792] Merge branch 'trac1791' into trac1792 2012-04-05 17:27:47 -07:00
JINMEI Tatuya
9858d6dd9a [1791] missing regression fix: needed to adjust python datasrc tests.
this is a result of the "unrelated" bug fix at commit b446618.
I also clarified the magic number of expected RRsets in comments.
2012-04-05 17:26:15 -07:00
JINMEI Tatuya
654f0cbd18 [1792] Merge branch 'trac1791' into trac1792 2012-04-05 16:34:40 -07:00
JINMEI Tatuya
dcdd4e10f2 [1791] added a new file, which was just forgotten.
consider this as part of cf16578.
2012-04-05 16:33:46 -07:00
JINMEI Tatuya
68308bd95e [1792] Merge branch 'trac1791' into trac1792 2012-04-05 16:27:07 -07:00
JINMEI Tatuya
d5531c9856 [1791] added a couple of more tests.
- confirm separating iterator triggers an exception as expected.
- try to load a bit more realistic zone with some trivial checks.
2012-04-05 16:12:26 -07:00
JINMEI Tatuya
ea528f50fd [1791] complete inmemory loader from iterator w/ consideration for RRSIGs.
the iterator is now assumed to be created in the 'non separate' mode based
on the bug fix of the previous commit.
tests are updated with RRSIGs, and about how to create the iterator.
doxygen comments clarify this point too.
2012-04-05 15:54:16 -07:00
JINMEI Tatuya
b446618815 [1791] make sure DB iterator distinguishes 2 RRSIGs of different types covered.
this could be a separate bug fix, but this branch would be easier to implement
with this fix, so I chose to fix it here.
2012-04-05 14:46:55 -07:00
Jeremy C. Reed
4df912c903 [master] increase the BIND 10 version to today's date 2012-04-05 12:07:57 -05:00
Jeremy C. Reed
81300648c7 [master] ticket #1823 remove ASIO_DISABLE_KQUEUE hack
We had this for a behavior on NetBSD, the new ASIO (already in our
source tree) has workaround for it.

This is for ticket #1823.
2012-04-05 12:04:23 -05:00
Jelte Jansen
97389bad9b [1789] refactor remote_config handling
moving add_remote to initialization, and cleanup to shutdown code
update 'database file' in remote config callback handler
2012-04-05 15:02:29 +02:00
Jelte Jansen
8f3e82a987 [master] Merge branch 'trac1757' 2012-04-05 11:34:38 +02:00
Jelte Jansen
44d2850a0d [1845] also check new rollback behaviour
And add corresponding EXPECT statements on the 'running' transaction
2012-04-05 11:30:11 +02:00