JINMEI Tatuya
16b92d014e
[324] make sure the temporary DB file for zonemgr test is always cleaned up.
2012-04-03 14:30:38 -07:00
Mukund Sivaraman
365b5c443a
[1220] Add testcase which checks use of trailing slashes with indices
...
Trailing slashes are supposed to work. It should not result in an error
like this:
> config show Resolver/listen_on
Resolver/listen_on[0]/address "::1" string
Resolver/listen_on[0]/port 53 integer
> config show Resolver/listen_on/
Error: Resolver/listen_on/[0]/address not found
Bug #1220 was fixed as a part of bug #1649 (see commit
b31b7eff36397f30f00d7c31805bf7634395dfa8). We just add another testcase
for bug #1220 .
2012-04-03 19:11:26 +05:30
Jelte Jansen
fa6a9dbe36
[master] update changelog for merge of 1626
...
JSON parser improvements
2012-04-03 11:09:47 +02:00
Jelte Jansen
3b09268518
[master] Merge branch 'trac1626'
2012-04-03 10:39:58 +02:00
Michal 'vorner' Vaner
daf2b85fc2
Changelog for #1715
2012-04-03 10:10:48 +02:00
Michal 'vorner' Vaner
098da24ddd
Merge #1715
...
Crash of bindctl when the config unset command was invoked. The code of
the command was missing, probably never implemented and obviously never
tested.
2012-04-03 09:50:55 +02:00
JINMEI Tatuya
69e76e0edb
[1746] removed SQLite3Accessor::getRecordDiff, and adjusted the test as such.
...
it was intended to be a short term hack until we implement getDiffs(),
but apparently we forgot to complete the cleanup task. So this is just an
originally planned cleanup.
note that there was a bug in the test code. The change to diff_add_a_data
is not to hide a problem in the tested code, but it's a fix to the test's bug.
2012-04-02 23:41:55 -07:00
JINMEI Tatuya
9e77d650e3
[1820] use the ScopedSocket wrapper throughout the code for more safety.
2012-04-02 18:13:48 -07:00
JINMEI Tatuya
1eb1ca43bb
[1820] avoid using the removed DNSService interfaces.
...
also made other cleanups, making it the code more exception safe.
2012-04-02 18:05:27 -07:00
JINMEI Tatuya
a3f1538ebc
[1820] removed DNSService::addServer() as they were mostly unused.
...
Likewise, some of the constructors of DNSService were removed too.
the test code specific to the removed interfaces were also removed.
2012-04-02 18:01:18 -07:00
JINMEI Tatuya
297646b5cd
[master] indentation fix.
2012-04-02 15:28:43 -07:00
JINMEI Tatuya
cc73f7e20f
[1773] comment updates due to interface changes as part of fix.
2012-04-02 15:17:38 -07:00
JINMEI Tatuya
1c45a4e0bc
[1773new] [1773] initial fix for clang++/Lion build failure
2012-04-02 14:57:33 -07:00
JINMEI Tatuya
80c297d9ae
[1773] initial fix for clang++/Lion build failure
2012-04-02 14:35:11 -07:00
JINMEI Tatuya
7a74c2d58e
[master] Merge branch 'trac1535'
2012-04-02 13:38:28 -07:00
JINMEI Tatuya
bbe403303f
[1535] Merge branch 'trac1535' of ssh://git.bind10.isc.org/var/bind10/git/bind10 into trac1535
2012-04-02 13:31:10 -07:00
JINMEI Tatuya
698534e556
[324] use a much larger major version (1000) for "newschema" test DBs.
...
it will reduce the risk of getting conflict soon due to schema updates.
2012-04-02 11:17:54 -07:00
JINMEI Tatuya
947f08c755
[324new2] renamed major/minor version variables so they are more consistent.
2012-04-02 11:13:21 -07:00
JINMEI Tatuya
4df83ec7d1
[324] make sure initial SQLite3 DB creation is exception safe.
...
this is not really an issue of this task, and I believe we should soon stop
creating the schema in the accessor context in the first place, but the bug
is real so I fixed it anyway. Assuming this creation code and the older
version of implementation will be gone soon, I simply duplicated the mostly
same code in both old and new implementations.
Also, it seemed extremely difficult (I'd say it's effectively impossible) to
test these cases. I couldn't come up with any reasonable way to test them,
so I didn't add any test.
2012-04-02 11:07:50 -07:00
Jelte Jansen
9ee14145b2
[1626] move some more json tests around
2012-04-02 15:36:04 +02:00
Jelte Jansen
6e57b76919
[1626] use one list of 'whitespace' chars
...
and even more tests
Moved a couple of 'basic' tests out of 'escape' and to 'to_and_from_string' test
2012-04-02 15:16:27 +02:00
Mukund Sivaraman
a29f99f27d
[1626] Add more testcases
2012-04-02 17:23:09 +05:30
Jelte Jansen
7733a51887
[master] update changelog for merge of #1535
2012-04-02 12:47:21 +02:00
Jelte Jansen
66300a3c47
[master] Merge branch 'trac1535'
2012-04-02 11:45:16 +02:00
Jelte Jansen
952cb2ceeb
[1535] use OutOfZone instead of InvalidParameter in findNSEC3()
2012-04-02 11:44:42 +02:00
Jelte Jansen
318ecd4e65
[1626] check string termination and whitespace fix
...
whitespace 'outside' of elements is skipped, now including \r and \b
2012-04-02 10:50:26 +02:00
Mukund Sivaraman
9a56eb7ebb
[1626] Add some more testcases
2012-04-02 12:21:07 +05:30
JINMEI Tatuya
ead53d5c0f
[master] trivial editorial cleanup: removed spaces in a blank line.
2012-03-30 17:03:31 -07:00
JINMEI Tatuya
c31cfdf844
[1579] editorial cleanups: shortened long lines, indentation consistency.
2012-03-30 16:43:01 -07:00
JINMEI Tatuya
cd6faa250e
[1579] folded a long line
2012-03-30 15:21:41 -07:00
JINMEI Tatuya
5893305969
[1579] more suggested editorial fixes: use boolean as boolean
2012-03-30 15:18:53 -07:00
JINMEI Tatuya
4196650265
[1579] some more suggested editorial fixes:
...
- use boolean as boolean: if (is_xx == true) => if (is_xx)
- spacing consistency if (X){ => if (X) { // (many of this in the branch)
- folded a long line
2012-03-30 15:12:58 -07:00
JINMEI Tatuya
ad0ce258df
[1579] editorial cleanup, mostly per the guidelines.
...
- folded long lines
- removed white space at EOL
- spacing consistency. in particular, add one space after comma
- alignment
2012-03-30 15:01:35 -07:00
JINMEI Tatuya
fa4aa9c87c
[1579] cancel unnecessary change (this will help reduce conflict on merge)
2012-03-30 14:36:22 -07:00
JINMEI Tatuya
70515e4857
[1535] (editorial) combined two shorter lines into one.
2012-03-30 11:14:06 -07:00
Jelte Jansen
65b293e599
[1535] renamed OutOfZoneFind to OutOfZone
...
And remove the memory-datasrc specific one
2012-03-30 17:45:45 +02:00
Jelte Jansen
532aa507e5
[1535] address review comments
...
- removed superfluous toText() calls in out-of-zone exception creation
- moved in-memory out-of-zone check to be part of findNode instead of separate check in find()
- added out-of-zone check to addAdditional lookup (and don't lookup unless in zone)
- removed FIND_DEFAULT parameters in unit tests (they are default values)
- change notify_out sqlite test data to have out-of-zone-but-known NS target
2012-03-30 16:54:01 +02:00
haikuo zhang
94793e41d9
[1579] If nsec and nsec3 coexist in zone, find function and findAll
...
function will throw error. find and findAll function will set
RESULT_NSEC3_SIGNED if the zone is signed with NSEC3.
2012-03-30 19:52:51 +08:00
Mukund Sivaraman
c1a0b11d84
[master] Move cppcheck suppressions to the source files (inline)
...
This fixes a cppcheck regression introduced in commit
48cfa00bb988cfeebab4e6ac7ae440cd685137e5 (I think), which caused line
numbers to change.
2012-03-30 16:17:55 +05:30
Jelte Jansen
737c4eb744
[1626] fix non-printable escaping in json conv
2012-03-30 11:14:57 +02:00
Mukund Sivaraman
1a4d0ae65b
[1627] Add comment about use of try-catch blocks
2012-03-30 14:43:30 +05:30
Mukund Sivaraman
f95e202d7e
[1627] Add a couple more testcases
...
* Case when no file is specified
* Case where both origin and file are not specified
2012-03-30 14:43:30 +05:30
Mukund Sivaraman
6ac392ce79
[master] Fix testcase name
2012-03-30 14:43:30 +05:30
Mukund Sivaraman
376c01fc1b
[1627] Fix type of exception thrown in testcase
...
NameParserExceptions are now caught and AuthConfigError is thrown.
2012-03-30 14:43:30 +05:30
Mukund Sivaraman
9d192aa44e
[1627] Rewrite code to use local variables
2012-03-30 14:43:29 +05:30
JINMEI Tatuya
88a80126ce
[1627] (editorial) folded long lines
2012-03-30 14:43:29 +05:30
JINMEI Tatuya
77eddb37c5
[1627] (editorial) folded long lines
2012-03-30 14:43:29 +05:30
Mukund Sivaraman
252fc353ba
[1627] Add the namestring that triggers the exception to the message
...
This is so that users see what name caused problems in the log.
2012-03-30 14:43:29 +05:30
Mukund Sivaraman
1a46994e85
[1627] Unify testcases for NameParserException checks
2012-03-30 14:43:29 +05:30
Mukund Sivaraman
c80eae98a8
[1627] Check for empty origin and file in config, and throw with more relevant error msg
2012-03-30 14:43:29 +05:30