- C0115: Missing class docstring (missing-class-docstring)
- C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck)
- C0201: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
- C0206: Consider iterating with .items() (consider-using-dict-items)
- C0411: standard import "..." should be placed before "..." (wrong-import-order)
- C0415: Import outside toplevel (...) (import-outside-toplevel)
- C1802: Do not use `len(SEQUENCE)` without comparison to determine if a sequence is empty (use-implicit-booleaness-not-len)
- E0001: Parsing failed: 'invalid syntax (<unknown>, line 2313)' (syntax-error)
- E0401: Unable to import '...' (import-error)
- E0602: Undefined variable 'l' (undefined-variable)
- R0205: Class 'VagrantEnv' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)
- E1101: Instance of 'NSECBASE' has no 'dump_fixedpart' member (no-member)
- E1123: Unexpected keyword argument 'capture' in method call (unexpected-keyword-arg)
- R0902: Too many instance attributes (too-many-instance-attributes)
- R0913: Too many arguments (too-many-arguments)
- R0916: Too many boolean expressions in if statement (6/5) (too-many-boolean-expressions)
- R1717: Consider using a dictionary comprehension (consider-using-dict-comprehension)
- R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
- R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
- R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal)
- W0102: Dangerous default value sys.argv[1:] (builtins.list) as argument (dangerous-default-value)
- W0102: Dangerous default value {} as argument (dangerous-default-value)
- W0106: Expression "[f.write('%02x' % x) for x in bin_address]" is assigned to nothing (expression-not-assigned)
- W0107: Unnecessary pass statement (unnecessary-pass)
- W0201: Attribute 'config' defined outside __init__ (attribute-defined-outside-init)
- W0404: Reimport '...' (imported line ...) (reimported)
- W0611: Unused import ... (unused-import)
- W0612: Unused variable '...' (unused-variable)
- W0613: Unused argument '...' (unused-argument)
- W0621: Redefining name '...' from outer scope (line 1471) (redefined-outer-name)
- W0622: Redefining built-in '...' (redefined-builtin)
- W0707: Consider explicitly re-raising using 'raise ... from ...' (raise-missing-from)
- W0718: Catching too general exception Exception (broad-exception-caught)
- W1202: Use lazy % formatting in logging functions (logging-format-interpolation)
- W1203: Use lazy % formatting in logging functions (logging-fstring-interpolation)
- W1308: Duplicate string formatting argument 'connection_type', consider passing as named argument (duplicate-string-formatting-argument)
- W1401: Anomalous backslash in string: '\/'. String constant might be missing an r prefix. (anomalous-backslash-in-string)
- W1406: The u prefix for strings is no longer necessary in Python >=3.0 (redundant-u-string-prefix)
- W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
- W4901: Deprecated module 'optparse' (deprecated-module)
- W4904: Using deprecated class SafeConfigParser of module configparser (deprecated-class)
- E111 indentation is not a multiple of 4
- E117 over-indented
- E125 continuation line with same indent as next logical line
- E127 continuation line over-indented for visual indent
- E128 continuation line under-indented for visual indent
- E129 visually indented line with same indent as next logical line
- E131 continuation line unaligned for hanging indent
- E201 whitespace after '['
- E201 whitespace after '{'
- E202 whitespace before ')'
- E202 whitespace before ']'
- E202 whitespace before '}'
- E203 whitespace before '
- E203 whitespace before ','
- E222 multiple spaces after operator
- E225 missing whitespace around operator
- E228 missing whitespace around modulo operator
- E231 missing whitespace after ','
- E251 unexpected spaces around keyword / parameter equals
- E261 at least two spaces before inline comment
- E262 inline comment should start with '# '
- E265 block comment should start with '# '
- E301 expected 1 blank line, found 0
- E302 expected 2 blank lines, found 1
- E303 too many blank lines (2)
- E305 expected 2 blank lines after class or function definition, found 1
- E306 expected 1 blank line before a nested definition, found 0
- E401 multiple imports on one line
- E402 module level import not at top of file
- E501 line too long
- E502 the backslash is redundant between brackets
- E703 statement ends with a semicolon
- E713 test for membership should be 'not in'
- E722 do not use bare 'except'
- E741 ambiguous variable name 'l'
- W605 invalid escape sequence '\/'
Statistics and raw data return durations in microseconds instead
of milliseconds. Add initial support for perfmon-get-all-durations.
/doc/sphinx/arm/hooks-perfmon.rst
Updated to microseconds
Updated perfmon-control command
/src/hooks/dhcp/perfmon/monitored_duration.*
DurationKey::toElement()
MonitoredDuration::toElement() - new functions
/src/hooks/dhcp/perfmon/perfmon_callouts.cc
int perfmon_control()
int perfmon_get_all_durations() - new functions
int load() - register commands
/src/hooks/dhcp/perfmon/perfmon_config.cc
PerfMonConfig::parse() - replace use of copy ctor
PerfMonConfig::enable_monitoring_
PerfMonConfig::stats_mgr_reporting_ - made std::atomic
/src/hooks/dhcp/perfmon/perfmon_messages.mes
PERFMON_CMDS_CONTROL_ERROR
PERFMON_CMDS_CONTROL_OK
PERFMON_CMDS_GET_ALL_DURATIONS_ERROR
PERFMON_CMDS_GET_ALL_DURATIONS_OK - new messages
/src/hooks/dhcp/perfmon/perfmon_mgr.cc
PerfMonMgr::perfmonControlHandler()
PerfMonMgr::perfmonGetAllDurationsHandler()
PerfMonMgr::formatDurationDataAsElements()
PerfMonMgr::formatDurationDataAsResultSet() - new functions
/src/hooks/dhcp/perfmon/tests/Makefile.am
Added perfmon_cmds_unittests.cc
/src/hooks/dhcp/perfmon/tests/perfmon_config_unittests.cc
Replaced use of copy ctor
/src/hooks/dhcp/perfmon/tests/perfmon_mgr_unittests.cc
Updated tests for microseconds
Tests were subject to wide variations in retry intervals
on certain VMs. Reworked stop when done but allow for
longer overal timeout
src/lib/dhcp/testutils/pkt_filter_test_stub.cc
PktFilterTestStub::openSocket() - close fd on simulated open error
src/lib/dhcpsrv/tests/cfg_iface_unittest.cc
CfgIfaceTest::stopWait() - added func to stop io_service_
CfgIfaceTest::TearDown() - close sockets before clearing ifaces
TEST_F(CfgIfaceTest, retryOpenServiceSockets4)
TEST_F(CfgIfaceTest, retryOpenServiceSockets4OmitBound)
TEST_F(CfgIfaceTest, retryOpenServiceSockets6)
TEST_F(CfgIfaceTest, retryOpenServiceSockets6OmitBound) - modified
to use stopWait(), longer timeout, shorter wait
