2
0
mirror of https://gitlab.isc.org/isc-projects/kea synced 2025-08-31 14:05:33 +00:00
Commit Graph

29574 Commits

Author SHA1 Message Date
Thomas Markwalder
1f1a9ecfca [#805,!6-p] Addressed review comments
src/lib/dhcpsrv/csv_lease_file4.*
src/lib/dhcpsrv/tests/csv_lease_file4_unittest.cc
    - minor cleanup

src/lib/dhcpsrv/csv_lease_file6.*
    CSVLeaseFile6::append() - now throws if DUID is empty and
    state is not STATE_DECLINED

src/lib/dhcpsrv/tests/csv_lease_file6_unittest.cc
    Updated tests to verify duid/state logic
2019-08-16 18:33:11 -04:00
Thomas Markwalder
67f3a9515b [#805,!6-p] CSVLeaseFile4 ensures either hwaddr or client id for non-declined leases
Declined leases are expected to have neither hardware address nor client
id.  All others have must have at least one of them.

src/lib/dhcpsrv/csv_lease_file4.cc
    CSVLeaseFile4::append() - throws if a lease has no hardware address,
    no client id and is not in STATE_DECLINED

    CSVLeaseFile4::next(Lease4Ptr& lease) - discards rows if they have
    neither hardware addr nor client id and are not in STATE_DECLINED

src/lib/dhcpsrv/tests/csv_lease_file4_unittest.cc
src/lib/dhcpsrv/tests/generic_lease_mgr_unittest.cc
src/lib/dhcpsrv/tests/lease_file_loader_unittest.cc
src/bin/lfc/tests/lfc_controller_unittests.cc
    Updated tests.
2019-08-16 18:33:11 -04:00
Razvan Becheriu
f551f62e49 [#805, !6-p] check for null or empty hwaddr before writing to memfile (v4) 2019-08-16 18:30:22 -04:00
Thomas Markwalder
c4a888a537 [#805,!5-p] Updated ChangeLog and conflicted parsers 2019-08-16 18:03:29 -04:00
Thomas Markwalder
af7393c517 [#805,!5-p] Addressed more review comments
More cleanup following 1.4 and 1.5 branch reviews

doc/sphinx/arm/dhcp6-srv.rst
src/lib/dhcpsrv/memfile_lease_mgr.cc
2019-08-16 17:57:21 -04:00
Thomas Markwalder
923bbdcf7f [#805,!5-p] Updated ChangeLog to security, added CVE # 2019-08-16 17:57:21 -04:00
Thomas Markwalder
5717789188 [#805,!5-p] Addressed review comments
Minor cleanup and commentary.
2019-08-16 17:56:27 -04:00
Thomas Markwalder
3d097f24cc [#805,!5-p] Updated the ARM
Updated the ARM and added a ChangeLog entry.
2019-08-16 17:56:27 -04:00
Thomas Markwalder
13e1bb4398 [#805,!5-p] Updated example confs 2019-08-16 17:54:31 -04:00
Thomas Markwalder
36e9ff55d2 [#805,!5-p] kea-dhcp6 now supports max-row-errors parameter
src/bin/dhcp6/dhcp6_lexer.ll
src/bin/dhcp6/dhcp6_parser.yy
    Added max-row-errors

src/lib/dhcpsrv/tests/lease_file_loader_unittest.cc
    TEST_F(LeaseFileLoaderTest, maxRowErrors6) - new unit test
    to verify max-row-errors operation
2019-08-16 17:54:11 -04:00
Thomas Markwalder
877ca52411 [#805,!5-p] Memfile and kea-dhcp4 now suppor max-row-errors parameter
src/bin/dhcp4/dhcp4_lexer.ll
src/bin/dhcp4/dhcp4_parser.yy
    Added max-row-errors

src/lib/database/database_connection.*
src/lib/database/dbaccess_parser.*
    Added max-row-errors

src/lib/database/tests/dbaccess_parser_unittest.cc
    New tests for max-row-errors

src/lib/dhcpsrv/lease_file_loader.h
    Changed logic value of 0 means unlimited

src/lib/dhcpsrv/memfile_lease_mgr.cc
    Memfile_LeaseMgr::loadLeasesFromFiles() - now uses
    connection parmater value for max-row-errors or 0
    if not specified

src/lib/dhcpsrv/tests/lease_file_loader_unittest.cc
    TEST_F(LeaseFileLoaderTest, maxRowErrors4) - new unit test
    to verify max-row-errors operation

src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
   TEST_F(MemfileLeaseMgrTest, constructor) - added tests for
   max-row-errors
2019-08-16 17:53:40 -04:00
Thomas Markwalder
e961af14f9 [#805,!5-p] Updated example confs 2019-08-16 17:51:25 -04:00
Thomas Markwalder
5caea854fd [#805,!5-p] kea-dhcp6 now supports max-row-errors parameter
src/bin/dhcp6/dhcp6_lexer.ll
src/bin/dhcp6/dhcp6_parser.yy
    Added max-row-errors

src/lib/dhcpsrv/tests/lease_file_loader_unittest.cc
    TEST_F(LeaseFileLoaderTest, maxRowErrors6) - new unit test
    to verify max-row-errors operation
2019-08-16 17:51:01 -04:00
Thomas Markwalder
331888d203 [#805,!5-p] Memfile and kea-dhcp4 now suppor max-row-errors parameter
src/bin/dhcp4/dhcp4_lexer.ll
src/bin/dhcp4/dhcp4_parser.yy
    Added max-row-errors

src/lib/database/database_connection.*
src/lib/database/dbaccess_parser.*
    Added max-row-errors

src/lib/database/tests/dbaccess_parser_unittest.cc
    New tests for max-row-errors

src/lib/dhcpsrv/lease_file_loader.h
    Changed logic value of 0 means unlimited

src/lib/dhcpsrv/memfile_lease_mgr.cc
    Memfile_LeaseMgr::loadLeasesFromFiles() - now uses
    connection parmater value for max-row-errors or 0
    if not specified

src/lib/dhcpsrv/tests/lease_file_loader_unittest.cc
    TEST_F(LeaseFileLoaderTest, maxRowErrors4) - new unit test
    to verify max-row-errors operation

src/lib/dhcpsrv/tests/memfile_lease_mgr_unittest.cc
   TEST_F(MemfileLeaseMgrTest, constructor) - added tests for
   max-row-errors
2019-08-16 17:49:49 -04:00
Thomas Markwalder
1878553ab4 [#730,!2-p] Addressed review comments
Minor cleanup

ChangeLog
src/bin/dhcp4/dhcp4_messages.mes
src/bin/dhcp4/dhcp4_srv.cc
src/lib/dns/tests/name_unittest.cc
2019-08-16 16:52:25 -04:00
Thomas Markwalder
d1395c7a9a [#730,!2-p] Updated ChangeLog entry 2019-08-16 16:47:11 -04:00
Thomas Markwalder
0aa183b55c [#730,!2-p] Minor edit in ChangeLog entry 2019-08-16 16:45:12 -04:00
Thomas Markwalder
5e8600f0ae [#730,!2] Reworded ChangeLog entry 2019-08-16 16:45:12 -04:00
Thomas Markwalder
cbe4de7511 [#730,!2] Addressed review comment
src/lib/exceptions/isc_assert.h - clarified commentary
2019-08-16 16:45:12 -04:00
Thomas Markwalder
27fbe6f4bd [#730,!2] Addressed review comments
ChangeLog - added an entry

src/bin/dhcp4/tests/fqdn_unittest.cc
    TEST_F(NameDhcpv4SrvTest, serverUpdateMalformedHostname) - added
    commentary

src/lib/exceptions/isc_assert.h
    commentary changes

src/lib/exceptions/tests/exceptions_unittest.cc
    TEST(IscThrowAssert, checkMessage) - replace use of explicit line number
2019-08-16 16:45:12 -04:00
Thomas Markwalder
9260b6d915 [#730,!2] Corrected assertion failure on malformed hostname from kea-dhcp4
src/lib/exceptions/isc_assert.h
    New file that defines isc_assert_throw()

src/lib/exceptions/Makefile.am
    added isc_asssert.h

src/lib/exceptions/tests/exceptions_unittest.cc
    TEST(IscThrowAssert, checkMessage) - new test

src/lib/dns/labelsequence.cc
src/lib/dns/name.cc
    Replaced assert() calls with isc_throw_assert() calls

src/lib/dns/tests/name_unittest.cc
    TEST_F(NameTest, unexpectedParseError) - new unit test
    for hostname option content based on fuzz test failure

src/lib/dhcp_ddns/ncr_msg.cc
    Removed unnecessary include of dns/name.h

src/bin/dhcp4/dhcp4_srv.cc
    Dhcpv4Srv::processHostnameOption() - added try catch
    around OptionDataTypeUtil::getLabelCount() call

src/bin/dhcp4/dhcp4_messages.*
    added new log message DHCP4_CLIENT_HOSTNAME_MALFORMED

src/bin/dhcp4/tests/fqdn_unittest.cc
    TEST_F(NameDhcpv4SrvTest, serverUpdateMalformedHostname) -
    renamed test and augmented it to include the packet of death
    produced by fuzz testing.
2019-08-16 16:43:10 -04:00
Thomas Markwalder
7fe5b82ae5 [#722,!1-p] Updated ChangeLog 2019-08-16 16:13:22 -04:00
Thomas Markwalder
bb1a64b894 [#722,!1] Addressed review comments
revamped Dhpc6srv::sanityCheckDuid() per review comments on
   1.4.0 version.
2019-08-16 16:12:00 -04:00
Thomas Markwalder
9812d23276 [#722,!2] Added ChangeLog Entry 2019-08-16 16:11:22 -04:00
Thomas Markwalder
b082880ca6 [#722,!1] Addressed review comments
Added test to ensure DUID size constant(s) are RFC compliant
2019-08-16 16:08:12 -04:00
Thomas Markwalder
afa16f63ea [#722,!1] Addressed review comments
src/lib/dhcp/duid.cc - improved log message
2019-08-16 16:08:12 -04:00
Thomas Markwalder
20b6386b52 [#722] kea-dhcp6 sanity checking of inbound DUID options improved
src/bin/dhcp6/dhcp6_srv.cc
    Dhcpv6Srv::sanityCheckDUID() - modified to attempt to construct
    a DUID instance as final sanity check

src/bin/dhcp6/tests/dhcp6_srv_unittest.cc
    TEST_F(Dhcpv6SrvTest, sanityCheckClientId)
    TEST_F(Dhcpv6SrvTest, sanityCheckServerId) - revamped tests
    to check against max and max + 1

src/bin/dhcp6/tests/dhcp6_test_utils.h
    A little refactoring to ease option creation

src/lib/dhcp/duid.cc
    DUID::DUID(const std::vector<uint8_t>& duid)
    DUID::DUID(const uint8_t* data, size_t len) - updated
    error log to show actual sizes
2019-08-16 16:08:12 -04:00
Marcin Siodelski
cae7b2c906 [#841,!490] Added ChangeLog for #841. 2019-08-16 21:41:40 +02:00
Marcin Siodelski
55e902e1d6 [#841,!490] Corrected library version number for dhcp_ddns. 2019-08-16 15:39:13 -04:00
Marcin Siodelski
38217c2250 [#841,!490] Corrected libdhcpsrv library version number. 2019-08-16 15:39:13 -04:00
Marcin Siodelski
bfe96c36c9 [#841,!490] Bumped up libraries version numbers. 2019-08-16 15:39:13 -04:00
Tomek Mrugalski
2e88e25549 [#810,!471] AUTHORS, ChangeLog updated 2019-08-16 20:01:09 +02:00
Tomek Mrugalski
f1ae84186b [#810,!471] Changed title levels in hooks-*.rst files
- mostly --- to ~~~
2019-08-16 19:58:41 +02:00
Tomek Mrugalski
e90577743e [#810,!471] Compilation fixes in the API files 2019-08-16 19:11:03 +02:00
Suzanne Goldlust
ab2517b72c Edited header underlines to try to get all the hooks libraries at the same TOC level in the docs 2019-08-16 19:11:03 +02:00
Suzanne Goldlust
6b749afadd Fix JSON errors 2019-08-16 19:11:03 +02:00
Suzanne Goldlust
2891e28344 A few more text/formatting edits 2019-08-16 19:11:03 +02:00
Suzanne Goldlust
cb4a21545f Fix grammar, typos, a few JSON errors 2019-08-16 19:11:03 +02:00
Razvan Becheriu
581948124b [#810, !471] reverted changes added by mistake 2019-08-16 19:11:03 +02:00
Razvan Becheriu
fceb85995e [#810, !471] fixed sphinx docs 2019-08-16 19:11:03 +02:00
Razvan Becheriu
32d3953704 [#810, !471] fixed sphinx docs 2019-08-16 19:11:03 +02:00
Razvan Becheriu
71ec70431f [#810, !471] fixed sphinx docs 2019-08-16 19:11:03 +02:00
Suzanne Goldlust
295f81cb1f Fix JSON syntax errors, miscellaneous typos and grammatical errors in API docs 2019-08-16 19:11:03 +02:00
Razvan Becheriu
8ffc32fbb2 [#810, !471] fixed sphinx docs 2019-08-16 19:11:03 +02:00
Tomek Mrugalski
2703677d8a [#659,!387] ChangeLog updated. 2019-08-16 18:34:13 +02:00
Marcin Siodelski
1f2cae397b [#659,!387] Addressed two review comments.
- Return after finding the first pool.
- Corrected excluded prefix length stored in the db.
2019-08-16 17:47:34 +02:00
Marcin Siodelski
a4de989fdb [#659,!387] Update doc: excluded prefix is support for CB. 2019-08-16 17:47:34 +02:00
Marcin Siodelski
818100a6cc [#659,!387] Changed "fields" to "columns" in the MySQL creation script.
As a result of review.
2019-08-16 17:47:34 +02:00
Francis Dupont
ca939b3c01 [659-how-configure-client-class-for-pools-in-db] Reported dhcp[46] guide updates 2019-08-16 17:47:34 +02:00
Francis Dupont
32bcae557c [659-how-configure-client-class-for-pools-in-db] Addressed not doc comments 2019-08-16 17:47:34 +02:00