Jelte Jansen
bdebd1afa4
[1183] remove some unused code and fix a test
2011-08-18 16:43:36 +02:00
Jelte Jansen
59add6ec0f
[1183] now it's been unified, we can make compiler enforce array size
...
that makes a number of tests unnecessary (as well as impossible)
2011-08-18 15:34:50 +02:00
Jelte Jansen
1b421982a6
[1183] getAllRecords already takes zone_id, does not need name
2011-08-18 15:01:51 +02:00
Jelte Jansen
d88becea33
[1183] remove searchForRecords(), getNextRecord() and resetSearch()
...
since they can now be done through getRecords()
2011-08-18 12:19:56 +02:00
Jelte Jansen
171088e69f
[1183] add initial use of iterator context for getRecords()
...
(to replace searchForRecords->getNextRecord combo)
2011-08-18 12:01:50 +02:00
Jelte Jansen
9a8667331d
[master] cppcheck fix (uninitialized member var)
2011-08-18 10:29:31 +02:00
Michal 'vorner' Vaner
fb7c63f65c
Merge branch #1067
...
Conflicts:
src/lib/datasrc/database.h
2011-08-17 19:42:46 +02:00
Michal 'vorner' Vaner
fe8f331430
[1067] "FIX" different TTL instead of throwing
...
When we iterate and find out that there are RRs in an RRset with
different TTL, we go for the lowest of them instead of throwing and give
a warning.
2011-08-17 15:45:40 +02:00
Michal 'vorner' Vaner
006d0fab3f
Merge branch #1074
...
Conflicts:
src/lib/datasrc/database.cc
src/lib/datasrc/tests/database_unittest.cc
2011-08-16 16:24:30 +02:00
Michal 'vorner' Vaner
68da925f22
Merge branch #1063
2011-08-16 16:08:27 +02:00
Michal 'vorner' Vaner
b3bcd825cf
[1063] Few more tests
2011-08-16 13:17:29 +02:00
Michal 'vorner' Vaner
3f5a0900a5
[1063] Split long test
2011-08-16 13:11:46 +02:00
Michal 'vorner' Vaner
c454dfae89
[1067] Unify the interface
2011-08-16 11:56:07 +02:00
Michal 'vorner' Vaner
afde75c1fe
[1067] Add another column
...
So we can unify the interface
2011-08-16 11:13:30 +02:00
Michal 'vorner' Vaner
fb441884ba
[1067] Rename getIteratorContext to getAllRecords
...
This will be better for consistency, when we change the searchForRecords
to return an iterator object, it will be called getRecords.
2011-08-15 16:54:30 +02:00
Michal 'vorner' Vaner
ee552335b8
Merge branch 'master' into #1067
...
To bring in changes and make the interface more consistent easier.
Conflicts:
src/lib/datasrc/database.cc
src/lib/datasrc/database.h
src/lib/datasrc/sqlite3_accessor.cc
src/lib/datasrc/sqlite3_accessor.h
src/lib/datasrc/tests/database_unittest.cc
src/lib/datasrc/tests/sqlite3_accessor_unittest.cc
2011-08-15 16:45:26 +02:00
Michal 'vorner' Vaner
978ae99ac4
[1064] Tests for GLUE_OK mode
...
It should just go trough NS delegation points (but not trough DNAME
ones).
2011-08-13 14:54:29 +02:00
Michal 'vorner' Vaner
e021b84f7f
[1063] Check signatures
...
They work out of the box thanks to the getRRset method, but it needs to
be tested explicitly. The tests test only the NS and DNAME, the rest is
tested above.
2011-08-12 15:23:04 +02:00
Michal 'vorner' Vaner
005c77dfe5
[1063] Few more delegation corner-cases tested
2011-08-12 14:55:58 +02:00
Michal 'vorner' Vaner
ce3bc8504d
[1063] Ignore NS at origin
...
It was written, but the zone didn't know it's own origin. This is now
fixed and tested.
2011-08-12 14:35:33 +02:00
Michal 'vorner' Vaner
c5cf3cc081
[1063] Implement the delegations
2011-08-12 13:44:46 +02:00
Jelte Jansen
779e145d8f
[master] fix solaris issue
...
This patch from yesterday either disappear or never made it, anyway, recommiting jinmei's code (reviewed on jabber by, er, me)
2011-08-12 12:40:04 +02:00
Michal 'vorner' Vaner
80014655d7
[1063] Tests for delegations
...
Both NS and DNAME
2011-08-12 11:45:05 +02:00
Jelte Jansen
959dc16381
[1062] log database name in other log messages too
2011-08-12 11:00:12 +02:00
Jelte Jansen
1d74428fb7
[1062] Merge branch 'master' into trac1062
...
And update the added code to conform to the new API names
Conflicts:
src/lib/datasrc/tests/sqlite3_accessor_unittest.cc
2011-08-12 10:29:44 +02:00
Jelte Jansen
8ce8e05a40
[1062] more review updates (comment:14)
2011-08-11 22:52:21 +02:00
JINMEI Tatuya
774a56a8be
[1062] editorial/documentation proposed updates
2011-08-11 12:14:55 -07:00
Michal 'vorner' Vaner
89bd1bf64a
Merge branch 'master' into work/iterator
...
Conflicts:
src/lib/datasrc/sqlite3_accessor.h
src/lib/datasrc/tests/Makefile.am
src/lib/datasrc/tests/database_unittest.cc
2011-08-11 20:09:20 +02:00
Michal 'vorner' Vaner
f429202995
[1061] Unify the interface with #1062
...
The interface of #1062 is trough array of strings, so we do it too to be
a little bit closer to it. We don't pass the count of columns, but say
there should be 4 in the interface (passing array of wrong size is as
easy as passing array of wrong size and providing the correct size).
2011-08-11 19:27:35 +02:00
Jelte Jansen
ac15a86eb6
[1062] rest of the review comments
2011-08-11 17:31:06 +02:00
Michal 'vorner' Vaner
d00042b03e
[1061] Rename missing names
...
Some "Conn" variables were left out and forgotten in previous renames,
fixing what could be found.
2011-08-11 16:18:43 +02:00
Jelte Jansen
b19a36e30d
[1062] added getDBName to DatabaseConnection
...
and add database name to logging output
2011-08-11 13:09:12 +02:00
JINMEI Tatuya
cfd1d9e142
[1062] some minor editorial changes, mostly just folding long lines.
2011-08-11 02:07:39 -07:00
Jelte Jansen
f82dc7b09f
[1062] addressed review comments
2011-08-10 12:05:06 +02:00
Michal 'vorner' Vaner
65e4595c21
[1061] Yet another renaming
...
This time to DatabaseAccessor, Abstraction might be misleading in other
ways.
2011-08-09 09:02:03 +02:00
Michal 'vorner' Vaner
d4867b8dd1
Merge remote-tracking branch 'origin/trac1061' into HEAD
...
Conflicts:
src/lib/datasrc/sqlite3_database.h
src/lib/datasrc/tests/Makefile.am
src/lib/datasrc/tests/database_unittest.cc
src/lib/datasrc/tests/sqlite3_database_unittest.cc
To bring in renaming of DatabaseConnection and few other small changes.
2011-08-08 12:48:09 +02:00
JINMEI Tatuya
46b961d69a
[1062] various types of editorial/trivial fixes.
2011-08-08 01:41:39 -07:00
Michal 'vorner' Vaner
56083614ae
[1061] Rename DatabaseConnection to DatabaseAbstraction
...
As database connection might be confusing, use something better. Also
renamed SQLiteConnection to SQLiteDatabase
2011-08-07 12:29:11 +02:00
Jelte Jansen
5f13949918
[trac1062] refactor and fixes
...
- check for bad data in the db
- work with data in 'bad' order (sigs before data for example)
2011-08-05 18:02:33 +02:00
Michal 'vorner' Vaner
cce2a00af5
[1067] DatabaseClient part of iteration
...
The implementation of the ZoneIterator for DatabaseClient (it isn't
publicly visible, it is hidden in the .cc file) and tests for it.
2011-08-05 15:18:00 +02:00
Jelte Jansen
ce0544bd08
[trac1062] add some comments in the tests
2011-08-05 15:09:01 +02:00
Jelte Jansen
dba1e2c788
[trac1062] refactor/cleanup of tests
2011-08-05 15:09:01 +02:00
Jelte Jansen
bc281e8b48
[trac1062] initial support for RRSIGS for matches and CNAME
2011-08-05 15:09:00 +02:00
Jelte Jansen
82667b0cdd
[trac1062] minor cleanup
2011-08-05 15:09:00 +02:00
Jelte Jansen
71b0ae9ddb
[trac1062] tests and some additional code
2011-08-05 15:09:00 +02:00
Jelte Jansen
d23cde8c42
[trac1062] initial addition of searchForRecords and getNextRecord
2011-08-05 15:09:00 +02:00
Michal 'vorner' Vaner
07cd164792
[1067] Interface definitions for iterating database
...
* DatabaseClient::getIterator
* DatabaseConnection::getIteratorContext
* DatabaseConnection::IteratorContext
Nothing is implemented, it's just the header parts and doxygen comments.
2011-08-05 12:52:13 +02:00
Michal 'vorner' Vaner
fea1f88cd0
[1061] Address review comments
...
Mostly comments and cleanups, some simplification of interface and
change from auto_ptr to shared_ptr.
2011-08-04 17:23:17 +02:00
Michal 'vorner' Vaner
11b8b873e7
[trac1061] Implement finding a zone in DB
...
And provide some basics of the ZoneFinder, which does not work, but
compiles at last.
2011-08-01 13:06:13 +02:00
Michal 'vorner' Vaner
14a0766224
[trac1061] Test for constructor exception
2011-08-01 12:03:35 +02:00
