/doc/examples/kea6/all-keys.json
Added DDNS parameters to a pool
/doc/sphinx/arm/dhcp6-srv.rst
Updated section on DDNS Behavioral Parameters
/src/bin/dhcp4/tests/config_parser_unittest.cc
Added missing commentary
/src/bin/dhcp6/dhcp6_lexer.ll
/src/bin/dhcp6/dhcp6_parser.yy
Added parameters to POOL
/src/bin/dhcp6/tests/config_parser_unittest.cc
TEST_F(Dhcp6ParserTest, poolDdnsParameters) - new test
/src/bin/dhcp6/tests/fqdn_unittest.cc
TEST_F(FqdnDhcpv6SrvTest, poolDdnsParametersTest) - new test
/src/bin/dhcp6/tests/get_config_unittest.cc
Rebuilt
Fully functional in kea-dhcp4 (excluding doc update and CB support)
/doc/examples/kea4/all-keys.json
Added entries to a pool
/src/bin/dhcp4/dhcp4_lexer.ll
/src/bin/dhcp4/dhcp4_parser.yy
Added parameters to pools
/src/bin/dhcp4/dhcp4_srv.cc
Added comment
/src/bin/dhcp4/tests/config_parser_unittest.cc
TEST_F(Dhcp4ParserTest, poolDdnsParameters) - new test
/src/bin/dhcp4/tests/fqdn_unittest.cc
TEST_F(NameDhcpv4SrvTest, poolDdnsParametersTest) - new test
/src/bin/dhcp4/tests/get_config_unittest.cc
Updated
/src/lib/dhcpsrv/parsers/base_network_parser.*
Moved DDNS parameter parsing to a function template to allow use
by any class type
/src/lib/dhcpsrv/parsers/dhcp_parsers.cc
Added DDNS parameter parsing to PoolParser
/src/lib/dhcpsrv/parsers/simple_parser4.cc
Added paramters to pool
/src/lib/dhcpsrv/tests/dhcp_parsers_unittest.cc
TEST_F(DhcpParserTest, validDdnsParmatersPool4) - new test
The change that would have helped the reporter:
- Add paragraph explaining that out-of-network guarded subnets need
EGRL enabled in order for those guards to properly select subnets.
Other important changes:
- Define class guards. They are referenced in some places in the ARM,
but never defined.
- Move "unreserved_class" guards before "reserved_class" guards so that
it is clear that a pool or a subnet is skipped and the allocator takes
a different path than usual, assumin an iterative allocator.
- Add unguarded subnets and pools and explain that those are available
to both reserved and unreserved clients.
- Add paragraph explaining that in-subnet reservations don't work when
the subnet belongs to a shared network.
- Add paragraph explaining that for a subnet to be selected, when
choosing to do the selection via pools, as the example is structured,
all of the pools inside the subnets desired to be skipped or selected
need to be guarded.
- Add missing name to shared network in the JSON config examples.
Less important changes:
- Remove comments about reservation settings. Some were forgotten to be
removed since new reservation flags are added, but overall they don't
need to be explained because these sections are not focused on reservations.
- Add curly brackets to make the whole JSON valid and add code-block:: json
and reindent.
