JINMEI Tatuya
c91bffdd00
[2203] a piggy back fix: prevent redundant initial data configuration.
...
this addresses the issue described in #2291 . Still not really clean,
but thanks to boost::bind we can centralize all the code logic in the
callback, so I think it's now less likely that we forget cleaning it up
when the hack is not necessary.
2012-10-03 17:28:41 -07:00
JINMEI Tatuya
ec6cf17e57
[2203] changed configurator class to a simple function.
...
as it's now completely stateless and can work independently.
the common specialization for the main implementation is defined in a
new created .cc file.
2012-10-03 17:17:36 -07:00
JINMEI Tatuya
746376902a
[2203] pass server obj to configurator's reconfigure().
...
now the configurator class is completely stateless.
2012-10-03 15:44:29 -07:00
JINMEI Tatuya
05136b55f9
[2203] refactoring 2nd step: configurator can now be a separate object.
...
i.e., it's not a singleton any more.
testReconfigure() method isn't needed any more because it doesn't hold
CC session internally.
DatasrcConfiguratorTest.initialization test currently fails and is
disabled for now. The plan is to make the class completely stateless,
at which point we don't even have to think about initialization or cleanup,
and then the test will be able to be removed.
2012-10-03 15:24:22 -07:00
JINMEI Tatuya
0d4a6b6be1
[1870] avoid using "no" keyword as a configured value for "bind10-include".
2012-10-03 14:12:39 -07:00
JINMEI Tatuya
686eb4e9ed
[1870] removed unnecessary call to AX_BOOST_INCLUDE.
...
since AC_REQUIRE internally does it.
2012-10-03 12:21:40 -07:00
JINMEI Tatuya
3d68f76773
[2206] editorial fix: combine two short lines
...
(I also suspect it may not work if '\c' continues to the next line.
this change also avoids that)
2012-10-03 10:12:07 -07:00
JINMEI Tatuya
f802291f64
[master] Merge branch 'trac2060'
2012-10-03 09:26:13 -07:00
JINMEI Tatuya
fa51dffbe4
[2060] clarified the ownership of obj returned via getFinder/AllRRsets.
2012-10-03 09:21:16 -07:00
Jelte Jansen
9cfcbb9475
[2275] valgrind fix: initialize memory in labelsequence test
2012-10-03 16:54:08 +02:00
Jelte Jansen
0c38d26f6a
[2275] valgrind fix: store singleton instance in auto_ptr
2012-10-03 16:42:08 +02:00
Jelte Jansen
b89e441124
[2275] valgrind fix: close db in test case
2012-10-03 16:11:51 +02:00
Stephen Morris
d5a5e815fc
[2269] Minor documentation changes.
2012-10-03 14:32:37 +01:00
Jelte Jansen
98692b1e06
[master] fix src/lib/util/threads compiler/linker flags
...
This fixes the compilation issue shown on http://git.bind10.isc.org/~tester/builder/BIND10-valgrind/20121003092419-CentOS5-x86_64-GCC/logs/build.out
Discussed on jabber
2012-10-03 07:08:25 -04:00
JINMEI Tatuya
1886c9f308
[master] added 'std::' to strerror. sunstudio is strict and requires this.
...
this fixes build regression: http://git.bind10.isc.org/~tester/builder//BIND10/20121003052334-Solaris10-sparc-Sunstudio/logs/build.out
committing at my discretion (confirmed it compiled)
2012-10-03 07:58:32 +00:00
Mukund Sivaraman
37fd8a72b1
[2206] Add comment about moving methods to the header later
2012-10-03 11:15:52 +05:30
Mukund Sivaraman
1fb24f540a
[2206] Change getHeader() to return a reference
2012-10-03 11:11:02 +05:30
Mukund Sivaraman
c4c3946bad
[2206] Remove redundant return descriptions
2012-10-03 11:04:51 +05:30
Mukund Sivaraman
5c97541720
[2206] Fix doc comment
2012-10-03 11:02:16 +05:30
Mukund Sivaraman
538a160ef4
[2206] Add const variant of getHeader()
2012-10-03 10:58:30 +05:30
Mukund Sivaraman
e45115237b
[2206] Fix const variant of getTable()
2012-10-03 10:57:59 +05:30
Mukund Sivaraman
a072ee8db5
[2206] Add const method tests
2012-10-03 10:57:42 +05:30
Mukund Sivaraman
473e340929
[2206] Update comments
2012-10-03 10:49:54 +05:30
Mukund Sivaraman
94656c03d4
[2206] Make constructors protected
2012-10-03 10:49:01 +05:30
Mukund Sivaraman
a6748eee32
[2206] Use a fixture in tests
2012-10-03 10:21:17 +05:30
Mukund Sivaraman
5acf0ff36e
[2206] Add a ZoneTableSegment::destroy() method
...
Also update doc comments asking callers to use the destroy() method.
2012-10-03 10:10:45 +05:30
Mukund Sivaraman
1468031680
[2206] Add a doc comment that getHeader() should never return NULL
2012-10-03 10:00:06 +05:30
Mukund Sivaraman
d25bb8d27c
[2206] Add ZoneTableHeader::getTable() method
2012-10-03 09:58:04 +05:30
Mukund Sivaraman
f2b62e2480
[2206] Update doc comments to remove redundant bits
...
Also correct comments where wrong, and add a code comment for
ZoneTableSegment::create().
2012-10-03 09:41:29 +05:30
JINMEI Tatuya
4fa694dbee
[2203] changed the callback type of addRemoteConfig to boost::function.
...
this will make it more convenient, e.g., by allowing the caller to pass
boost::bind encapsulating a class object and a class method.
boost::function is upper compatible to function pointer, so it doesn't
ensure source-level compatibility.
the functor overhead shouldn't matter in this context, and since this module
already uses boost::function this change doesn't introduce additional
dependency.
2012-10-02 20:44:06 -07:00
JINMEI Tatuya
b4bdc9b1f5
[2203] refactoring 1st step: move session obj outside of datasrc configurator.
2012-10-02 20:24:57 -07:00
JINMEI Tatuya
e0ce6d2f30
[2060] (unrelated) make the finder Context class "more basic"
...
by defining a generic derived class and moving optional member variables
there.
this essentially addresses the issue of #1767 .
2012-10-02 16:12:29 -07:00
JINMEI Tatuya
d73842ed35
[2060] added the getAtOrigin() method to ZoneFinder::Context.
...
defining the common interface and the default implementation.
2012-10-02 14:15:14 -07:00
Michal 'vorner' Vaner
7eaa1760f3
Merge #2202
...
The locking of client lists in auth server. This is to allow background
loading later on.
Conflicts:
src/bin/auth/auth_srv.cc
src/bin/auth/auth_srv.h
2012-10-02 21:21:56 +02:00
Michal 'vorner' Vaner
5c74085e2f
[2292] Get rid of the const_cast
...
It was needed when extracting data from a domain tree chain. The chain
now can hold mutable pointers too, so we use that (and some amount of
template bureaucracy) to avoid the cast.
While the interface changed (on the core find function, it is not
possible to pass const node chain and have a mutable node get out), it
doesn't seem to influence the current code. Also, it is a private
interface anyway, so it should be safe.
2012-10-02 21:05:33 +02:00
Mukund Sivaraman
b7bff77c9d
[master] Add link to system specific install instructions to INSTALL
2012-10-03 00:34:28 +05:30
Michal 'vorner' Vaner
4babe763de
[2292] Parametrize constness of the chain
2012-10-02 20:54:48 +02:00
JINMEI Tatuya
ff7d15330f
[2202] minor style fix: folded a long line.
2012-10-02 10:43:35 -07:00
Tomek Mrugalski
574a6f8834
[2237] Pool4 and tests implemented.
2012-10-02 17:18:49 +02:00
JINMEI Tatuya
fc7462103f
[2202] Change comment style
...
So it is consistent with the rest.
2012-10-02 16:53:56 +02:00
Jelte Jansen
eace2551ac
[master] update changelog for merge of 2254
2012-10-02 16:26:22 +02:00
Michal 'vorner' Vaner
1ade0a0c0c
[2202] Use simpler test for mutex
...
As Jinmei suggests, a double seems to be not atomic enough, so we can
use that. This is mostly his code, slightly modified (and comments
rewritten).
2012-10-02 16:21:44 +02:00
Jelte Jansen
e00795f47f
[master] forgot to add test file to EXTRA_DIST
2012-10-02 16:00:42 +02:00
Jelte Jansen
9047de5e8f
[master] Merge branch 'trac2254'
2012-10-02 15:47:53 +02:00
Jelte Jansen
ae8740e0bf
[2254] Merge branch 'trac2254' of ssh://git.bind10.isc.org/var/bind10/git/bind10 into trac2254
2012-10-02 15:44:50 +02:00
Jelte Jansen
ed5f58850c
[2254] one more comment
2012-10-02 15:41:01 +02:00
Mukund Sivaraman
26e55ce110
Merge branch 'master' into trac2276
2012-10-02 19:06:11 +05:30
Jelte Jansen
397769f9a9
[2254] Expand _complete comment, add one more testcase
...
also renamed IDENTIFIER_PARAM to CFGITEM_IDENTIFIER_PARAM
2012-10-02 15:30:22 +02:00
Mukund Sivaraman
b9b8993431
[2301] Add comment for ANY_SUB query
2012-10-02 19:00:02 +05:30
Mukund Sivaraman
84d2f3799c
[2301] Update ANY_SUB query to use LIKE clause efficiently
...
See <https://lists.isc.org/pipermail/bind10-dev/2012-March/003167.html >
for discussion.
We should not do concatenation in the SQL clause (i.e., pass an
expression to LIKE). We also query on the 'rname' column (labels in
reverse order) instead of 'name'.
2012-10-02 18:53:05 +05:30