JINMEI Tatuya
a09cb3f049
[2124] some suggested changes:
...
- use !empty() instead of size() > 0. for vectors there should be
essentially no difference, but for other type of containers the former
is generally better, and so I believe it's better to always follow that
convention.
- constify
2012-07-27 00:18:32 -07:00
JINMEI Tatuya
866fcdbc68
[2106] updated documentation
2012-07-26 23:56:00 -07:00
Mukund Sivaraman
a539dcc9f4
[2106] Change variable naming slightly
2012-07-27 11:08:37 +05:30
Mukund Sivaraman
e50cd96f50
[2106] Remove Name variant of a RBTree::find() method
...
It was only used in the memory datasrc, which has been modified to use
the LabelSequence variant.
Also unify some tests.
2012-07-27 11:02:25 +05:30
JINMEI Tatuya
099edfbad5
[2095] a few more editorial fixes to comments.
2012-07-26 15:21:16 -07:00
Mukund Sivaraman
4017593862
[2124] Rename SSHFP getter methods
2012-07-26 22:33:46 +05:30
Mukund Sivaraman
d71f7e9f7c
[2124] Add another toWire() test
2012-07-26 22:30:14 +05:30
Mukund Sivaraman
73080d999e
[2124] Don't add trailing space in toText() if fingerprint is empty
...
Also add some tests.
2012-07-26 22:29:40 +05:30
Mukund Sivaraman
595b447c65
[2124] Don't access fingerprint_ data when size is 0
2012-07-26 22:28:47 +05:30
JINMEI Tatuya
cf17e8fb41
[master] Merge branch 'trac2152'
2012-07-26 09:24:57 -07:00
Jelte Jansen
baa709260c
[master] report actual error in masterload
...
if file cannot be opened.
acked on jabber by jinmei
2012-07-26 17:36:25 +02:00
JINMEI Tatuya
e8b5818741
[2152] don't play the game with union. the init hack didn't work.
...
it was wrong anyway because it tried to write to one field and read
from the other. and, it actually caused a failure on Solaris/Sparc.
I suspect it's due to endian and the data size differences, but since
the code was wrong anyway, I now decided to make it (in some sense) less
safer but more straightforward.
2012-07-26 00:34:19 -07:00
JINMEI Tatuya
26401e4e86
[2124] don't keep a reference to a temporary object.
...
'rdf' in the original code immediately became dangling reference.
2012-07-26 00:12:15 -07:00
Mukund Sivaraman
97873bf89c
[2106] Allow RBTree::find() to take LabelSequence
...
The Name find() variants already test the implementation well as they
wrap around it, but one test was added for checking the LabelSequence
variant API.
2012-07-26 11:47:54 +05:30
JINMEI Tatuya
ea31c8f67c
[2095] cleanup: removed unnecessary header file.
2012-07-25 23:02:18 -07:00
JINMEI Tatuya
48d02e544b
[2095] more documentation/comment update
2012-07-25 23:00:02 -07:00
JINMEI Tatuya
bc39e2531b
[2095] doxygen update
2012-07-25 22:40:32 -07:00
JINMEI Tatuya
6d937a0379
[2095] two more minor test cases
2012-07-25 17:54:29 -07:00
JINMEI Tatuya
673b0098bb
[2095] reject too big RRSIG
2012-07-25 17:41:18 -07:00
JINMEI Tatuya
291c79605d
[2095] supported RRSIG encoding with basic tests
2012-07-25 17:28:19 -07:00
JINMEI Tatuya
143fe6f4b2
[2095] rejected RRSIG in start()
2012-07-25 15:25:39 -07:00
JINMEI Tatuya
ff3f8e7a51
[2095] cleanup: removed now-unused stuff.
2012-07-25 15:18:46 -07:00
JINMEI Tatuya
d3ada48eec
[2095] handled various error cases
2012-07-25 15:17:17 -07:00
Jeremy C. Reed
3777aedaa6
[master] remove the file generated by unittest
...
remove file generated by src/bin/auth/tests/command_unittest.cc
to fix distcheck build
2012-07-25 17:14:15 -05:00
JINMEI Tatuya
f4e993ccbd
[2095] added some basic parameter validations.
2012-07-25 12:19:35 -07:00
Jeremy C. Reed
ec295b5042
[master] the datasrc.spec file is generated so use builddir
2012-07-25 13:14:46 -05:00
Jeremy C. Reed
530ee237aa
[master] make sure src/bin/auth/tests/testdata is in dist tarball
2012-07-25 12:53:49 -05:00
JINMEI Tatuya
fd4efa02ba
[2091b] removed an essentially-redundant assertion check.
2012-07-25 10:32:23 -07:00
JINMEI Tatuya
1ee0d41198
[2091b] cleanup: removed a leftover comment line
2012-07-25 10:27:31 -07:00
JINMEI Tatuya
98181a847e
[2091b] simplified bitfield swap
2012-07-25 10:26:21 -07:00
JINMEI Tatuya
69fd22252b
[2091b] more comment clarifications.
2012-07-25 10:15:43 -07:00
Jelte Jansen
f01bc8a1bf
[2148] final touches
2012-07-25 18:50:06 +02:00
Jelte Jansen
a47ad98951
[2148] Create test fixture for common names and buf
...
(not for actual labelsequences, IMO it looks better if they are defined locally)
2012-07-25 18:39:55 +02:00
JINMEI Tatuya
a79037eb4a
[2091b] doxygen comment wording fix.
2012-07-25 09:28:58 -07:00
Jelte Jansen
39e4107227
[2148] cleanup and documentation
2012-07-25 18:16:54 +02:00
Jelte Jansen
3a5fcdca4a
[2148] extend() improvements and more tests
2012-07-25 18:05:02 +02:00
Jeremy C. Reed
e53fc4d8cd
[master] regen some docs ; catch up on some doc changes
...
(hopefully soon we won't keep these in the git tree.)
2012-07-25 10:43:33 -05:00
Jelte Jansen
6aa8ff8e95
[2148] minor cleanup
2012-07-25 15:44:21 +02:00
Jelte Jansen
8553a206e4
[2148] add LabelSequence::extend() method
2012-07-25 15:29:01 +02:00
Jeremy C. Reed
438f31e788
[master] fix errors with ambiguous types and other boost uses
...
Stop doing "using namespace boost" and be specific with the using boost::.
Problem noticed on Solaris 11 with g++ 4.5.2 and boost 1.50.0.
Tested with older g++ 4.1.3 with boost 1.42.0 (on NetBSD).
Discussed little on jabber.
2012-07-25 07:49:12 -05:00
Jeremy C. Reed
40f1877422
[master] fix "error: reference to `map' is ambiguous"
2012-07-25 07:48:16 -05:00
Michal 'vorner' Vaner
6ef9a033a5
Explicitly use std:: for map
...
It seems some compilers can't find it otherwise. This should make them
happy.
2012-07-25 13:52:04 +02:00
Michal 'vorner' Vaner
ea15a1dd55
Don't require dynamic libs on static link
...
There were tests that should have been disabled too, as they use the
static data source, which is loaded dynamically from a .so. Some systems
break on them.
2012-07-25 13:46:23 +02:00
Marcin Siodelski
48755af6bf
[1958] Added perfdhcp statistics printing functions.
2012-07-25 13:19:46 +02:00
Jelte Jansen
6f60dbc937
[2148] update doxygen for constructor
2012-07-25 11:47:54 +02:00
Jelte Jansen
1780e99cd2
[2148] 'extendable' labelsequence constructor
2012-07-25 11:41:33 +02:00
Mukund Sivaraman
31477bf850
[2124] Test toWire() with empty fingerprint data
2012-07-25 13:07:40 +05:30
Mukund Sivaraman
3b82a4fda3
[2124] Handle empty SSHFP fingerprints
2012-07-25 13:01:45 +05:30
Mukund Sivaraman
16cd39d09f
[2124] Add wiredata tests where the record is shorter than rdata len indicates
2012-07-25 11:24:59 +05:30
JINMEI Tatuya
4e5ddf8ba2
[2095] tested multi-RDATA cases.
...
the implementation already supported this case, so only need to adjust tests.
encoding parts of the temporary hack is now unnecessary and removed.
tests were refactored so we can share the same test logic in multiple
scenarios.
2012-07-24 21:49:09 -07:00
