mirror of
https://github.com/kotatogram/kotatogram-desktop
synced 2025-08-28 21:27:53 +00:00
720f238cf8
QApplication has a historical feature[1] of calling setlocale(3) at init, which today cause more harm than good. Such call isn't thread safe neither per C standard, not per any known libc implementation. The Gio threads would call into locale reading functions all the time, so early access to locale by Gio may race with setlocale() by Qt leading to undefined behavior. Platform specific start before the Sandbox (aka QApplication) is at core design of tdesktop and that order can't be changed. There is no way to pause Gio until QApplication instantiates. Fortunately, Qt library itself has a static global flag that prevents it from calling setlocale() twice. We don't even need to instantiate a temporary QCoreApplication, we can just call into the method. So call it form Platform::start before any existing or future calls to Gio. Fixes #16922 [1] https://chat.stackoverflow.com/rooms/63812/discussion-between-phil-armstrong-and-matteo-italia