mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
044f2113dc3f5e76fa3b56e57823c9c9b7f390b6
libreoffice/vcl/qt5/QtInstanceTreeView.cxx

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

785 lines
20 KiB
C++
Raw Normal View History

qt: Update vim headers/trailers Following commit 4f08a15f3be9b39d0f1e83e6cffa47b62c183b69 Author: lovatico21 <lorenzo04lovato@gmail.com> Date: Wed Nov 13 18:12:58 2024 +0100 updated vim footers in vcl/qt6/*.cxx , update vim header/trailers to those in current `TEMPLATE.SOURCECODE.HEADER` for other qt5/qt6 headers and sources as well (i.e. for directories `vcl/inc/qt5`, `vcl/inc/qt6` and `vcl/qt5/`). Change-Id: If9fea8f4ce955396f064dbd9fd706e76d947bce1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176705 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-18 09:33:05 +01:00
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#include <QtInstanceTreeView.hxx>
#include <QtInstanceTreeView.moc>
#include <vcl/qt/QtUtils.hxx>
tdf#130857 qt weld: Implement setting tree view entry ID Use QStandardItem::setData with a custom role (ROLE_ID, with a value sufficiently larger than Qt::UserRole to avoid any accidental overlap, as e.g. QStandardItem::setData would use a default role of Qt::UserRole + 1) to set the ID. Implement QtInstanceTreeView::get_id to get the ID for the entry with a given index. Change-Id: If1c8cecac44fb3eb9ca2152abb05c3864240383a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177567 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 00:34:32 +01:00
// role used for the ID in the QStandardItem
constexpr int ROLE_ID = Qt::UserRole + 1000;
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
QtInstanceTreeView::QtInstanceTreeView(QTreeView* pTreeView)
: QtInstanceWidget(pTreeView)
, m_pTreeView(pTreeView)
{
assert(m_pTreeView);
tdf#130857 qt weld: Implement basic tree view logic Implement a small subset of the QtInstanceTreeView methods - basically what is used by Calc's "Sheets" -> "Show Sheets" dialog for which support will be declared in an upcoming commit. In QtBuilder, ignore "GtkCellRendererText" and "GtkTreeSelection" objects, just as VclBuilder does. For now, also don't implement logic for handling "GtkTreeViewColumn" objects yet, but add a warning that this is still missing. Use QStandardItemModel for the tree view's model. For those methods where not all possible parameters are handled yet, add asserts that will trigger when called with currently still unsupported ones, so this can easily be identified when working on support for dialogs using more complex tree views in the future. QtInstanceTreeView::get_height_rows logic to return the required height to show n entries also still needs some thought, so the method simply warns and returns 0 for now, which means that the tree view might not be shown with the ideal initial height, but resizing the dialog is sufficient to work around that for now if needed. Change-Id: I13d9bd4a742c29a3dfc2c17b6c1a13f9fe40270e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177541 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29 15:44:47 +01:00
m_pModel = qobject_cast<QStandardItemModel*>(m_pTreeView->model());
assert(m_pModel && "tree view doesn't have expected item model set");
tdf#130857 qt weld: Call tree view row activation handler Change-Id: Ib95cc7d4c2b60d3b426b76573ff06917637d838e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177572 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-30 01:36:47 +01:00
tdf#130857 qt weld: Add member for tree view selection model ... and use it in misc places instead of calling QTreeView::selectionModel repeatedly. Change-Id: I9d9ee622bb98bf3267d858ee484128b364d14ad2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177574 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 01:59:32 +01:00
m_pSelectionModel = m_pTreeView->selectionModel();
assert(m_pSelectionModel);
tdf#130857 qt weld: Notify about current tree view item change When the current (focus) item in the tree view changes, call weld::TreeView::signal_changed to notify about this. While QTreeView doesn't have a signal for that itself, its QItemSelectionModel does, so connect to that one. With this in place, SvPasteObjectDialog::SelectHdl now gets called when switching between items in the "Past Special" dialog when using the qt6 VCL plugin with native Qt widgets, as is the case with the gtk3 VCL plugin. Change-Id: I5aab68055f711480d56b043252d15621f18c4919 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177573 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 01:51:28 +01:00
tdf#130857 qt weld: Add member for tree view selection model ... and use it in misc places instead of calling QTreeView::selectionModel repeatedly. Change-Id: I9d9ee622bb98bf3267d858ee484128b364d14ad2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177574 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 01:59:32 +01:00
connect(m_pTreeView, &QTreeView::activated, this, &QtInstanceTreeView::handleActivated);
tdf#130857 qt weld: Return selected item when requested in callback The current item and the selected item(s) are not necessarily the same. Looking into the gtk and VCL implementations, weld::TreeView::signal_changed is called when the selection (not the current item) changes, so connect to the QItemSelectionModel::selectionChanged signal instead of the QItemSelectionModel::currentChanged one in the Qt implementation. At the point in time that the QItemSelectionModel::selectionChanged signal gets emitted, QItemSelectionModel::selectedIndexes returns the newly selected indices while that was not yet the case with QItemSelectionModel::currentChanged. For the "Device" tab in the "File" -> "Printer Settings" -> "Properties" dialog (for which support will be added in an upcoming commit), this resulted in the PPD values (in the tree view on the right) not being shown for the actually selected PPD option/key (in the left tree view), but for the one selected previously. (See RTSDevicePage::SelectHdl for the logic filling the tree view with items, which gets triggered when weld::TreeView::signal_changed gets called.) Change-Id: I31ec5aaaa47cd3d4704f25086b24645fb708be0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177922 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-05 23:46:35 +01:00
connect(m_pSelectionModel, &QItemSelectionModel::selectionChanged, this,
&QtInstanceTreeView::handleSelectionChanged);
tdf#130857 qt weld: Implement basic tree view logic Implement a small subset of the QtInstanceTreeView methods - basically what is used by Calc's "Sheets" -> "Show Sheets" dialog for which support will be declared in an upcoming commit. In QtBuilder, ignore "GtkCellRendererText" and "GtkTreeSelection" objects, just as VclBuilder does. For now, also don't implement logic for handling "GtkTreeViewColumn" objects yet, but add a warning that this is still missing. Use QStandardItemModel for the tree view's model. For those methods where not all possible parameters are handled yet, add asserts that will trigger when called with currently still unsupported ones, so this can easily be identified when working on support for dialogs using more complex tree views in the future. QtInstanceTreeView::get_height_rows logic to return the required height to show n entries also still needs some thought, so the method simply warns and returns 0 for now, which means that the tree view might not be shown with the ideal initial height, but resizing the dialog is sufficient to work around that for now if needed. Change-Id: I13d9bd4a742c29a3dfc2c17b6c1a13f9fe40270e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177541 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29 15:44:47 +01:00
}
void QtInstanceTreeView::insert(const weld::TreeIter* pParent, int pos, const OUString* pStr,
const OUString* pId, const OUString* pIconName,
VirtualDevice* pImageSurface, bool bChildrenOnDemand,
weld::TreeIter* pRet)
{
// Only specific subset of parameters handled so far;
// assert only these are used at the moment and implement remaining cases
// when needed to support more dialogs, then adjust/remove asserts below
assert(!pParent && "Not implemented yet");
assert(pos == -1 && "Not implemented yet");
assert(!pIconName && "Not implemented yet");
assert(!pImageSurface && "Not implemented yet");
assert(!bChildrenOnDemand && "Not implemented yet");
assert(!pRet && "Not implemented yet");
// avoid -Werror=unused-parameter for release build
(void)pParent;
(void)pos;
(void)pIconName;
(void)pImageSurface;
(void)bChildrenOnDemand;
(void)pRet;
SolarMutexGuard g;
GetQtInstance().RunInMainThread([&] {
tdf#130857 qt weld: Implement setting tree view entry ID Use QStandardItem::setData with a custom role (ROLE_ID, with a value sufficiently larger than Qt::UserRole to avoid any accidental overlap, as e.g. QStandardItem::setData would use a default role of Qt::UserRole + 1) to set the ID. Implement QtInstanceTreeView::get_id to get the ID for the entry with a given index. Change-Id: If1c8cecac44fb3eb9ca2152abb05c3864240383a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177567 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 00:34:32 +01:00
QStandardItem* pItem = new QStandardItem;
if (pStr)
pItem->setText(toQString(*pStr));
if (pId)
pItem->setData(toQString(*pId), ROLE_ID);
tdf#130857 qt weld: Implement basic tree view logic Implement a small subset of the QtInstanceTreeView methods - basically what is used by Calc's "Sheets" -> "Show Sheets" dialog for which support will be declared in an upcoming commit. In QtBuilder, ignore "GtkCellRendererText" and "GtkTreeSelection" objects, just as VclBuilder does. For now, also don't implement logic for handling "GtkTreeViewColumn" objects yet, but add a warning that this is still missing. Use QStandardItemModel for the tree view's model. For those methods where not all possible parameters are handled yet, add asserts that will trigger when called with currently still unsupported ones, so this can easily be identified when working on support for dialogs using more complex tree views in the future. QtInstanceTreeView::get_height_rows logic to return the required height to show n entries also still needs some thought, so the method simply warns and returns 0 for now, which means that the tree view might not be shown with the ideal initial height, but resizing the dialog is sufficient to work around that for now if needed. Change-Id: I13d9bd4a742c29a3dfc2c17b6c1a13f9fe40270e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177541 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29 15:44:47 +01:00
m_pModel->appendRow(pItem);
});
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
}
void QtInstanceTreeView::insert_separator(int, const OUString&)
{
assert(false && "Not implemented yet");
}
OUString QtInstanceTreeView::get_selected_text() const
{
tdf#130857 qt weld: Implement QtInstanceTreeView::get_selected_{id,text} Change-Id: I6a732606c6bf762033744824e857f861077b0237 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177569 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-30 01:09:10 +01:00
SolarMutexGuard g;
OUString sText;
GetQtInstance().RunInMainThread([&] {
tdf#130857 qt weld: Add member for tree view selection model ... and use it in misc places instead of calling QTreeView::selectionModel repeatedly. Change-Id: I9d9ee622bb98bf3267d858ee484128b364d14ad2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177574 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 01:59:32 +01:00
const QModelIndexList aSelectedIndexes = m_pSelectionModel->selectedIndexes();
tdf#130857 qt weld: Implement QtInstanceTreeView::get_selected_{id,text} Change-Id: I6a732606c6bf762033744824e857f861077b0237 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177569 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-30 01:09:10 +01:00
if (aSelectedIndexes.empty())
return;
sText = toOUString(m_pModel->itemFromIndex(aSelectedIndexes.first())->text());
});
return sText;
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
}
OUString QtInstanceTreeView::get_selected_id() const
{
tdf#130857 qt weld: Implement QtInstanceTreeView::get_selected_{id,text} Change-Id: I6a732606c6bf762033744824e857f861077b0237 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177569 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-30 01:09:10 +01:00
SolarMutexGuard g;
OUString sId;
GetQtInstance().RunInMainThread([&] {
tdf#130857 qt weld: Add member for tree view selection model ... and use it in misc places instead of calling QTreeView::selectionModel repeatedly. Change-Id: I9d9ee622bb98bf3267d858ee484128b364d14ad2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177574 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 01:59:32 +01:00
const QModelIndexList aSelectedIndexes = m_pSelectionModel->selectedIndexes();
tdf#130857 qt weld: Implement QtInstanceTreeView::get_selected_{id,text} Change-Id: I6a732606c6bf762033744824e857f861077b0237 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177569 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-30 01:09:10 +01:00
if (aSelectedIndexes.empty())
return;
QVariant aIdData = aSelectedIndexes.first().data(ROLE_ID);
if (aIdData.canConvert<QString>())
sId = toOUString(aIdData.toString());
});
return sId;
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
}
void QtInstanceTreeView::enable_toggle_buttons(weld::ColumnToggleType)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::set_clicks_to_toggle(int) { assert(false && "Not implemented yet"); }
int QtInstanceTreeView::get_selected_index() const
{
tdf#130857 qt weld: Implement more TreeView methods wrt selection Change-Id: I3479b138a0986f1fbac7745e575e318bf63c1911 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177576 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 02:17:21 +01:00
SolarMutexGuard g;
int nIndex = -1;
GetQtInstance().RunInMainThread([&] {
const QModelIndexList aSelectedIndexes = m_pSelectionModel->selectedIndexes();
if (aSelectedIndexes.empty())
return;
nIndex = aSelectedIndexes.first().row();
});
return nIndex;
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
}
tdf#130857 qt weld: Implement basic tree view logic Implement a small subset of the QtInstanceTreeView methods - basically what is used by Calc's "Sheets" -> "Show Sheets" dialog for which support will be declared in an upcoming commit. In QtBuilder, ignore "GtkCellRendererText" and "GtkTreeSelection" objects, just as VclBuilder does. For now, also don't implement logic for handling "GtkTreeViewColumn" objects yet, but add a warning that this is still missing. Use QStandardItemModel for the tree view's model. For those methods where not all possible parameters are handled yet, add asserts that will trigger when called with currently still unsupported ones, so this can easily be identified when working on support for dialogs using more complex tree views in the future. QtInstanceTreeView::get_height_rows logic to return the required height to show n entries also still needs some thought, so the method simply warns and returns 0 for now, which means that the tree view might not be shown with the ideal initial height, but resizing the dialog is sufficient to work around that for now if needed. Change-Id: I13d9bd4a742c29a3dfc2c17b6c1a13f9fe40270e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177541 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29 15:44:47 +01:00
void QtInstanceTreeView::select(int nPos)
{
SolarMutexGuard g;
tdf#130857 qt weld: Add member for tree view selection model ... and use it in misc places instead of calling QTreeView::selectionModel repeatedly. Change-Id: I9d9ee622bb98bf3267d858ee484128b364d14ad2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177574 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 01:59:32 +01:00
GetQtInstance().RunInMainThread(
[&] { m_pSelectionModel->select(m_pModel->index(nPos, 0), QItemSelectionModel::Select); });
tdf#130857 qt weld: Implement basic tree view logic Implement a small subset of the QtInstanceTreeView methods - basically what is used by Calc's "Sheets" -> "Show Sheets" dialog for which support will be declared in an upcoming commit. In QtBuilder, ignore "GtkCellRendererText" and "GtkTreeSelection" objects, just as VclBuilder does. For now, also don't implement logic for handling "GtkTreeViewColumn" objects yet, but add a warning that this is still missing. Use QStandardItemModel for the tree view's model. For those methods where not all possible parameters are handled yet, add asserts that will trigger when called with currently still unsupported ones, so this can easily be identified when working on support for dialogs using more complex tree views in the future. QtInstanceTreeView::get_height_rows logic to return the required height to show n entries also still needs some thought, so the method simply warns and returns 0 for now, which means that the tree view might not be shown with the ideal initial height, but resizing the dialog is sufficient to work around that for now if needed. Change-Id: I13d9bd4a742c29a3dfc2c17b6c1a13f9fe40270e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177541 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29 15:44:47 +01:00
}
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
tdf#130857 qt weld: Implement more TreeView methods wrt selection Change-Id: I3479b138a0986f1fbac7745e575e318bf63c1911 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177576 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 02:17:21 +01:00
void QtInstanceTreeView::unselect(int nPos)
{
SolarMutexGuard g;
GetQtInstance().RunInMainThread([&] {
m_pSelectionModel->select(m_pModel->index(nPos, 0), QItemSelectionModel::Deselect);
});
}
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
void QtInstanceTreeView::remove(int) { assert(false && "Not implemented yet"); }
tdf#130857 qt weld: Implement basic tree view logic Implement a small subset of the QtInstanceTreeView methods - basically what is used by Calc's "Sheets" -> "Show Sheets" dialog for which support will be declared in an upcoming commit. In QtBuilder, ignore "GtkCellRendererText" and "GtkTreeSelection" objects, just as VclBuilder does. For now, also don't implement logic for handling "GtkTreeViewColumn" objects yet, but add a warning that this is still missing. Use QStandardItemModel for the tree view's model. For those methods where not all possible parameters are handled yet, add asserts that will trigger when called with currently still unsupported ones, so this can easily be identified when working on support for dialogs using more complex tree views in the future. QtInstanceTreeView::get_height_rows logic to return the required height to show n entries also still needs some thought, so the method simply warns and returns 0 for now, which means that the tree view might not be shown with the ideal initial height, but resizing the dialog is sufficient to work around that for now if needed. Change-Id: I13d9bd4a742c29a3dfc2c17b6c1a13f9fe40270e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177541 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29 15:44:47 +01:00
OUString QtInstanceTreeView::get_text(int nRow, int nCol) const
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
{
tdf#130857 qt weld: Implement basic tree view logic Implement a small subset of the QtInstanceTreeView methods - basically what is used by Calc's "Sheets" -> "Show Sheets" dialog for which support will be declared in an upcoming commit. In QtBuilder, ignore "GtkCellRendererText" and "GtkTreeSelection" objects, just as VclBuilder does. For now, also don't implement logic for handling "GtkTreeViewColumn" objects yet, but add a warning that this is still missing. Use QStandardItemModel for the tree view's model. For those methods where not all possible parameters are handled yet, add asserts that will trigger when called with currently still unsupported ones, so this can easily be identified when working on support for dialogs using more complex tree views in the future. QtInstanceTreeView::get_height_rows logic to return the required height to show n entries also still needs some thought, so the method simply warns and returns 0 for now, which means that the tree view might not be shown with the ideal initial height, but resizing the dialog is sufficient to work around that for now if needed. Change-Id: I13d9bd4a742c29a3dfc2c17b6c1a13f9fe40270e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177541 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29 15:44:47 +01:00
assert(nCol == -1 && "Column support not implemented yet");
(void)nCol; // for release build
SolarMutexGuard g;
OUString sText;
GetQtInstance().RunInMainThread([&] {
const QModelIndex aIndex = m_pModel->index(nRow, 0);
const QVariant aData = m_pModel->data(aIndex);
assert(aData.canConvert<QString>() && "model data not a string");
sText = toOUString(aData.toString());
});
return sText;
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
}
tdf#130857 qt weld: Implement QtInstanceTreeView::set_text For now, require that the actual column index is passed. The weld::TreeView::set_text doc mentions // col index -1 sets the first text column , but that is not supported yet, so assert a different index is passed for now. Revisit when implementing support for a dialog that actually makes use of this. Change-Id: I8ba6e965ba22542bf3151548200b92c8c6b085d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178061 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-07 19:53:28 +01:00
void QtInstanceTreeView::set_text(int nRow, const OUString& rText, int nCol)
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
{
tdf#130857 qt weld: Implement QtInstanceTreeView::set_text For now, require that the actual column index is passed. The weld::TreeView::set_text doc mentions // col index -1 sets the first text column , but that is not supported yet, so assert a different index is passed for now. Revisit when implementing support for a dialog that actually makes use of this. Change-Id: I8ba6e965ba22542bf3151548200b92c8c6b085d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178061 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-07 19:53:28 +01:00
assert(nCol != -1 && "Support for special index -1 (first text column) not implemented yet");
SolarMutexGuard g;
GetQtInstance().RunInMainThread([&] {
QStandardItem* pItem = m_pModel->item(nRow, nCol);
if (!pItem)
{
pItem = new QStandardItem;
m_pModel->setItem(nRow, nCol, pItem);
}
pItem->setText(toQString(rText));
});
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
}
void QtInstanceTreeView::set_sensitive(int, bool, int) { assert(false && "Not implemented yet"); }
bool QtInstanceTreeView::get_sensitive(int, int) const
{
assert(false && "Not implemented yet");
return false;
}
void QtInstanceTreeView::set_id(int, const OUString&) { assert(false && "Not implemented yet"); }
void QtInstanceTreeView::set_toggle(int, TriState, int) { assert(false && "Not implemented yet"); }
TriState QtInstanceTreeView::get_toggle(int, int) const
{
assert(false && "Not implemented yet");
return TRISTATE_INDET;
}
void QtInstanceTreeView::set_image(int, const OUString&, int)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::set_image(int, VirtualDevice&, int)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::set_image(int, const css::uno::Reference<css::graphic::XGraphic>&, int)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::set_text_emphasis(int, bool, int)
{
assert(false && "Not implemented yet");
}
bool QtInstanceTreeView::get_text_emphasis(int, int) const
{
assert(false && "Not implemented yet");
return false;
}
void QtInstanceTreeView::set_text_align(int, double, int)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::swap(int, int) { assert(false && "Not implemented yet"); }
std::vector<int> QtInstanceTreeView::get_selected_rows() const
{
tdf#130857 qt weld: Implement basic tree view logic Implement a small subset of the QtInstanceTreeView methods - basically what is used by Calc's "Sheets" -> "Show Sheets" dialog for which support will be declared in an upcoming commit. In QtBuilder, ignore "GtkCellRendererText" and "GtkTreeSelection" objects, just as VclBuilder does. For now, also don't implement logic for handling "GtkTreeViewColumn" objects yet, but add a warning that this is still missing. Use QStandardItemModel for the tree view's model. For those methods where not all possible parameters are handled yet, add asserts that will trigger when called with currently still unsupported ones, so this can easily be identified when working on support for dialogs using more complex tree views in the future. QtInstanceTreeView::get_height_rows logic to return the required height to show n entries also still needs some thought, so the method simply warns and returns 0 for now, which means that the tree view might not be shown with the ideal initial height, but resizing the dialog is sufficient to work around that for now if needed. Change-Id: I13d9bd4a742c29a3dfc2c17b6c1a13f9fe40270e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177541 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29 15:44:47 +01:00
SolarMutexGuard g;
std::vector<int> aSelectedRows;
GetQtInstance().RunInMainThread([&] {
tdf#130857 qt weld: Report selected tree view row only once Now that support for multiple columns has been implemented in QtInstanceTreeView, iterating over all selected model indices and appending their row index to the vector results in the row being appended once fore each column of the selected row. (Index seen twice in `aRows` in XMLFilterSettingsDialog::updateStates while debugging another issue in the "Tools" > "XML Filter Settings" dialog with the qt6 VCL plugin and SAL_VCL_QT_USE_WELDED_WIDGETS=1). Use QItemSelectionModel::selectedRows (with the default column index of 0) instead of QItemSelectionModel::selectedIndexes to prevent that. Change-Id: Ic8caa299549d954ed844c39c4b2ba957edf2b404 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178067 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-07 23:13:25 +01:00
const QModelIndexList aSelectionIndexes = m_pSelectionModel->selectedRows();
tdf#130857 qt weld: Implement basic tree view logic Implement a small subset of the QtInstanceTreeView methods - basically what is used by Calc's "Sheets" -> "Show Sheets" dialog for which support will be declared in an upcoming commit. In QtBuilder, ignore "GtkCellRendererText" and "GtkTreeSelection" objects, just as VclBuilder does. For now, also don't implement logic for handling "GtkTreeViewColumn" objects yet, but add a warning that this is still missing. Use QStandardItemModel for the tree view's model. For those methods where not all possible parameters are handled yet, add asserts that will trigger when called with currently still unsupported ones, so this can easily be identified when working on support for dialogs using more complex tree views in the future. QtInstanceTreeView::get_height_rows logic to return the required height to show n entries also still needs some thought, so the method simply warns and returns 0 for now, which means that the tree view might not be shown with the ideal initial height, but resizing the dialog is sufficient to work around that for now if needed. Change-Id: I13d9bd4a742c29a3dfc2c17b6c1a13f9fe40270e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177541 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29 15:44:47 +01:00
for (const QModelIndex& aIndex : aSelectionIndexes)
aSelectedRows.push_back(aIndex.row());
});
return aSelectedRows;
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
}
void QtInstanceTreeView::set_font_color(int, const Color&)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::scroll_to_row(int) { assert(false && "Not implemented yet"); }
bool QtInstanceTreeView::is_selected(int) const
{
assert(false && "Not implemented yet");
return false;
}
int QtInstanceTreeView::get_cursor_index() const
{
tdf#130857 qt weld: Implement getting/setting cursor This is independent of the selection. (For selection, there is weld::TreeView::select and weld::TreeView::get_selected_index instead.) Change-Id: I3698a080cebaf4411740b0e7a95c54743e84d881 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178024 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-06 09:59:32 +01:00
SolarMutexGuard g;
int nIndex = -1;
GetQtInstance().RunInMainThread([&] {
const QModelIndex aCurrentIndex = m_pSelectionModel->currentIndex();
if (aCurrentIndex.isValid())
nIndex = aCurrentIndex.row();
});
return nIndex;
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
}
tdf#130857 qt weld: Implement getting/setting cursor This is independent of the selection. (For selection, there is weld::TreeView::select and weld::TreeView::get_selected_index instead.) Change-Id: I3698a080cebaf4411740b0e7a95c54743e84d881 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178024 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-06 09:59:32 +01:00
void QtInstanceTreeView::set_cursor(int nPos)
{
SolarMutexGuard g;
GetQtInstance().RunInMainThread([&] {
m_pSelectionModel->setCurrentIndex(m_pModel->index(nPos, 0), QItemSelectionModel::NoUpdate);
});
}
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
tdf#130857 qt weld: Implement QtInstanceTreeView::find_{id,text} Still untested. Change-Id: I2124852eb00bc515264ae99798e4b05a37c7266b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177568 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-30 00:48:16 +01:00
int QtInstanceTreeView::find_text(const OUString& rText) const
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
{
tdf#130857 qt weld: Implement QtInstanceTreeView::find_{id,text} Still untested. Change-Id: I2124852eb00bc515264ae99798e4b05a37c7266b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177568 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-30 00:48:16 +01:00
SolarMutexGuard g;
int nIndex = -1;
GetQtInstance().RunInMainThread([&] {
const QList<QStandardItem*> aItems = m_pModel->findItems(toQString(rText));
if (!aItems.empty())
nIndex = aItems.at(0)->index().row();
});
return nIndex;
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
}
tdf#130857 qt weld: Implement setting tree view entry ID Use QStandardItem::setData with a custom role (ROLE_ID, with a value sufficiently larger than Qt::UserRole to avoid any accidental overlap, as e.g. QStandardItem::setData would use a default role of Qt::UserRole + 1) to set the ID. Implement QtInstanceTreeView::get_id to get the ID for the entry with a given index. Change-Id: If1c8cecac44fb3eb9ca2152abb05c3864240383a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177567 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 00:34:32 +01:00
OUString QtInstanceTreeView::get_id(int nPos) const
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
{
tdf#130857 qt weld: Implement setting tree view entry ID Use QStandardItem::setData with a custom role (ROLE_ID, with a value sufficiently larger than Qt::UserRole to avoid any accidental overlap, as e.g. QStandardItem::setData would use a default role of Qt::UserRole + 1) to set the ID. Implement QtInstanceTreeView::get_id to get the ID for the entry with a given index. Change-Id: If1c8cecac44fb3eb9ca2152abb05c3864240383a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177567 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 00:34:32 +01:00
SolarMutexGuard g;
OUString sId;
GetQtInstance().RunInMainThread([&] {
tdf#130857 qt weld: Fix incorrect param order for row/col In QtInstanceTreeView::get_id, the nPos param is the row number, but was incorrectly passed as the second parameter to QStandardItemModel::index [1] which is for the column. Swap the params to fix that. Passing incorrectly would trigger a crash in a WIP branch for Writer's "Tools" -> "XML Filter Settings" dialog when clicking on the second row, as the ID data is only set for the item in the first, not the second column, so `pInfo` in XMLFilterSettingsDialog::updateStates would be null. Backtrace: 1 XMLFilterSettingsDialog::updateStates xmlfiltersettingsdialog.cxx 183 0x7f3eb862194e 2 XMLFilterSettingsDialog::SelectionChangedHdl_Impl xmlfiltersettingsdialog.cxx 153 0x7f3eb8621859 3 XMLFilterSettingsDialog::LinkStubSelectionChangedHdl_Impl xmlfiltersettingsdialog.cxx 151 0x7f3eb861e8cd 4 Link<weld::TreeView&, void>::Call link.hxx 111 0x7f3eeb997aa1 5 weld::TreeView::signal_selection_changed weld.hxx 989 0x7f3eeb99733c 6 QtInstanceTreeView::handleSelectionChanged QtInstanceTreeView.cxx 781 0x7f3eeb98cb2d 7 QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceTreeView:: *)()>::call(void (QtInstanceTreeView:: *)(), QtInstanceTreeView *, void * *)::{lambda()#1}::operator()() const qobjectdefs_impl.h 127 0x7f3eeb998141 8 QtPrivate::FunctorCallBase::call_internal<void, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceTreeView:: *)()>::call(void (QtInstanceTreeView:: *)(), QtInstanceTreeView *, void * *)::{lambda()#1}>(void * *, QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceTreeView:: *)()>::call(void (QtInstanceTreeView:: *)(), QtInstanceTreeView *, void * *)::{lambda()#1}&&) qobjectdefs_impl.h 65 0x7f3eeb998079 9 QtPrivate::FunctorCall<std::integer_sequence<unsigned long>, QtPrivate::List<>, void, void (QtInstanceTreeView:: *)()>::call(void (QtInstanceTreeView:: *)(), QtInstanceTreeView *, void * *) qobjectdefs_impl.h 126 0x7f3eeb997fab 10 QtPrivate::FunctionPointer<void (QtInstanceTreeView:: *)()>::call<QtPrivate::List<>, void>(void (QtInstanceTreeView:: *)(), QtInstanceTreeView *, void * *) qobjectdefs_impl.h 174 0x7f3eeb997f2d 11 QtPrivate::QCallableObject<void (QtInstanceTreeView:: *)(), QtPrivate::List<>, void>::impl(int, QtPrivate::QSlotObjectBase *, QObject *, void * *, bool *) qobjectdefs_impl.h 545 0x7f3eeb997e56 12 QtPrivate::QSlotObjectBase::call qobjectdefs_impl.h 461 0x7f3eeaa5ce22 13 doActivate<false> qobject.cpp 4139 0x7f3eeab1c644 14 QMetaObject::activate qobject.cpp 4199 0x7f3eeab121b3 15 QMetaObject::activate<void, QItemSelection, QItemSelection> qobjectdefs.h 306 0x7f3eeaf93da5 16 QItemSelectionModel::selectionChanged moc_qitemselectionmodel.cpp 390 0x7f3eeaf85b76 17 QItemSelectionModel::emitSelectionChanged qitemselectionmodel.cpp 2029 0x7f3eeaf87a2f 18 QItemSelectionModel::select qitemselectionmodel.cpp 1372 0x7f3eeaf872f9 19 QTreeViewPrivate::select qtreeview.cpp 4016 0x7f3ee906f2ec 20 QTreeView::setSelection qtreeview.cpp 2393 0x7f3ee906eaae ... <More> Change-Id: Icf6b3004ab95991da69c0ff86201421d620aaa43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178066 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-07 23:02:08 +01:00
QVariant aRoleData = m_pModel->data(m_pModel->index(nPos, 0), ROLE_ID);
tdf#130857 qt weld: Implement setting tree view entry ID Use QStandardItem::setData with a custom role (ROLE_ID, with a value sufficiently larger than Qt::UserRole to avoid any accidental overlap, as e.g. QStandardItem::setData would use a default role of Qt::UserRole + 1) to set the ID. Implement QtInstanceTreeView::get_id to get the ID for the entry with a given index. Change-Id: If1c8cecac44fb3eb9ca2152abb05c3864240383a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177567 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 00:34:32 +01:00
if (aRoleData.canConvert<QString>())
sId = toOUString(aRoleData.toString());
});
return sId;
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
}
tdf#130857 qt weld: Implement QtInstanceTreeView::find_{id,text} Still untested. Change-Id: I2124852eb00bc515264ae99798e4b05a37c7266b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177568 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-30 00:48:16 +01:00
int QtInstanceTreeView::find_id(const OUString& rId) const
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
{
tdf#130857 qt weld: Implement QtInstanceTreeView::find_{id,text} Still untested. Change-Id: I2124852eb00bc515264ae99798e4b05a37c7266b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177568 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-30 00:48:16 +01:00
SolarMutexGuard g;
int nIndex = -1;
GetQtInstance().RunInMainThread([&] {
for (int i = 0; i < m_pModel->rowCount(); i++)
{
if (get_id(i) == rId)
{
nIndex = i;
return;
}
}
});
return nIndex;
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
}
std::unique_ptr<weld::TreeIter> QtInstanceTreeView::make_iterator(const weld::TreeIter*) const
{
assert(false && "Not implemented yet");
return nullptr;
}
void QtInstanceTreeView::copy_iterator(const weld::TreeIter&, weld::TreeIter&) const
{
assert(false && "Not implemented yet");
}
bool QtInstanceTreeView::get_selected(weld::TreeIter*) const
{
assert(false && "Not implemented yet");
return false;
}
bool QtInstanceTreeView::get_cursor(weld::TreeIter*) const
{
assert(false && "Not implemented yet");
return false;
}
void QtInstanceTreeView::set_cursor(const weld::TreeIter&)
{
assert(false && "Not implemented yet");
}
bool QtInstanceTreeView::get_iter_first(weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return false;
}
bool QtInstanceTreeView::iter_next_sibling(weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return false;
}
bool QtInstanceTreeView::iter_previous_sibling(weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return false;
}
bool QtInstanceTreeView::iter_next(weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return false;
}
bool QtInstanceTreeView::iter_previous(weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return false;
}
bool QtInstanceTreeView::iter_children(weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return false;
}
bool QtInstanceTreeView::iter_parent(weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return false;
}
int QtInstanceTreeView::get_iter_depth(const weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return -1;
}
int QtInstanceTreeView::get_iter_index_in_parent(const weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return -1;
}
int QtInstanceTreeView::iter_compare(const weld::TreeIter&, const weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return 0;
}
bool QtInstanceTreeView::iter_has_child(const weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return false;
}
int QtInstanceTreeView::iter_n_children(const weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return -1;
}
void QtInstanceTreeView::remove(const weld::TreeIter&) { assert(false && "Not implemented yet"); }
void QtInstanceTreeView::select(const weld::TreeIter&) { assert(false && "Not implemented yet"); }
void QtInstanceTreeView::unselect(const weld::TreeIter&) { assert(false && "Not implemented yet"); }
void QtInstanceTreeView::set_extra_row_indent(const weld::TreeIter&, int)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::set_text(const weld::TreeIter&, const OUString&, int)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::set_sensitive(const weld::TreeIter&, bool, int)
{
assert(false && "Not implemented yet");
}
bool QtInstanceTreeView::get_sensitive(const weld::TreeIter&, int) const
{
assert(false && "Not implemented yet");
return false;
}
void QtInstanceTreeView::set_text_emphasis(const weld::TreeIter&, bool, int)
{
assert(false && "Not implemented yet");
}
bool QtInstanceTreeView::get_text_emphasis(const weld::TreeIter&, int) const
{
assert(false && "Not implemented yet");
return false;
}
void QtInstanceTreeView::set_text_align(const weld::TreeIter&, double, int)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::set_toggle(const weld::TreeIter&, TriState, int)
{
assert(false && "Not implemented yet");
}
TriState QtInstanceTreeView::get_toggle(const weld::TreeIter&, int) const
{
assert(false && "Not implemented yet");
return TRISTATE_INDET;
}
OUString QtInstanceTreeView::get_text(const weld::TreeIter&, int) const
{
assert(false && "Not implemented yet");
return OUString();
}
void QtInstanceTreeView::set_id(const weld::TreeIter&, const OUString&)
{
assert(false && "Not implemented yet");
}
OUString QtInstanceTreeView::get_id(const weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return OUString();
}
void QtInstanceTreeView::set_image(const weld::TreeIter&, const OUString&, int)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::set_image(const weld::TreeIter&, VirtualDevice&, int)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::set_image(const weld::TreeIter&,
const css::uno::Reference<css::graphic::XGraphic>&, int)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::set_font_color(const weld::TreeIter&, const Color&)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::scroll_to_row(const weld::TreeIter&)
{
assert(false && "Not implemented yet");
}
bool QtInstanceTreeView::is_selected(const weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return false;
}
void QtInstanceTreeView::move_subtree(weld::TreeIter&, const weld::TreeIter*, int)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::all_foreach(const std::function<bool(weld::TreeIter&)>&)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::selected_foreach(const std::function<bool(weld::TreeIter&)>&)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::visible_foreach(const std::function<bool(weld::TreeIter&)>&)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::bulk_insert_for_each(
int, const std::function<void(weld::TreeIter&, int nSourceIndex)>&, const weld::TreeIter*,
const std::vector<int>*, bool)
{
assert(false && "Not implemented yet");
}
bool QtInstanceTreeView::get_row_expanded(const weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return false;
}
void QtInstanceTreeView::expand_row(const weld::TreeIter&)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::collapse_row(const weld::TreeIter&)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::set_children_on_demand(const weld::TreeIter&, bool)
{
assert(false && "Not implemented yet");
}
bool QtInstanceTreeView::get_children_on_demand(const weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return false;
}
void QtInstanceTreeView::set_show_expanders(bool) { assert(false && "Not implemented yet"); }
void QtInstanceTreeView::start_editing(const weld::TreeIter&)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::end_editing() { assert(false && "Not implemented yet"); }
void QtInstanceTreeView::enable_drag_source(rtl::Reference<TransferDataContainer>&, sal_uInt8)
{
assert(false && "Not implemented yet");
}
int QtInstanceTreeView::n_children() const
{
tdf#130857 qt weld: Implement basic tree view logic Implement a small subset of the QtInstanceTreeView methods - basically what is used by Calc's "Sheets" -> "Show Sheets" dialog for which support will be declared in an upcoming commit. In QtBuilder, ignore "GtkCellRendererText" and "GtkTreeSelection" objects, just as VclBuilder does. For now, also don't implement logic for handling "GtkTreeViewColumn" objects yet, but add a warning that this is still missing. Use QStandardItemModel for the tree view's model. For those methods where not all possible parameters are handled yet, add asserts that will trigger when called with currently still unsupported ones, so this can easily be identified when working on support for dialogs using more complex tree views in the future. QtInstanceTreeView::get_height_rows logic to return the required height to show n entries also still needs some thought, so the method simply warns and returns 0 for now, which means that the tree view might not be shown with the ideal initial height, but resizing the dialog is sufficient to work around that for now if needed. Change-Id: I13d9bd4a742c29a3dfc2c17b6c1a13f9fe40270e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177541 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29 15:44:47 +01:00
SolarMutexGuard g;
int nChildCount;
GetQtInstance().RunInMainThread(
[&] { nChildCount = m_pModel->rowCount(m_pModel->invisibleRootItem()->index()); });
return nChildCount;
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
}
void QtInstanceTreeView::make_sorted() { assert(false && "Not implemented yet"); }
void QtInstanceTreeView::make_unsorted() { assert(false && "Not implemented yet"); }
bool QtInstanceTreeView::get_sort_order() const
{
assert(false && "Not implemented yet");
return false;
}
void QtInstanceTreeView::set_sort_order(bool) { assert(false && "Not implemented yet"); }
void QtInstanceTreeView::set_sort_indicator(TriState, int)
{
assert(false && "Not implemented yet");
}
TriState QtInstanceTreeView::get_sort_indicator(int) const
{
assert(false && "Not implemented yet");
return TRISTATE_INDET;
}
int QtInstanceTreeView::get_sort_column() const
{
assert(false && "Not implemented yet");
return -1;
}
void QtInstanceTreeView::set_sort_column(int) { assert(false && "Not implemented yet"); }
tdf#130857 qt weld: Implement QtInstanceTreeView::clear Used e.g. in RTSDevicePage::FillValueBox (i.e. in the "File" -> "Printer Settings" -> "Properties" dialog). Change-Id: Ice39b266b366a6fd6b37b6ece28cee529990dc80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177909 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-05 22:49:48 +01:00
void QtInstanceTreeView::clear()
{
SolarMutexGuard g;
tdf#130857 qt weld: Set tree view column header title Make the `extractTitle` helper function used by VclBuilder a static method in the BuilderBase base class for reuse by QtBuilder. In QtBuilder::makeObject, when encountering a "GtkTreeViewColumn" object, add a new column to the QTreeView and set the column title in the underlying model using QStandardItemModel::setHeaderData. Return the parent (tree view). (Returning no object would cause WidgetBuilder::handleObject to call WidgetBuilder::insertObject again, and thus result in every column being processed twice, i.e. the double amount of columns would be inserted). Adjust QtInstanceTreeView::clear to no longer call QStandardItemModel::clear [1], as that would not only remove the "actual" items, but also the header items, i.e. the column titles would get lost as well. Remove all rows instead. With this in place, the tree view in Writer's "Tool" -> "XML Filter Settings" dialog has the correct data + title set on open in a WIP branch where support for that dialog is declared in QtInstanceBuilder. (Other aspects in the dialog still need to be addressed however.) [1] https://doc.qt.io/qt-6/qstandarditemmodel.html#clear Change-Id: I59956c007ed73cddb299ad2374afd88199ddc94d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178063 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-07 21:04:49 +01:00
GetQtInstance().RunInMainThread([&] {
// don't use QStandardItemModel::clear, as that would remove header data as well
m_pModel->removeRows(0, m_pModel->rowCount());
});
tdf#130857 qt weld: Implement QtInstanceTreeView::clear Used e.g. in RTSDevicePage::FillValueBox (i.e. in the "File" -> "Printer Settings" -> "Properties" dialog). Change-Id: Ice39b266b366a6fd6b37b6ece28cee529990dc80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177909 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-05 22:49:48 +01:00
}
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
int QtInstanceTreeView::get_height_rows(int) const
{
tdf#130857 qt weld: Implement basic tree view logic Implement a small subset of the QtInstanceTreeView methods - basically what is used by Calc's "Sheets" -> "Show Sheets" dialog for which support will be declared in an upcoming commit. In QtBuilder, ignore "GtkCellRendererText" and "GtkTreeSelection" objects, just as VclBuilder does. For now, also don't implement logic for handling "GtkTreeViewColumn" objects yet, but add a warning that this is still missing. Use QStandardItemModel for the tree view's model. For those methods where not all possible parameters are handled yet, add asserts that will trigger when called with currently still unsupported ones, so this can easily be identified when working on support for dialogs using more complex tree views in the future. QtInstanceTreeView::get_height_rows logic to return the required height to show n entries also still needs some thought, so the method simply warns and returns 0 for now, which means that the tree view might not be shown with the ideal initial height, but resizing the dialog is sufficient to work around that for now if needed. Change-Id: I13d9bd4a742c29a3dfc2c17b6c1a13f9fe40270e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177541 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-29 15:44:47 +01:00
SAL_WARN("vcl.qt", "QtInstanceTreeView::get_height_rows just returns 0 for now");
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
return 0;
}
tdf#130857 qt weld: Implement QtInstanceTreeView::columns_autosize QTreeView::resizeColumnToContents [1] looks like the Qt equivalent for GTK's gtk_tree_view_columns_autosize [2]. [1] https://doc.qt.io/qt-6/qtreeview.html#resizeColumnToContents [2] https://docs.gtk.org/gtk3/method.TreeView.columns_autosize.html Change-Id: I4771896fb932834f51fa48ceaa3557181f474fcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178062 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-07 20:02:08 +01:00
void QtInstanceTreeView::columns_autosize()
{
SolarMutexGuard g;
GetQtInstance().RunInMainThread([&] {
for (int i = 0; i < m_pModel->columnCount(); i++)
m_pTreeView->resizeColumnToContents(i);
});
}
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
void QtInstanceTreeView::set_column_fixed_widths(const std::vector<int>&)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::set_column_editables(const std::vector<bool>&)
{
assert(false && "Not implemented yet");
}
int QtInstanceTreeView::get_column_width(int) const
{
assert(false && "Not implemented yet");
return 0;
}
void QtInstanceTreeView::set_centered_column(int) { assert(false && "Not implemented yet"); }
OUString QtInstanceTreeView::get_column_title(int) const
{
assert(false && "Not implemented yet");
return OUString();
}
void QtInstanceTreeView::set_column_title(int, const OUString&)
{
assert(false && "Not implemented yet");
}
tdf#130857 qt weld: Implement QtInstanceTreeView::set_selection_mode Change-Id: I1b41a57ccdda4cdbd8a3a8ab3dbde495a51df80e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177508 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-28 23:21:47 +01:00
void QtInstanceTreeView::set_selection_mode(SelectionMode eMode)
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
{
tdf#130857 qt weld: Implement QtInstanceTreeView::set_selection_mode Change-Id: I1b41a57ccdda4cdbd8a3a8ab3dbde495a51df80e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177508 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-28 23:21:47 +01:00
SolarMutexGuard g;
GetQtInstance().RunInMainThread(
[&] { m_pTreeView->setSelectionMode(mapSelectionMode(eMode)); });
tdf#130857 qt weld: Add QtInstanceTreeView skeleton Add a new QtInstanceTreeView class that is the weld::TreeView implementation using a native Qt widget. It uses a QTreeView. Initially, all methods trigger an assert; the actual logic still needs to be implemented in future commits. Let QtBuilder handle "GtkTreeView" objects by creating a QTreeView. Let QtInstanceBuilder::weld_treeview return an instance of the new class. Change-Id: Ia3e694dbef9033fe45a6d2bdbe09fc021cd47c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176307 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-09 00:28:06 +01:00
}
int QtInstanceTreeView::count_selected_rows() const
{
assert(false && "Not implemented yet");
return 0;
}
void QtInstanceTreeView::remove_selection() { assert(false && "Not implemented yet"); }
bool QtInstanceTreeView::changed_by_hover() const
{
assert(false && "Not implemented yet");
return false;
}
void QtInstanceTreeView::vadjustment_set_value(int) { assert(false && "Not implemented yet"); }
int QtInstanceTreeView::vadjustment_get_value() const
{
assert(false && "Not implemented yet");
return -1;
}
void QtInstanceTreeView::set_column_custom_renderer(int, bool)
{
assert(false && "Not implemented yet");
}
void QtInstanceTreeView::queue_draw() { assert(false && "Not implemented yet"); }
bool QtInstanceTreeView::get_dest_row_at_pos(const Point&, weld::TreeIter*, bool, bool)
{
assert(false && "Not implemented yet");
return false;
}
void QtInstanceTreeView::unset_drag_dest_row() { assert(false && "Not implemented yet"); }
tools::Rectangle QtInstanceTreeView::get_row_area(const weld::TreeIter&) const
{
assert(false && "Not implemented yet");
return tools::Rectangle();
}
weld::TreeView* QtInstanceTreeView::get_drag_source() const
{
assert(false && "Not implemented yet");
return nullptr;
}
tdf#130857 qt weld: Implement QtInstanceTreeView::set_selection_mode Change-Id: I1b41a57ccdda4cdbd8a3a8ab3dbde495a51df80e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177508 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-28 23:21:47 +01:00
QAbstractItemView::SelectionMode QtInstanceTreeView::mapSelectionMode(SelectionMode eMode)
{
switch (eMode)
{
case SelectionMode::NONE:
return QAbstractItemView::NoSelection;
case SelectionMode::Single:
return QAbstractItemView::SingleSelection;
case SelectionMode::Range:
return QAbstractItemView::ContiguousSelection;
case SelectionMode::Multiple:
return QAbstractItemView::ExtendedSelection;
default:
assert(false && "unhandled selection mode");
return QAbstractItemView::SingleSelection;
}
}
tdf#130857 qt weld: Call tree view row activation handler Change-Id: Ib95cc7d4c2b60d3b426b76573ff06917637d838e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177572 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-30 01:36:47 +01:00
void QtInstanceTreeView::handleActivated()
{
SolarMutexGuard g;
signal_row_activated();
}
tdf#130857 qt weld: Return selected item when requested in callback The current item and the selected item(s) are not necessarily the same. Looking into the gtk and VCL implementations, weld::TreeView::signal_changed is called when the selection (not the current item) changes, so connect to the QItemSelectionModel::selectionChanged signal instead of the QItemSelectionModel::currentChanged one in the Qt implementation. At the point in time that the QItemSelectionModel::selectionChanged signal gets emitted, QItemSelectionModel::selectedIndexes returns the newly selected indices while that was not yet the case with QItemSelectionModel::currentChanged. For the "Device" tab in the "File" -> "Printer Settings" -> "Properties" dialog (for which support will be added in an upcoming commit), this resulted in the PPD values (in the tree view on the right) not being shown for the actually selected PPD option/key (in the left tree view), but for the one selected previously. (See RTSDevicePage::SelectHdl for the logic filling the tree view with items, which gets triggered when weld::TreeView::signal_changed gets called.) Change-Id: I31ec5aaaa47cd3d4704f25086b24645fb708be0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177922 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-12-05 23:46:35 +01:00
void QtInstanceTreeView::handleSelectionChanged()
tdf#130857 qt weld: Notify about current tree view item change When the current (focus) item in the tree view changes, call weld::TreeView::signal_changed to notify about this. While QTreeView doesn't have a signal for that itself, its QItemSelectionModel does, so connect to that one. With this in place, SvPasteObjectDialog::SelectHdl now gets called when switching between items in the "Past Special" dialog when using the qt6 VCL plugin with native Qt widgets, as is the case with the gtk3 VCL plugin. Change-Id: I5aab68055f711480d56b043252d15621f18c4919 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177573 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 01:51:28 +01:00
{
SolarMutexGuard g;
weld: Rename weld::Treeview selection signal/connect Rename weld::TreeView member + methods to clarify that these are about selection changes: * m_aChangeHdl to m_aSelectionChangedHdl, * signal_changed to signal_selection_changed * connect_changed to connect_selection_changed In GtkInstanceTreeview, also rename the related methods calling signal_selection_changed accordingly for consistency. Change-Id: I299d7930484677395a0bdd0ff105df18688f2e04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178023 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-06 09:48:44 +01:00
signal_selection_changed();
tdf#130857 qt weld: Notify about current tree view item change When the current (focus) item in the tree view changes, call weld::TreeView::signal_changed to notify about this. While QTreeView doesn't have a signal for that itself, its QItemSelectionModel does, so connect to that one. With this in place, SvPasteObjectDialog::SelectHdl now gets called when switching between items in the "Past Special" dialog when using the qt6 VCL plugin with native Qt widgets, as is the case with the gtk3 VCL plugin. Change-Id: I5aab68055f711480d56b043252d15621f18c4919 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177573 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-11-30 01:51:28 +01:00
}
qt: Update vim headers/trailers Following commit 4f08a15f3be9b39d0f1e83e6cffa47b62c183b69 Author: lovatico21 <lorenzo04lovato@gmail.com> Date: Wed Nov 13 18:12:58 2024 +0100 updated vim footers in vcl/qt6/*.cxx , update vim header/trailers to those in current `TEMPLATE.SOURCECODE.HEADER` for other qt5/qt6 headers and sources as well (i.e. for directories `vcl/inc/qt5`, `vcl/inc/qt6` and `vcl/qt5/`). Change-Id: If9fea8f4ce955396f064dbd9fd706e76d947bce1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176705 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-18 09:33:05 +01:00
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
Reference in New Issue Copy Permalink