2017-10-27 13:15:37 +02:00
|
|
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
|
|
|
/*
|
|
|
|
|
* This file is part of the LibreOffice project.
|
|
|
|
|
*
|
|
|
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
|
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
|
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
|
|
|
*
|
|
|
|
|
* This file incorporates work covered by the following license notice:
|
|
|
|
|
*
|
|
|
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
|
|
|
* contributor license agreements. See the NOTICE file distributed
|
|
|
|
|
* with this work for additional information regarding copyright
|
|
|
|
|
* ownership. The ASF licenses this file to you under the Apache
|
|
|
|
|
* License, Version 2.0 (the "License"); you may not use this file
|
|
|
|
|
* except in compliance with the License. You may obtain a copy of
|
|
|
|
|
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#pragma once
|
|
|
|
|
|
|
|
|
|
#include <QtWidgets/QWidget>
|
2018-12-11 12:12:52 +01:00
|
|
|
#include <rtl/ustring.hxx>
|
2017-10-27 13:15:37 +02:00
|
|
|
|
2018-12-21 17:25:17 +01:00
|
|
|
#include <com/sun/star/uno/Reference.hxx>
|
|
|
|
|
#include <com/sun/star/accessibility/XAccessibleEditableText.hpp>
|
|
|
|
|
|
2018-08-10 18:29:10 +02:00
|
|
|
class Qt5Frame;
|
|
|
|
|
class Qt5Object;
|
2019-05-12 14:30:06 +02:00
|
|
|
class QEvent;
|
2018-08-10 18:29:10 +02:00
|
|
|
class QFocusEvent;
|
2018-12-21 17:25:17 +01:00
|
|
|
class QInputMethodEvent;
|
2018-08-10 18:29:10 +02:00
|
|
|
class QKeyEvent;
|
|
|
|
|
class QMouseEvent;
|
|
|
|
|
class QMoveEvent;
|
|
|
|
|
class QPaintEvent;
|
|
|
|
|
class QResizeEvent;
|
|
|
|
|
class QShowEvent;
|
|
|
|
|
class QWheelEvent;
|
2018-12-21 17:25:17 +01:00
|
|
|
class QVariant;
|
2017-10-27 13:15:37 +02:00
|
|
|
|
2018-08-10 18:29:10 +02:00
|
|
|
class Qt5Widget : public QWidget
|
|
|
|
|
{
|
|
|
|
|
Q_OBJECT
|
|
|
|
|
|
2019-05-05 23:22:09 +00:00
|
|
|
Qt5Frame& m_rFrame;
|
Qt5 IM handle (spurious?) all-empty IM events
2nd attempt to fix the bug described in commit 00221089800c ("Qt5
IM allow committing empty strings") and various siblings of it.
This also reverts it.
What I see is calls with "all-empty" events (preedit, commit and
replacementLength() == 0; no QInputMethodEvent::Attribute), some
from QIBusPlatformInputContext::updatePreeditText.
There are various Writer document edit states with (selected)
text, undo, cursor position and focus changes to other windows via
Ctrl+Tab, which will result in inputMethodEvent calls totally in
contrast to the expected text state, all somehow always related to
all-empty events. They currently result in wrongly deleted
selected text, change of selection, cursor movement or general
change of text from old preedit. Most time on focus out / window
change, some times at first meta-key press after focus in.
This patch tries hard not to corrupt Writers edit state with these
all-empty events. No idea if this is some bug on LO's qt5 side or
expected, but KDE kate and VCL gtk3 and gen work fine, so I assume
Qt's behaviour is correct. FWIW gtk3 also does some extended IM
handling with focus, so probably this is the Qt equivalent of it.
But then I couldn't find some eqivalent code in Qt's source code.
I actually expected an even more complex solution (if this really
fixes all cases).
Works for a multitude of tests I tried to come up with, but is
quite probably not the final fix to this, as qt5 current doesn't
handle replacementStart() and replacementLength() at all.
Also never saw a call to Qt5Frame::EndExtTextInput.
Change-Id: I4210e0588041cfb4d80dbdfdb937e430a5f7cbfb
Reviewed-on: https://gerrit.libreoffice.org/71988
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-08 11:51:15 +00:00
|
|
|
bool m_bNonEmptyIMPreeditSeen;
|
2019-06-06 01:01:11 +00:00
|
|
|
int m_nDeltaX;
|
|
|
|
|
int m_nDeltaY;
|
2019-05-05 23:22:09 +00:00
|
|
|
|
2018-08-10 18:29:10 +02:00
|
|
|
bool handleKeyEvent(QKeyEvent*, bool);
|
|
|
|
|
void handleMouseButtonEvent(QMouseEvent*, bool);
|
2019-06-01 19:46:16 +00:00
|
|
|
void commitText(const QString& aText) const;
|
2018-08-10 18:29:10 +02:00
|
|
|
|
2019-01-16 14:57:42 +03:00
|
|
|
virtual bool event(QEvent*) override;
|
|
|
|
|
|
2018-08-10 18:29:10 +02:00
|
|
|
virtual void focusInEvent(QFocusEvent*) override;
|
|
|
|
|
virtual void focusOutEvent(QFocusEvent*) override;
|
Qt5 IM handle (spurious?) all-empty IM events
2nd attempt to fix the bug described in commit 00221089800c ("Qt5
IM allow committing empty strings") and various siblings of it.
This also reverts it.
What I see is calls with "all-empty" events (preedit, commit and
replacementLength() == 0; no QInputMethodEvent::Attribute), some
from QIBusPlatformInputContext::updatePreeditText.
There are various Writer document edit states with (selected)
text, undo, cursor position and focus changes to other windows via
Ctrl+Tab, which will result in inputMethodEvent calls totally in
contrast to the expected text state, all somehow always related to
all-empty events. They currently result in wrongly deleted
selected text, change of selection, cursor movement or general
change of text from old preedit. Most time on focus out / window
change, some times at first meta-key press after focus in.
This patch tries hard not to corrupt Writers edit state with these
all-empty events. No idea if this is some bug on LO's qt5 side or
expected, but KDE kate and VCL gtk3 and gen work fine, so I assume
Qt's behaviour is correct. FWIW gtk3 also does some extended IM
handling with focus, so probably this is the Qt equivalent of it.
But then I couldn't find some eqivalent code in Qt's source code.
I actually expected an even more complex solution (if this really
fixes all cases).
Works for a multitude of tests I tried to come up with, but is
quite probably not the final fix to this, as qt5 current doesn't
handle replacementStart() and replacementLength() at all.
Also never saw a call to Qt5Frame::EndExtTextInput.
Change-Id: I4210e0588041cfb4d80dbdfdb937e430a5f7cbfb
Reviewed-on: https://gerrit.libreoffice.org/71988
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-08 11:51:15 +00:00
|
|
|
// keyPressEvent(QKeyEvent*) is handled via event(QEvent*); see comment
|
2018-08-10 18:29:10 +02:00
|
|
|
virtual void keyReleaseEvent(QKeyEvent*) override;
|
|
|
|
|
virtual void mouseMoveEvent(QMouseEvent*) override;
|
|
|
|
|
virtual void mousePressEvent(QMouseEvent*) override;
|
|
|
|
|
virtual void mouseReleaseEvent(QMouseEvent*) override;
|
2018-10-12 16:19:07 +02:00
|
|
|
virtual void dragEnterEvent(QDragEnterEvent*) override;
|
|
|
|
|
virtual void dragMoveEvent(QDragMoveEvent*) override;
|
|
|
|
|
virtual void dropEvent(QDropEvent*) override;
|
2018-08-10 18:29:10 +02:00
|
|
|
virtual void moveEvent(QMoveEvent*) override;
|
|
|
|
|
virtual void paintEvent(QPaintEvent*) override;
|
|
|
|
|
virtual void resizeEvent(QResizeEvent*) override;
|
|
|
|
|
virtual void showEvent(QShowEvent*) override;
|
|
|
|
|
virtual void wheelEvent(QWheelEvent*) override;
|
|
|
|
|
virtual void closeEvent(QCloseEvent*) override;
|
2019-05-12 14:30:06 +02:00
|
|
|
virtual void changeEvent(QEvent*) override;
|
2018-08-10 18:29:10 +02:00
|
|
|
|
2018-12-21 17:25:17 +01:00
|
|
|
void inputMethodEvent(QInputMethodEvent*) override;
|
|
|
|
|
QVariant inputMethodQuery(Qt::InputMethodQuery) const override;
|
|
|
|
|
|
2018-12-11 12:12:52 +01:00
|
|
|
public slots:
|
2018-12-12 12:33:26 +00:00
|
|
|
static void showTooltip(const OUString& rTip);
|
2018-12-11 12:12:52 +01:00
|
|
|
|
2018-08-10 18:29:10 +02:00
|
|
|
public:
|
|
|
|
|
Qt5Widget(Qt5Frame& rFrame, Qt::WindowFlags f = Qt::WindowFlags());
|
2019-05-05 23:22:09 +00:00
|
|
|
|
|
|
|
|
Qt5Frame& getFrame() const { return m_rFrame; }
|
2019-02-28 15:03:12 +01:00
|
|
|
void startDrag(sal_Int8 nSourceActions);
|
Qt5 IM handle (spurious?) all-empty IM events
2nd attempt to fix the bug described in commit 00221089800c ("Qt5
IM allow committing empty strings") and various siblings of it.
This also reverts it.
What I see is calls with "all-empty" events (preedit, commit and
replacementLength() == 0; no QInputMethodEvent::Attribute), some
from QIBusPlatformInputContext::updatePreeditText.
There are various Writer document edit states with (selected)
text, undo, cursor position and focus changes to other windows via
Ctrl+Tab, which will result in inputMethodEvent calls totally in
contrast to the expected text state, all somehow always related to
all-empty events. They currently result in wrongly deleted
selected text, change of selection, cursor movement or general
change of text from old preedit. Most time on focus out / window
change, some times at first meta-key press after focus in.
This patch tries hard not to corrupt Writers edit state with these
all-empty events. No idea if this is some bug on LO's qt5 side or
expected, but KDE kate and VCL gtk3 and gen work fine, so I assume
Qt's behaviour is correct. FWIW gtk3 also does some extended IM
handling with focus, so probably this is the Qt equivalent of it.
But then I couldn't find some eqivalent code in Qt's source code.
I actually expected an even more complex solution (if this really
fixes all cases).
Works for a multitude of tests I tried to come up with, but is
quite probably not the final fix to this, as qt5 current doesn't
handle replacementStart() and replacementLength() at all.
Also never saw a call to Qt5Frame::EndExtTextInput.
Change-Id: I4210e0588041cfb4d80dbdfdb937e430a5f7cbfb
Reviewed-on: https://gerrit.libreoffice.org/71988
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-08 11:51:15 +00:00
|
|
|
void endExtTextInput();
|
2018-08-10 18:29:10 +02:00
|
|
|
};
|
2018-07-17 15:57:41 +02:00
|
|
|
|
2017-10-27 13:15:37 +02:00
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|