Files
libreoffice/compilerplugins/clang/sharedvisitor/dummyplugin.hxx

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

82 lines
3.3 KiB
C++
Raw Normal View History

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* Based on LLVM/Clang.
*
* This file is distributed under the University of Illinois Open Source
* License. See LICENSE.TXT for details.
*
*/
#pragma once
#include "config_clang.h"
#include "../plugin.hxx"
using namespace clang;
using namespace llvm;
namespace loplugin
{
// These classes are used as base classes when building with LO_CLANG_SHARED_PLUGINS.
// Since plugin classes in that case should use just one shared RecursiveASTVisitor,
// sharedvisitor/generator.cxx will make these to be the base classes used, so that
// compiling the code doesn't spend a several minutes optimizing instances
// of RecursiveASTVisitor that will never get used.
template<typename T>
class DummyRecursiveASTVisitor
{
public:
// These need to be reimplemented, because plugins contain calls to them,
// but they should actually never get called in the shared-visitor mode.
// This could be autogenerated too, but it's probably simpler to just extend
// manually as needed.
bool TraverseDecl( Decl* ) { return complain(); }
bool TraverseLinkageSpecDecl( LinkageSpecDecl* ) { return complain(); }
bool TraverseStmt( Stmt* ) { return complain(); }
Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptr ...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-26 20:42:08 +02:00
bool TraverseIfStmt( IfStmt* ) { return complain(); }
bool TraverseWhileStmt( WhileStmt* ) { return complain(); }
bool TraverseDoStmt( DoStmt* ) { return complain(); }
bool TraverseForStmt( ForStmt* ) { return complain(); }
bool TraverseCompoundStmt( CompoundStmt* ) { return complain(); }
bool TraverseCXXForRangeStmt( CXXForRangeStmt* ) { return complain(); }
Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptr ...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-26 20:42:08 +02:00
bool TraverseConditionalOperator( ConditionalOperator* ) { return complain(); }
bool TraverseCXXCatchStmt( CXXCatchStmt* ) { return complain(); }
bool TraverseCXXDestructorDecl( CXXDestructorDecl* ) { return complain(); }
bool TraverseFunctionDecl( FunctionDecl* ) { return complain(); }
bool TraverseSwitchStmt( SwitchStmt* ) { return complain(); }
bool TraverseImplicitCastExpr( ImplicitCastExpr* ) { return complain(); }
bool TraverseCStyleCastExpr( CStyleCastExpr* ) { return complain(); }
bool TraverseCXXStaticCastExpr( CXXStaticCastExpr* ) { return complain(); }
bool TraverseCXXFunctionalCastExpr( CXXFunctionalCastExpr* ) { return complain(); }
bool TraverseFriendDecl( FriendDecl* ) { return complain(); }
bool TraverseTypeLoc( TypeLoc ) { return complain(); }
bool TraverseAlignedAttr( AlignedAttr* ) { return complain(); }
bool TraverseVarDecl( VarDecl* ) { return complain(); }
bool TraverseUnaryExprOrTypeTraitExpr( UnaryExprOrTypeTraitExpr* ) { return complain(); }
private:
bool complain() { assert(false && "should not be calling this in sharedplugin mode"); abort(); return false; }
};
template<typename Derived>
class DummyFilteringPlugin : public DummyRecursiveASTVisitor<Derived>, public Plugin
{
public:
explicit DummyFilteringPlugin( const InstantiationData& data ) : Plugin(data) {}
};
template<typename Derived>
class DummyFilteringRewritePlugin : public DummyRecursiveASTVisitor<Derived>, public RewritePlugin
{
public:
explicit DummyFilteringRewritePlugin( const InstantiationData& data ) : RewritePlugin(data) {}
};
} // namespace
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */