mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

java: make fields final where possible

Browse Source 
found by PMD

Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
This commit is contained in:
Noel Grandin
2014-11-18 10:01:21 +02:00
parent 250391009a
commit 0063cf2856
357 changed files with 863 additions and 926 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scripting/java/com/sun/star/script/framework/browse/DialogFactory.java
View File

@@ -41,7 +41,7 @@ import com.sun.star.uno.XComponentContext;
public class DialogFactory {
private static DialogFactory factory;
private XComponentContext xComponentContext;
private final XComponentContext xComponentContext;
// singleton
private DialogFactory(XComponentContext xComponentContext) {

4
scripting/java/com/sun/star/script/framework/browse/ParcelBrowseNode.java
View File

@@ -51,9 +51,9 @@ import javax.swing.JOptionPane;
public class ParcelBrowseNode extends PropertySet implements
XBrowseNode, XInvocation {
private ScriptProvider provider;
private final ScriptProvider provider;
private Collection<XBrowseNode> browsenodes;
private ParcelContainer container;
private final ParcelContainer container;
private Parcel parcel;
public ParcelBrowseNode(ScriptProvider provider, ParcelContainer container,

6
scripting/java/com/sun/star/script/framework/browse/ProviderBrowseNode.java
View File

@@ -47,11 +47,11 @@ import javax.swing.JOptionPane;
public class ProviderBrowseNode extends PropertySet implements
XBrowseNode, XInvocation {
private ScriptProvider provider;
private final ScriptProvider provider;
private Collection<XBrowseNode> browsenodes;
private String name;
private final String name;
protected ParcelContainer container;
private XComponentContext m_xCtx;
private final XComponentContext m_xCtx;
public ProviderBrowseNode(ScriptProvider provider, ParcelContainer container,
XComponentContext xCtx) {

4
scripting/java/com/sun/star/script/framework/browse/ScriptBrowseNode.java
View File

@@ -53,12 +53,12 @@ import java.util.HashMap;
public class ScriptBrowseNode extends PropertySet implements
XBrowseNode, XInvocation {
private ScriptProvider provider;
private final ScriptProvider provider;
private Parcel parent;
private String name;
private boolean editable = false;
private boolean editable;
private boolean deletable = false;
private boolean renamable = false;

2
scripting/java/com/sun/star/script/framework/container/ParcelContainer.java
View File

@@ -64,7 +64,7 @@ public class ParcelContainer implements XNameAccess {
static protected XSimpleFileAccess m_xSFA;
protected XComponentContext m_xCtx;
private ParcelContainer parent = null;
private Collection<ParcelContainer> childContainers = new
private final Collection<ParcelContainer> childContainers = new
ArrayList<ParcelContainer>(10);
private boolean isPkgContainer = false;

2
scripting/java/com/sun/star/script/framework/container/ParcelDescriptor.java
View File

@@ -54,7 +54,7 @@ public class ParcelDescriptor {
private Document document = null;
private String language = null;
private Map<String, String> languagedepprops = new HashMap<String, String>(3);
private final Map<String, String> languagedepprops = new HashMap<String, String>(3);
public ParcelDescriptor() throws IOException {
ByteArrayInputStream bis = null;

4
scripting/java/com/sun/star/script/framework/container/ScriptMetaData.java
View File

@@ -38,9 +38,9 @@ import java.util.StringTokenizer;
public class ScriptMetaData extends ScriptEntry {
private boolean hasSource = false;
private String locationPlaceHolder = "";
private final String locationPlaceHolder = "";
private String source;
private Parcel parent;
private final Parcel parent;
public ScriptMetaData(Parcel parent, ScriptEntry entry,

7
scripting/java/com/sun/star/script/framework/container/UnoPkgContainer.java
View File

@@ -38,10 +38,9 @@ import java.util.Map;
public class UnoPkgContainer extends ParcelContainer {
private Map<String, ParcelContainer> registeredPackages = new
HashMap<String, ParcelContainer>();
private String extensionDb;
private String extensionRepository;
private final Map<String, ParcelContainer> registeredPackages = new HashMap<String, ParcelContainer>();
private final String extensionDb;
private final String extensionRepository;
public UnoPkgContainer(XComponentContext xCtx, String locationURL,
String _extensionDb, String _extensionRepository,

2
scripting/java/com/sun/star/script/framework/container/XMLParserFactory.java
View File

@@ -54,7 +54,7 @@ public class XMLParserFactory {
private static class DefaultParser implements XMLParser {
private DocumentBuilderFactory factory;
private final DocumentBuilderFactory factory;
public DefaultParser() {
factory = DocumentBuilderFactory.newInstance();

5
scripting/java/com/sun/star/script/framework/io/UCBStreamHandler.java
View File

@@ -46,9 +46,8 @@ public class UCBStreamHandler extends URLStreamHandler {
public final static String separator = "/ucb/";
private XSimpleFileAccess m_xSimpleFileAccess = null;
private HashMap<String, InputStream> m_jarStreamMap = new
HashMap<String, InputStream>(12);
private final XSimpleFileAccess m_xSimpleFileAccess;
private final HashMap<String, InputStream> m_jarStreamMap = new HashMap<String, InputStream>(12);
private static String m_ucbscheme;
public UCBStreamHandler(String scheme, XSimpleFileAccess xSFA) {

2
scripting/java/com/sun/star/script/framework/io/XInputStreamImpl.java
View File

@@ -25,7 +25,7 @@ import java.io.InputStream;
public class XInputStreamImpl implements XInputStream {
private InputStream is;
private final InputStream is;
public XInputStreamImpl(InputStream is) {
this.is = is;

2
scripting/java/com/sun/star/script/framework/io/XInputStreamWrapper.java
View File

@@ -24,7 +24,7 @@ import java.io.InputStream;
public class XInputStreamWrapper extends InputStream {
private XInputStream m_xInputStream;
private final XInputStream m_xInputStream;
public XInputStreamWrapper(XInputStream xInputStream) {
m_xInputStream = xInputStream;

2
scripting/java/com/sun/star/script/framework/io/XOutputStreamWrapper.java
View File

@@ -24,7 +24,7 @@ import java.io.OutputStream;
public class XOutputStreamWrapper extends OutputStream {
private XOutputStream m_xOutputStream;
private final XOutputStream m_xOutputStream;
public XOutputStreamWrapper(XOutputStream xOs) {
this.m_xOutputStream = xOs;

4
scripting/java/com/sun/star/script/framework/provider/EditorScriptContext.java
View File

@@ -29,8 +29,8 @@ import com.sun.star.uno.XComponentContext;
public class EditorScriptContext implements XScriptContext {
private XDesktop m_xDeskTop;
private XComponentContext m_xComponentContext;
private final XDesktop m_xDeskTop;
private final XComponentContext m_xComponentContext;
public EditorScriptContext(XComponentContext xmComponentContext,
XDesktop xDesktop) {

8
scripting/java/com/sun/star/script/framework/provider/ScriptContext.java
View File

@@ -44,12 +44,12 @@ public class ScriptContext extends PropertySet implements XScriptContext {
private final static String DOC_URI = "SCRIPTING_DOC_URI";
private XModel m_xModel = null;
private XScriptInvocationContext m_xInvocationContext = null;
private final XModel m_xModel;
private final XScriptInvocationContext m_xInvocationContext;
private XDesktop m_xDeskTop = null;
private final XDesktop m_xDeskTop;
private XComponentContext m_xComponentContext = null;
private final XComponentContext m_xComponentContext;
private ScriptContext(XComponentContext xmComponentContext, XDesktop xDesktop,
XModel xModel, XScriptInvocationContext xInvocContext) {

4
scripting/java/com/sun/star/script/framework/provider/beanshell/PlainSourceView.java
View File

@@ -34,7 +34,7 @@ import javax.swing.event.DocumentListener;
public class PlainSourceView extends JScrollPane implements
ScriptSourceView, DocumentListener {
private ScriptSourceModel model;
private final ScriptSourceModel model;
private JTextArea ta;
private GlyphGutter gg;
private int linecount;
@@ -144,7 +144,7 @@ public class PlainSourceView extends JScrollPane implements
class GlyphGutter extends JComponent {
private PlainSourceView view;
private final PlainSourceView view;
private static final String DUMMY_STRING = "99";
GlyphGutter(PlainSourceView view) {

8
scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptProviderForBeanShell.java
View File

@@ -126,11 +126,11 @@ public class ScriptProviderForBeanShell {
class ScriptImpl implements XScript {
private ScriptMetaData metaData;
private XComponentContext m_xContext;
private final ScriptMetaData metaData;
private final XComponentContext m_xContext;
private XMultiComponentFactory m_xMultiComponentFactory;
private XModel m_xModel;
private XScriptInvocationContext m_xInvocContext;
private final XModel m_xModel;
private final XScriptInvocationContext m_xInvocContext;
ScriptImpl(XComponentContext ctx, ScriptMetaData metaData, XModel xModel,
XScriptInvocationContext xContext) throws

2
scripting/java/com/sun/star/script/framework/provider/beanshell/ScriptSourceModel.java
View File

@@ -27,7 +27,7 @@ import java.net.URL;
public class ScriptSourceModel {
private int currentPosition = -1;
private URL file = null;
private final URL file;
private ScriptSourceView view = null;
public ScriptSourceModel(URL file) {

8
scripting/java/com/sun/star/script/framework/provider/java/ScriptDescriptor.java
View File

@@ -27,11 +27,11 @@ import java.util.StringTokenizer;
*/
public class ScriptDescriptor {
private String m_name;
private String m_methodName;
private String m_className;
private final String m_name;
private final String m_methodName;
private final String m_className;
private List<String> m_classpath;
private ArrayList<Class<?>> m_argumentTypes = new ArrayList<Class<?>>(11);
private final ArrayList<Class<?>> m_argumentTypes = new ArrayList<Class<?>>(11);
/**
* Constructs a ScriptDescriptor for the given name

12
scripting/java/com/sun/star/script/framework/provider/java/ScriptProviderForJava.java
View File

@@ -52,7 +52,7 @@ public class ScriptProviderForJava {
public static class _ScriptProviderForJava extends ScriptProvider {
private Resolver m_resolutionPolicy = new StrictResolver();
private final Resolver m_resolutionPolicy = new StrictResolver();
public _ScriptProviderForJava(XComponentContext ctx) {
super(ctx, "Java");
@@ -126,12 +126,12 @@ public class ScriptProviderForJava {
class ScriptImpl implements XScript {
private ScriptMetaData metaData;
private XComponentContext m_xContext;
private XModel m_xModel;
private XScriptInvocationContext m_xInvocContext;
private final ScriptMetaData metaData;
private final XComponentContext m_xContext;
private final XModel m_xModel;
private final XScriptInvocationContext m_xInvocContext;
private XMultiComponentFactory m_xMultiComponentFactory;
private Resolver m_resolutionPolicy;
private final Resolver m_resolutionPolicy;
ScriptImpl(XComponentContext ctx, Resolver resolver, ScriptMetaData metaData,
XModel xModel, XScriptInvocationContext xInvocContext) throws

2
scripting/java/com/sun/star/script/framework/provider/java/ScriptProxy.java
View File

@@ -28,7 +28,7 @@ import java.lang.reflect.Method;
public class ScriptProxy {
private Object m_targetObject;
private Method m_method;
private final Method m_method;
/**
* Constructs a <code>ScriptProxy</code> object for the given

2
scripting/java/com/sun/star/script/framework/provider/javascript/ScriptEditorForJavaScript.java
View File

@@ -296,7 +296,7 @@ public class ScriptEditorForJavaScript implements ScriptEditor {
private class closeHandler implements Runnable {
private URL url;
private final URL url;
private closeHandler(URL url) {
this.url = url;

8
scripting/java/com/sun/star/script/framework/provider/javascript/ScriptProviderForJavaScript.java
View File

@@ -121,11 +121,11 @@ public class ScriptProviderForJavaScript {
class ScriptImpl implements XScript {
private ScriptMetaData metaData;
private XComponentContext m_xContext;
private final ScriptMetaData metaData;
private final XComponentContext m_xContext;
private XMultiComponentFactory m_xMultiComponentFactory;
private XModel m_xModel;
private XScriptInvocationContext m_xInvocContext;
private final XModel m_xModel;
private final XScriptInvocationContext m_xInvocContext;
ScriptImpl(XComponentContext ctx, ScriptMetaData metaData, XModel xModel,
XScriptInvocationContext xInvocContext) throws