mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

coverity#1019332 Unchecked dynamic_cast

Browse Source 
Change-Id: I280928da005b8cdd94c8bf33eb5aaa86a5ea2fcd
This commit is contained in:
Caolán McNamara
2014-12-27 20:24:37 +00:00
parent 435a3a32b1
commit 02d83cb52f
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
codemaker/source/javamaker/javatype.cxx
View File

@@ -1371,17 +1371,16 @@ void addPlainStructBaseArguments(
"unexpected entity \"" + base "unexpected entity \"" + base
+ "\" in call to addPlainStructBaseArguments"); + "\" in call to addPlainStructBaseArguments");
} }
rtl::Reference< unoidl::PlainStructTypeEntity > ent2( unoidl::PlainStructTypeEntity& ent2(
dynamic_cast< unoidl::PlainStructTypeEntity * >(ent.get())); dynamic_cast<unoidl::PlainStructTypeEntity&>(*ent.get()));
assert(ent2.is()); if (!ent2.getDirectBase().isEmpty()) {
if (!ent2->getDirectBase().isEmpty()) {
addPlainStructBaseArguments( addPlainStructBaseArguments(
manager, dependencies, methodDescriptor, code, manager, dependencies, methodDescriptor, code,
ent2->getDirectBase(), index); ent2.getDirectBase(), index);
} }
for (std::vector< unoidl::PlainStructTypeEntity::Member >::const_iterator i( for (std::vector< unoidl::PlainStructTypeEntity::Member >::const_iterator i(
ent2->getDirectMembers().begin()); ent2.getDirectMembers().begin());
i != ent2->getDirectMembers().end(); ++i) i != ent2.getDirectMembers().end(); ++i)
{ {
methodDescriptor->addParameter(i->type, false, true, 0); methodDescriptor->addParameter(i->type, false, true, 0);
addLoadLocal(manager, code, index, false, i->type, false, dependencies); addLoadLocal(manager, code, index, false, i->type, false, dependencies);