mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

crashtesting fix

Browse Source 
when doing
    soffice --convert-to ods tdf96952-1.xls

after
    commit 5c79032077
    Date:   Tue May 25 09:32:58 2021 +0200
    fix leaks in loading xmlscript

Change-Id: I55c1e95a09db937604f62a5b33e56349512ff8ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116435
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
This commit is contained in:
Noel Grandin
2021-05-31 10:57:33 +02:00
committed by Caolán McNamara
parent 5b8729a741
commit 057b25c04e
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
xmlscript/source/xmldlg_imexp/imp_share.hxx
View File

@@ -531,6 +531,8 @@ public:
class BulletinBoardElement class BulletinBoardElement
: public ControlElement : public ControlElement
{ {
// we are the owner of this, so have to keep a reference to it
rtl::Reference<DialogImport> mxDialogImport;
public: public:
virtual css::uno::Reference< css::xml::input::XElement > virtual css::uno::Reference< css::xml::input::XElement >
SAL_CALL startChildElement( SAL_CALL startChildElement(

3
xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx
View File

@@ -1725,7 +1725,8 @@ BulletinBoardElement::BulletinBoardElement(
OUString const & rLocalName, OUString const & rLocalName,
Reference< xml::input::XAttributes > const & xAttributes, Reference< xml::input::XAttributes > const & xAttributes,
ElementBase * pParent, DialogImport * pImport ) ElementBase * pParent, DialogImport * pImport )
: ControlElement( rLocalName, xAttributes, pParent, pImport ) : ControlElement( rLocalName, xAttributes, pParent, pImport ),
mxDialogImport(pImport)
{ {
OUString aValue( _xAttributes->getValueByUidName( m_pImport->XMLNS_DIALOGS_UID, "left" ) ); OUString aValue( _xAttributes->getValueByUidName( m_pImport->XMLNS_DIALOGS_UID, "left" ) );
if (!aValue.isEmpty()) if (!aValue.isEmpty())