mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

valgrind: use after free

Browse Source 
i.e. since b35980d9b

seems remove, remove, delete was old pattern, new patterns ended up
as remove+delete, remove. Reorder to remove, remove+delete

Change-Id: I54ec8d0296e751110c516516465be2ac0615f6a1
This commit is contained in:
Caolán McNamara
2012-08-09 10:34:50 +01:00
parent 9c9cf6ed4a
commit 069caf79d7
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
editeng/source/editeng/editdoc.cxx
View File

@@ -2688,8 +2688,8 @@ void CharAttribList::OptimizeRanges( SfxItemPool& rItemPool )
if (*rNext.GetItem() == *rAttr.GetItem()) if (*rNext.GetItem() == *rAttr.GetItem())
{ {
rAttr.GetEnd() = rNext.GetEnd(); rAttr.GetEnd() = rNext.GetEnd();
aAttribs.erase(aAttribs.begin()+nNext);
rItemPool.Remove(*rNext.GetItem()); rItemPool.Remove(*rNext.GetItem());
aAttribs.erase(aAttribs.begin()+nNext);
} }
break; // only 1 attr with same which can start here. break; // only 1 attr with same which can start here.
} }