mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improve some logging

Browse Source 
if we're going to write "unhandled" messages, at least what is being
unhandled

Change-Id: I570183c92876d553f4344b979def653cbd5bb55d
Reviewed-on: https://gerrit.libreoffice.org/54793
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2018-05-25 11:29:44 +02:00
parent 726d7e7b8b
commit 080fa092f4
4 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
oox/source/export/chartexport.cxx
View File

@@ -1239,7 +1239,7 @@ void ChartExport::exportManualLayout(const css::chart2::RelativePosition& rPos,
x -= w; x -= w;
break; break;
default: default:
SAL_WARN("oox", "unhandled alignment case for manual layout export"); SAL_WARN("oox", "unhandled alignment case for manual layout export " << static_cast<sal_uInt16>(rPos.Anchor));
} }
pFS->singleElement(FSNS(XML_c, XML_x), pFS->singleElement(FSNS(XML_c, XML_x),

2
oox/source/export/drawingml.cxx
View File

@@ -891,7 +891,7 @@ OUString DrawingML::WriteImage( const Graphic& rGraphic , bool bRelPathToMedia )
} }
else else
{ {
SAL_WARN("oox.shape", "unhandled graphic type" ); SAL_WARN("oox.shape", "unhandled graphic type " << static_cast<int>(aType) );
/*Earlier, even in case of unhandled graphic types we were /*Earlier, even in case of unhandled graphic types we were
proceeding to write the image, which would eventually proceeding to write the image, which would eventually
write an empty image with a zero size, and return a valid write an empty image with a zero size, and return a valid

4
sc/source/filter/lotus/lotform.cxx
View File

@@ -287,7 +287,7 @@ void LotusToSc::LotusRelToScRel( sal_uInt16 nCol, sal_uInt16 nRow, ScSingleRefDa
nRow &= 0x1FFF; nRow &= 0x1FFF;
break; break;
default: default:
SAL_WARN( "sc.filter", "*LotusToSc::LotusRelToScRel(): unhandled case?" ); SAL_WARN( "sc.filter", "*LotusToSc::LotusRelToScRel(): unhandled case? " << m_rContext.eTyp );
} }
} }
else else
@@ -307,7 +307,7 @@ void LotusToSc::LotusRelToScRel( sal_uInt16 nCol, sal_uInt16 nRow, ScSingleRefDa
nRow &= 0x3FFF; nRow &= 0x3FFF;
break; break;
default: default:
SAL_WARN( "sc.filter", "*LotusToSc::LotusRelToScRel(): unhandled case?" ); SAL_WARN( "sc.filter", "*LotusToSc::LotusRelToScRel(): unhandled case? " << m_rContext.eTyp );
} }
} }

5
svx/source/accessibility/AccessibleTextHelper.cxx
View File

@@ -66,6 +66,7 @@
#include <editeng/editdata.hxx> #include <editeng/editdata.hxx>
#include <editeng/editeng.hxx> #include <editeng/editeng.hxx>
#include <editeng/editview.hxx> #include <editeng/editview.hxx>
#include <tools/diagnose_ex.h>
using namespace ::com::sun::star; using namespace ::com::sun::star;
using namespace ::com::sun::star::accessibility; using namespace ::com::sun::star::accessibility;
@@ -1285,7 +1286,7 @@ namespace accessibility
} }
catch( const uno::Exception& ) catch( const uno::Exception& )
{ {
SAL_WARN("svx", "Unhandled exception."); DBG_UNHANDLED_EXCEPTION("svx");
} }
} }
} }
@@ -1399,7 +1400,7 @@ namespace accessibility
} }
catch( const uno::Exception& ) catch( const uno::Exception& )
{ {
SAL_WARN("svx", "Unhandled exception."); DBG_UNHANDLED_EXCEPTION("svx");
mbInNotify = false; mbInNotify = false;
} }