From 0b29a16d1dcffd75e49bd7ad3da867b0d0ebfa38 Mon Sep 17 00:00:00 2001 From: Kohei Yoshida Date: Sun, 12 Oct 2014 10:18:09 -0400 Subject: [PATCH] fdo#83901: ROW() and COLUMN() to be properly recalculated on cell move. For cases where ROW or COLUMN references another cell that has shifted. Change-Id: Ic4bef8672dab811ceff6886d9af0388306a66485 --- sc/source/core/data/column.cxx | 6 ++++++ sc/source/core/data/formulacell.cxx | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx index d6152dd5412b..521b942cb9af 100644 --- a/sc/source/core/data/column.cxx +++ b/sc/source/core/data/column.cxx @@ -2044,6 +2044,12 @@ class UpdateRefOnNonCopy : std::unary_function if (pCode->IsRecalcModeOnRefMove()) aRes.mbValueChanged = true; } + else if (aRes.mbReferenceModified && pCode->IsRecalcModeOnRefMove()) + { + // The cell itself hasn't shifted. But it may have ROW or COLUMN + // referencing another cell that has. + aRes.mbValueChanged = true; + } if (aRes.mbNameModified) recompileTokenArray(*pTop); diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx index 8cd95986c73c..33f64e920b5a 100644 --- a/sc/source/core/data/formulacell.cxx +++ b/sc/source/core/data/formulacell.cxx @@ -2788,7 +2788,7 @@ bool ScFormulaCell::UpdateReferenceOnShift( if (bOnRefMove) // Cell may reference itself, e.g. ocColumn, ocRow without parameter - bOnRefMove = (bValChanged || (aPos != aOldPos)); + bOnRefMove = (bValChanged || (aPos != aOldPos) || bRefModified); bool bNewListening = false; bool bInDeleteUndo = false;