From 0ee5a79a280dcacc326aafffb0a109ee63016c59 Mon Sep 17 00:00:00 2001 From: Michael Stahl Date: Fri, 27 Feb 2015 16:27:41 +0100 Subject: [PATCH] testtools: mark CurrentContextChecker as DLLPRIVATE The problem is that currentcontextchecker.cxx is linked statically into 2 dynamic libraries, and with clang now using -fvisibility-ms-compat since commit f0aa1a78fb209310e8baef53c02f365fca518d11 the ASAN complains about ODR violation in testttols uno_test: ==1818==ERROR: AddressSanitizer: odr-violation (0x2aef08e9c600): [1] size=192 'vtable for testtools::bridgetest::CurrentContextChecker' testtools/source/bridgetest/currentcontextchecker.cxx [2] size=192 'vtable for testtools::bridgetest::CurrentContextChecker' testtools/source/bridgetest/currentcontextchecker.cxx Change-Id: Ie705788dbf035f7a9f64878c6dcf3cec9b7e7ba1 --- testtools/source/bridgetest/currentcontextchecker.hxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testtools/source/bridgetest/currentcontextchecker.hxx b/testtools/source/bridgetest/currentcontextchecker.hxx index cd4feef7ef57..3c728c9ca803 100644 --- a/testtools/source/bridgetest/currentcontextchecker.hxx +++ b/testtools/source/bridgetest/currentcontextchecker.hxx @@ -30,7 +30,7 @@ namespace testtools { namespace bridgetest { -class CurrentContextChecker: +class SAL_DLLPRIVATE CurrentContextChecker : public ::osl::DebugBase< CurrentContextChecker >, public ::cppu::WeakImplHelper1< ::test::testtools::bridgetest::XCurrentContextChecker >