mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

compilerplugins: enhance "badstatics" plugin to find members

Browse Source 
Finds static variables of types that have bad non-static members.

Change-Id: I81ee940580c0f043feb543840ea4d3dd27734202
This commit is contained in:
Michael Stahl
2015-11-05 13:16:50 +01:00
parent 22fb58a6fa
commit 10afa00c8c
3 changed files with 55 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
compilerplugins/clang/badstatics.cxx
View File

@@ -25,23 +25,68 @@ public:
}
}
/*static*/ std::pair<bool, FieldDecl const*> isBadStaticType(
QualType const& rType, FieldDecl const*const pCurrentFieldDecl)
{
QualType const pCanonical(rType.getUnqualifiedType().getCanonicalType());
RecordType const*const pRecordType(pCanonical->getAs<RecordType>());
if (!pRecordType) {
return std::make_pair(false, nullptr);
}
auto const type(pCanonical.getAsString());
if ( type == "class Image"
|| type == "class Bitmap"
|| type == "class BitmapEx"
)
{
return std::make_pair(true, pCurrentFieldDecl);
}
RecordDecl const*const pDefinition(pRecordType->getDecl()->getDefinition());
assert(pDefinition);
CXXRecordDecl const*const pDecl(dyn_cast<CXXRecordDecl>(pDefinition));
assert(pDecl);
for (auto it = pDecl->field_begin(); it != pDecl->field_end(); ++it) {
auto const ret(isBadStaticType((*it)->getType(), *it));
if (ret.first) {
return ret;
}
}
for (auto it = pDecl->bases_begin(); it != pDecl->bases_end(); ++it) {
auto const ret(isBadStaticType((*it).getType(), pCurrentFieldDecl));
if (ret.first) {
return ret;
}
}
for (auto it = pDecl->vbases_begin(); it != pDecl->vbases_end(); ++it) {
auto const ret(isBadStaticType((*it).getType(), pCurrentFieldDecl));
if (ret.first) {
return ret;
}
}
return std::make_pair(false, nullptr);
}
bool VisitVarDecl(VarDecl const*const pVarDecl)
{
if (ignoreLocation(pVarDecl)) {
return true;
}
if (pVarDecl->hasGlobalStorage()) {
auto const type(pVarDecl->getType().getUnqualifiedType().getCanonicalType().getAsString());
if ( type == "class Image"
|| type == "class Bitmap"
|| type == "class BitmapEx"
)
{
if (pVarDecl->hasGlobalStorage()
&& pVarDecl->isThisDeclarationADefinition())
{
auto const ret(isBadStaticType(pVarDecl->getType(), nullptr));
if (ret.first) {
report(DiagnosticsEngine::Warning,
"bad static variable causes crash on shutdown",
pVarDecl->getLocation())
<< pVarDecl->getSourceRange();
if (ret.second != nullptr) {
report(DiagnosticsEngine::Remark,
"... due to this member",
ret.second->getLocation())
<< ret.second->getSourceRange();
}
}
}