diff --git a/svtools/source/config/menuoptions.cxx b/svtools/source/config/menuoptions.cxx index 8089c5c912d3..4c90a1ec81c7 100644 --- a/svtools/source/config/menuoptions.cxx +++ b/svtools/source/config/menuoptions.cxx @@ -237,7 +237,7 @@ SvtMenuOptions_Impl::SvtMenuOptions_Impl() { // Safe impossible cases. // Check any for valid value. - DBG_ASSERT( !(seqValues[nProperty].hasValue()==sal_False), "SvtMenuOptions_Impl::SvtMenuOptions_Impl()\nInvalid property value for property detected!\n" ); + DBG_ASSERT( seqValues[nProperty].hasValue(), "SvtMenuOptions_Impl::SvtMenuOptions_Impl()\nInvalid property value for property detected!\n" ); if (!seqValues[nProperty].hasValue()) continue; diff --git a/svtools/source/config/miscopt.cxx b/svtools/source/config/miscopt.cxx index 555a9d4a8bf8..9a0b250227f0 100644 --- a/svtools/source/config/miscopt.cxx +++ b/svtools/source/config/miscopt.cxx @@ -289,7 +289,7 @@ SvtMiscOptions_Impl::SvtMiscOptions_Impl() sal_Int32 nPropertyCount = seqValues.getLength(); for( sal_Int32 nProperty=0; nProperty& rPropertyNames ) sal_Int32 nPropertyCount = seqValues.getLength(); for( sal_Int32 nProperty=0; nProperty& rPropertyN // Copy values from list in right order to our internal member. for( sal_Int32 nProperty=0; nProperty& rPropertyNames // Copy values from list in right order to our internal member. for( sal_Int32 nProperty=0; nProperty( this ) ) ); - if ( aReturn.hasValue() == sal_True ) + if ( aReturn.hasValue() ) { return aReturn ; } diff --git a/svtools/source/misc/xwindowitem.cxx b/svtools/source/misc/xwindowitem.cxx index ed81d04dead2..a22a3f9825e4 100644 --- a/svtools/source/misc/xwindowitem.cxx +++ b/svtools/source/misc/xwindowitem.cxx @@ -59,7 +59,7 @@ bool XWindowItem::operator == ( const SfxPoolItem & rAttr ) const DBG_ASSERT( SfxPoolItem::operator==(rAttr), "unequal types" ); const XWindowItem * pItem = dynamic_cast< const XWindowItem * >(&rAttr); - return pItem ? m_xWin == pItem->m_xWin : 0; + return pItem && m_xWin == pItem->m_xWin; }