mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

coverity#1210096 Uncaught exception

Browse Source 
Change-Id: I1d06c7a6a61556c2b501a16c224ccc6fe52307d0
This commit is contained in:
Caolán McNamara
2014-06-17 10:16:22 +01:00
parent 66f98136fd
commit 136a2bc384
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
basic/source/basmgr/basmgr.cxx
View File

@@ -1324,7 +1324,7 @@ bool BasicManager::RemoveLib( sal_uInt16 nLib, bool bDelBasicFromStorage )
} }
catch (const css::ucb::ContentCreationException& e) catch (const css::ucb::ContentCreationException& e)
{ {
SAL_WARN( "basic", "BasicManager::RemoveLib: Caught exception: " << e.Message ); SAL_WARN("basic", "BasicManager::RemoveLib: Caught exception: " << e.Message);
} }
if (xStorage.Is() && xStorage->IsStorage(OUString(szBasicStorage))) if (xStorage.Is() && xStorage->IsStorage(OUString(szBasicStorage)))
@@ -1527,12 +1527,18 @@ StarBASIC* BasicManager::CreateLib( const OUString& rLibName, const OUString& Pa
{ {
if( !LinkTargetURL.isEmpty()) if( !LinkTargetURL.isEmpty())
{ {
SotStorageRef xStorage = new SotStorage( false, LinkTargetURL, STREAM_READ | STREAM_SHARE_DENYWRITE ); try
if( !xStorage->GetError() )
{ {
pLib = AddLib( *xStorage, rLibName, true ); SotStorageRef xStorage = new SotStorage(false, LinkTargetURL, STREAM_READ | STREAM_SHARE_DENYWRITE);
if (!xStorage->GetError())
{
pLib = AddLib(*xStorage, rLibName, true);
}
}
catch (const css::ucb::ContentCreationException& e)
{
SAL_WARN("basic", "BasicManager::RemoveLib: Caught exception: " << e.Message);
} }
DBG_ASSERT( pLib, "XML Import: Linked basic library could not be loaded"); DBG_ASSERT( pLib, "XML Import: Linked basic library could not be loaded");
} }
else else