mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:virtualdead unused param in ResourceChangeListener

Browse Source 
Change-Id: I6bfaef6694ec654889ddf1f300851f323bcc56b3
Reviewed-on: https://gerrit.libreoffice.org/81272
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-10-18 15:57:09 +02:00
parent 6921cde391
commit 163086a649
5 changed files with 13 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
chart2/source/controller/dialogs/ChangingResource.hxx
View File

@@ -27,7 +27,7 @@ class ChangingResource;
class ResourceChangeListener
{
public:
virtual void stateChanged( ChangingResource* pResource ) = 0;
virtual void stateChanged() = 0;
virtual ~ResourceChangeListener();
};

2
chart2/source/controller/dialogs/ChartTypeDialogController.cxx
View File

@@ -1193,7 +1193,7 @@ void CombiColumnLineChartDialogController::setTemplateProperties( const uno::Ref
IMPL_LINK_NOARG(CombiColumnLineChartDialogController, ChangeLineCountHdl, weld::SpinButton&, void)
{
if( m_pChangeListener )
m_pChangeListener->stateChanged(this);
m_pChangeListener->stateChanged();
}
void CombiColumnLineChartDialogController::adjustParameterToSubType( ChartTypeParameter& rParameter )
{

20
chart2/source/controller/dialogs/tp_ChartType.cxx
View File

@@ -105,13 +105,13 @@ void Dim3DLookResourceGroup::fillParameter( ChartTypeParameter& rParameter )
IMPL_LINK_NOARG(Dim3DLookResourceGroup, Dim3DLookCheckHdl, weld::ToggleButton&, void)
{
if(m_pChangeListener)
m_pChangeListener->stateChanged(this);
m_pChangeListener->stateChanged();
}
IMPL_LINK_NOARG(Dim3DLookResourceGroup, SelectSchemeHdl, weld::ComboBox&, void)
{
if(m_pChangeListener)
m_pChangeListener->stateChanged(this);
m_pChangeListener->stateChanged();
}
class SortByXValuesResourceGroup : public ChangingResource
@@ -156,7 +156,7 @@ void SortByXValuesResourceGroup::fillParameter( ChartTypeParameter& rParameter )
IMPL_LINK_NOARG(SortByXValuesResourceGroup, SortByXValuesCheckHdl, weld::ToggleButton&, void)
{
if(m_pChangeListener)
m_pChangeListener->stateChanged(this);
m_pChangeListener->stateChanged();
}
class StackingResourceGroup : public ChangingResource
@@ -251,13 +251,13 @@ IMPL_LINK( StackingResourceGroup, StackingChangeHdl, weld::ToggleButton&, rRadio
//first uncheck of previous button -> ignore that call
//the second call gives the check of the new button
if (m_pChangeListener && rRadio.get_active())
m_pChangeListener->stateChanged(this);
m_pChangeListener->stateChanged();
}
IMPL_LINK_NOARG(StackingResourceGroup, StackingEnableHdl, weld::ToggleButton&, void)
{
if( m_pChangeListener )
m_pChangeListener->stateChanged(this);
m_pChangeListener->stateChanged();
}
class SplinePropertiesDialog : public weld::GenericDialogController
@@ -506,7 +506,7 @@ void SplineResourceGroup::fillParameter( ChartTypeParameter& rParameter )
IMPL_LINK_NOARG(SplineResourceGroup, LineTypeChangeHdl, weld::ComboBox&, void)
{
if( m_pChangeListener )
m_pChangeListener->stateChanged(this);
m_pChangeListener->stateChanged();
}
IMPL_LINK_NOARG(SplineResourceGroup, SplineDetailsDialogHdl, weld::Button&, void)
@@ -520,7 +520,7 @@ IMPL_LINK_NOARG(SplineResourceGroup, SplineDetailsDialogHdl, weld::Button&, void
if (getSplinePropertiesDialog().run() == RET_OK)
{
if( m_pChangeListener )
m_pChangeListener->stateChanged(this);
m_pChangeListener->stateChanged();
}
else
{
@@ -541,7 +541,7 @@ IMPL_LINK_NOARG(SplineResourceGroup, SteppedDetailsDialogHdl, weld::Button&, voi
if (getSteppedPropertiesDialog().run() == RET_OK)
{
if( m_pChangeListener )
m_pChangeListener->stateChanged(this);
m_pChangeListener->stateChanged();
}
else
{
@@ -598,7 +598,7 @@ void GeometryResourceGroup::fillParameter(ChartTypeParameter& rParameter)
IMPL_LINK_NOARG(GeometryResourceGroup, GeometryChangeHdl, weld::TreeView&, void)
{
if( m_pChangeListener )
m_pChangeListener->stateChanged(this);
m_pChangeListener->stateChanged();
}
ChartTypeTabPage::ChartTypeTabPage(weld::Container* pPage, weld::DialogController* pController, const uno::Reference< XChartDocument >& xChartModel,
@@ -725,7 +725,7 @@ void ChartTypeTabPage::commitToModel( const ChartTypeParameter& rParameter )
m_pCurrentMainType->commitToModel( rParameter, m_xChartModel );
}
void ChartTypeTabPage::stateChanged( ChangingResource* /*pResource*/ )
void ChartTypeTabPage::stateChanged()
{
if(m_nChangingCalls)
return;

2
chart2/source/controller/dialogs/tp_ChartType.hxx
View File

@@ -61,7 +61,7 @@ private:
void fillAllControls( const ChartTypeParameter& rParameter, bool bAlsoResetSubTypeList=true );
ChartTypeParameter getCurrentParamter() const;
virtual void stateChanged( ChangingResource* pResource ) override;
virtual void stateChanged() override;
void commitToModel( const ChartTypeParameter& rParameter );
void selectMainType();

3
compilerplugins/clang/virtualdead.unusedparams.results
View File

@@ -31,9 +31,6 @@ basic/source/comp/codegen.cxx:466
basic/source/comp/codegen.cxx:467
void OffSetAccumulator::processOpCode2(enum SbiOpcode,type-parameter-?-?,type-parameter-?-?,)
000
chart2/source/controller/dialogs/ChangingResource.hxx:30
void chart::ResourceChangeListener::stateChanged(class chart::ChangingResource *,)
0
desktop/source/deployment/registry/inc/dp_backend.h:84
void dp_registry::backend::Package::processPackage_(class osl::ResettableGuard<class osl::Mutex> &,_Bool,_Bool,const class rtl::Reference<class dp_misc::AbortChannel> &,const class com::sun::star::uno::Reference<class com::sun::star::ucb::XCommandEnvironment> &,)
01111