mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tdf#97361 - make unit tests more pythonic.

Browse Source 
Change-Id: I853cda76522ebf3c9a8f7389d5b2b6fc9611f502
Signed-off-by: Hannah Meeks <hmeeks4135@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133136
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
This commit is contained in:
Hannah Meeks
2022-04-16 18:07:54 +01:00
committed by Ilmari Lauhakangas
parent c929c563e2
commit 182833b893
4 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cui/qa/uitest/dialogs/chardlg.py
View File

@@ -35,8 +35,8 @@ class Test(UITestCase):
xFontTransparency.executeAction("UP", tuple()) xFontTransparency.executeAction("UP", tuple())
# Verify the result. # Verify the result.
drawPage = component.getDrawPages().getByIndex(0) drawPage = component.getDrawPages()[0]
shape = drawPage.getByIndex(0) shape = drawPage[0]
# Without the accompanying fix in place, this test would have failed with: # Without the accompanying fix in place, this test would have failed with:
# AssertionError: 100 != 5 # AssertionError: 100 != 5

2
sc/qa/uitest/calc_tests3/insertQrCodeGen.py
View File

@@ -30,7 +30,7 @@ class insertQrCode(UITestCase):
xBorder.executeAction("DOWN", tuple()) xBorder.executeAction("DOWN", tuple())
# check the QR code in the document # check the QR code in the document
element = document.Sheets.getByIndex(0).DrawPage.getByIndex(0) element = document.Sheets[0].DrawPage[0]
self.assertEqual(element.BarCodeProperties.Payload, "www.libreoffice.org") self.assertEqual(element.BarCodeProperties.Payload, "www.libreoffice.org")
self.assertEqual(element.BarCodeProperties.ErrorCorrection, 1) self.assertEqual(element.BarCodeProperties.ErrorCorrection, 1)
self.assertEqual(element.BarCodeProperties.Border, 1) self.assertEqual(element.BarCodeProperties.Border, 1)

6
sc/qa/uitest/calc_tests4/exportToPDF.py
View File

@@ -71,8 +71,8 @@ class exportToPDF(UITestCase):
with self.ui_test.load_file(systemPathToFileUrl(xFilePath)) as document: with self.ui_test.load_file(systemPathToFileUrl(xFilePath)) as document:
self.assertEqual("Sheet1", document.DrawPages[0].getByIndex(0).String) self.assertEqual("Sheet1", document.DrawPages[0][0].String)
self.assertEqual("Page 1", document.DrawPages[0].getByIndex(1).String) self.assertEqual("Page 1", document.DrawPages[0][1].String)
self.assertEqual("Hello World", document.DrawPages[0].getByIndex(2).String) self.assertEqual("Hello World", document.DrawPages[0][2].String)
# vim: set shiftwidth=4 softtabstop=4 expandtab: # vim: set shiftwidth=4 softtabstop=4 expandtab:

4
sc/qa/uitest/calc_tests8/tdf144940.py
View File

@@ -50,8 +50,8 @@ class tdf144940(UITestCase):
with self.ui_test.load_file(systemPathToFileUrl(xFilePath)) as document: with self.ui_test.load_file(systemPathToFileUrl(xFilePath)) as document:
xPageStyles = document.StyleFamilies.getByIndex(1) xPageStyles = document.StyleFamilies[1]
xDefaultPageStyle = xPageStyles.getByIndex(0) xDefaultPageStyle = xPageStyles[0]
# Without the fix in place, this test would have failed with # Without the fix in place, this test would have failed with
# AssertionError: False is not true # AssertionError: False is not true