mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:unnecessaryvirtual

Browse Source 
Change-Id: Ie010deb5cdf9da20f2ca60d79feabf1c0de93c57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177669
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2024-12-02 12:08:32 +02:00
parent aa443205e6
commit 18c2199537
9 changed files with 7 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/drawinglayer/primitive2d/textprimitive2d.hxx
View File

@@ -179,7 +179,7 @@ public:
virtual bool hasTextRelief() const; virtual bool hasTextRelief() const;
virtual bool hasShadow() const; virtual bool hasShadow() const;
virtual bool hasTextDecoration() const; virtual bool hasTextDecoration() const;
virtual bool hasOutline() const; bool hasOutline() const;
/// compare operator /// compare operator
virtual bool operator==(const BasePrimitive2D& rPrimitive) const override; virtual bool operator==(const BasePrimitive2D& rPrimitive) const override;

4
include/sfx2/tabdlg.hxx
View File

@@ -265,8 +265,8 @@ public:
virtual void FillUserData(); virtual void FillUserData();
virtual bool IsReadOnly() const; virtual bool IsReadOnly() const;
// Whether the user has canceled the dialog. Allows to restore settings, etc. // Whether the user has canceled the dialog. Allows to restore settings, etc.
virtual bool IsCancelMode() { return mbCancel; } bool IsCancelMode() { return mbCancel; }
virtual void SetCancelMode(bool bCancel) { mbCancel = bCancel; } void SetCancelMode(bool bCancel) { mbCancel = bCancel; }
virtual void PageCreated (const SfxAllItemSet& aSet); virtual void PageCreated (const SfxAllItemSet& aSet);
virtual void ChangesApplied(); virtual void ChangesApplied();
static const SfxPoolItem* GetItem( const SfxItemSet& rSet, sal_uInt16 nSlot, bool bDeep = true ); static const SfxPoolItem* GetItem( const SfxItemSet& rSet, sal_uInt16 nSlot, bool bDeep = true );

4
include/vcl/window.hxx
View File

@@ -1122,8 +1122,8 @@ public:
/// Use OS specific way to bring user attention to current window /// Use OS specific way to bring user attention to current window
virtual void FlashWindow() const; virtual void FlashWindow() const;
virtual void SetTaskBarProgress(int nCurrentProgress); void SetTaskBarProgress(int nCurrentProgress);
virtual void SetTaskBarState(VclTaskBarStates eTaskBarState); void SetTaskBarState(VclTaskBarStates eTaskBarState);
/** @name Accessibility /** @name Accessibility
*/ */

2
sd/source/ui/inc/unomodel.hxx
View File

@@ -405,7 +405,7 @@ public:
virtual void SAL_CALL removeEventListener( const css::uno::Reference< css::lang::XEventListener >& aListener ) override; virtual void SAL_CALL removeEventListener( const css::uno::Reference< css::lang::XEventListener >& aListener ) override;
private: private:
virtual css::uno::Reference< ::css::drawing::XDrawPage > insertNewImpl( sal_Int32 nIndex, std::optional<OUString> oName ); css::uno::Reference< ::css::drawing::XDrawPage > insertNewImpl( sal_Int32 nIndex, std::optional<OUString> oName );
}; };
/*********************************************************************** /***********************************************************************

2
sw/source/writerfilter/ooxml/OOXMLPropertySet.hxx
View File

@@ -67,7 +67,7 @@ public:
#ifdef DBG_UTIL #ifdef DBG_UTIL
virtual std::string toString() const override; virtual std::string toString() const override;
#endif #endif
virtual OOXMLValue* clone() const; OOXMLValue* clone() const;
private: private:
typedef std::variant<std::monostate, // typedef std::variant<std::monostate, //

1
vcl/inc/salinst.hxx
View File

@@ -195,7 +195,6 @@ public:
// callbacks for printer updates // callbacks for printer updates
virtual void updatePrinterUpdate() {} virtual void updatePrinterUpdate() {}
virtual void jobEndedPrinterUpdate() {}
/// Set the app's (somewhat) magic/main-thread to this one. /// Set the app's (somewhat) magic/main-thread to this one.
virtual void updateMainThread() {} virtual void updateMainThread() {}

1
vcl/inc/unx/geninst.h
View File

@@ -63,7 +63,6 @@ public:
virtual OUString GetDefaultPrinter() override; virtual OUString GetDefaultPrinter() override;
virtual void PostPrintersChanged() = 0; virtual void PostPrintersChanged() = 0;
virtual void updatePrinterUpdate() override; virtual void updatePrinterUpdate() override;
virtual void jobEndedPrinterUpdate() override;
bool isPrinterInit() const { return mbPrinterInit; } bool isPrinterInit() const { return mbPrinterInit; }
virtual std::unique_ptr<GenPspGraphics> CreatePrintGraphics() = 0; virtual std::unique_ptr<GenPspGraphics> CreatePrintGraphics() = 0;

4
vcl/ios/dummies.cxx
View File

@@ -99,10 +99,6 @@ void SalGenericInstance::updatePrinterUpdate()
{ {
} }
void SalGenericInstance::jobEndedPrinterUpdate()
{
}
using namespace psp; using namespace psp;
bool AquaGraphicsBackend::drawNativeControl(ControlType /* nType */, bool AquaGraphicsBackend::drawNativeControl(ControlType /* nType */,

5
vcl/unx/generic/print/genprnpsp.cxx
View File

@@ -721,7 +721,6 @@ bool PspSalPrinter::StartJob(
bool PspSalPrinter::EndJob() bool PspSalPrinter::EndJob()
{ {
GetSalInstance()->jobEndedPrinterUpdate();
return true; return true;
} }
@@ -1035,8 +1034,4 @@ void SalGenericInstance::updatePrinterUpdate()
PostPrintersChanged(); PostPrintersChanged();
} }
void SalGenericInstance::jobEndedPrinterUpdate()
{
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ /* vim:set shiftwidth=4 softtabstop=4 expandtab: */