From 19fc36293c082ba3462cd8082cfee95d99e63b3a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= Date: Tue, 8 Nov 2016 09:06:23 +0000 Subject: [PATCH] coverity#1394268 Resource leak Change-Id: I8f4a76d4f7e5cb2429ed5911c6026535590c681e --- svx/source/table/cell.cxx | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/svx/source/table/cell.cxx b/svx/source/table/cell.cxx index 6acddfde05ff..38a29c2091d8 100644 --- a/svx/source/table/cell.cxx +++ b/svx/source/table/cell.cxx @@ -238,7 +238,7 @@ namespace sdr { OutlinerParaObject* pParaObj = mxCell->GetEditOutlinerParaObject(); - bool bOwnParaObj = pParaObj != nullptr; + const bool bOwnParaObj = pParaObj != nullptr; if( pParaObj == nullptr ) pParaObj = mxCell->GetOutlinerParaObject(); @@ -319,13 +319,19 @@ namespace sdr // Set a cell vertical property OutlinerParaObject* pParaObj = mxCell->GetEditOutlinerParaObject(); + + const bool bOwnParaObj = pParaObj != nullptr; + if( pParaObj == nullptr ) pParaObj = mxCell->GetOutlinerParaObject(); + if(pParaObj) { pParaObj->SetVertical(bVertical); - } + if( bOwnParaObj ) + delete pParaObj; + } } // call parent