diff --git a/sc/source/ui/condformat/condformatdlgentry.cxx b/sc/source/ui/condformat/condformatdlgentry.cxx index c1a92ff7475a..c9cacdb323be 100644 --- a/sc/source/ui/condformat/condformatdlgentry.cxx +++ b/sc/source/ui/condformat/condformatdlgentry.cxx @@ -1389,11 +1389,15 @@ ScIconSetFrmtDataEntry::ScIconSetFrmtDataEntry(vcl::Window* pParent, ScIconSetTy Size ScIconSetFrmtDataEntry::calculateRequisition() const { + if (!maGrid) //during dispose + return Size(); return getLayoutRequisition(*maGrid); } void ScIconSetFrmtDataEntry::setAllocation(const Size &rAllocation) { + if (!maGrid) //during dispose + return; setLayoutPosSize(*maGrid, Point(0, 0), rAllocation); } @@ -1461,6 +1465,7 @@ ScIconSetFrmtEntry::ScIconSetFrmtEntry(vcl::Window* pParent, ScDocument* pDoc, c { get(maLbColorFormat, "colorformat"); get(maLbIconSetType, "iconsettype"); + get(maIconParent, "iconparent"); Init(); maLbColorFormat->SetSelectHdl( LINK( pParent, ScCondFormatList, ColFormatTypeHdl ) ); @@ -1475,12 +1480,9 @@ ScIconSetFrmtEntry::ScIconSetFrmtEntry(vcl::Window* pParent, ScDocument* pDoc, c for (size_t i = 0, n = pIconSetFormatData->m_Entries.size(); i < n; ++i) { - maEntries.push_back( VclPtr::Create( - this, eType, pDoc, i, pIconSetFormatData->m_Entries[i].get())); - Size aSize(maEntries[0]->get_preferred_size()); - Point aPos(0, LogicToPixel(Size(0, 35), MapMode(MapUnit::MapAppFont)).getHeight()); - aPos.Y() += aSize.Height() * i * 1.2; - maEntries[i]->SetPosSizePixel(aPos, aSize); + maEntries.push_back(VclPtr::Create( + maIconParent, eType, pDoc, i, pIconSetFormatData->m_Entries[i].get())); + maEntries[i]->set_grid_top_attach(i); } maEntries[0]->SetFirstEntry(); } @@ -1498,6 +1500,7 @@ void ScIconSetFrmtEntry::dispose() for (auto it = maEntries.begin(); it != maEntries.end(); ++it) it->disposeAndClear(); maEntries.clear(); + maIconParent.clear(); maLbColorFormat.clear(); maLbIconSetType.clear(); ScCondFrmtEntry::dispose(); @@ -1525,11 +1528,8 @@ IMPL_LINK_NOARG( ScIconSetFrmtEntry, IconSetTypeHdl, ListBox&, void ) for(size_t i = 0; i < nElements; ++i) { - maEntries.push_back( VclPtr::Create( this, static_cast(nPos), mpDoc, i ) ); - Size aSize(maEntries[0]->get_preferred_size()); - Point aPos(0, LogicToPixel(Size(0, 35), MapMode(MapUnit::MapAppFont)).getHeight()); - aPos.Y() += aSize.Height() * i * 1.2; - maEntries[i]->SetPosSizePixel(aPos, aSize); + maEntries.push_back(VclPtr::Create(maIconParent, static_cast(nPos), mpDoc, i)); + maEntries[i]->set_grid_top_attach(i); maEntries[i]->Show(); } maEntries[0]->SetFirstEntry(); diff --git a/sc/source/ui/inc/condformatdlgentry.hxx b/sc/source/ui/inc/condformatdlgentry.hxx index 27a4fbc2e468..5b23e6ec12fb 100644 --- a/sc/source/ui/inc/condformatdlgentry.hxx +++ b/sc/source/ui/inc/condformatdlgentry.hxx @@ -296,6 +296,8 @@ class ScIconSetFrmtEntry : public ScCondFrmtEntry // icon set ui elements VclPtr maLbIconSetType; + VclPtr maIconParent; + typedef std::vector> ScIconSetFrmtDataEntriesType; ScIconSetFrmtDataEntriesType maEntries; diff --git a/sc/uiconfig/scalc/ui/conditionalentry.ui b/sc/uiconfig/scalc/ui/conditionalentry.ui index c5803074e635..88ec9b39069a 100644 --- a/sc/uiconfig/scalc/ui/conditionalentry.ui +++ b/sc/uiconfig/scalc/ui/conditionalentry.ui @@ -409,6 +409,20 @@ 2 + + + True + False + + + + + + 0 + 7 + 3 + +