mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Typo: "disposeAndClear", not "clearAndDispose"

Browse Source 
Change-Id: I9f7f30fce9324f7ccb79e9a8ef0c13e091d7c3a3
Reviewed-on: https://gerrit.libreoffice.org/40304
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Julien Nabet
2017-07-22 13:20:05 +02:00
committed by Noel Grandin
parent 2b4cb88c02
commit 1cf7a4c39e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
compilerplugins/clang/unusedfields.cxx
View File

@@ -472,10 +472,10 @@ void UnusedFields::checkWriteOnly(const FieldDecl* fieldDecl, const Expr* member
if (startswith(name, "read") || name.find(">>=") != std::string::npos)
// this is a write-only call
;
else if (name == "clear" || name == "dispose" || name == "clearAndDispose" || name == "swap")
else if (name == "clear" || name == "dispose" || name == "disposeAndClear" || name == "swap")
// we're abusing the write-only analysis here to look for fields which don't have anything useful
// being done to them, so we're ignoring things like std::vector::clear, std::vector::swap,
// and VclPtr::clearAndDispose
// and VclPtr::disposeAndClear
;
else
bPotentiallyReadFrom = true;