mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Generalize vector/deque ctor checks to work with MSVCRT

Browse Source 
Change-Id: I2d493a36b8c2e3abe69964c04b46f08d67ef8a48
This commit is contained in:
Stephan Bergmann
2016-12-22 09:23:19 +01:00
parent 4a591d74a7
commit 1dc43e24b3
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
compilerplugins/clang/store/badvectorinit.cxx
View File

@@ -178,12 +178,13 @@ bool BadVectorInit::VisitCXXConstructExpr(const CXXConstructExpr* expr)
if (aParentName.find("vector") == string::npos && aParentName.find("deque") == string::npos) if (aParentName.find("vector") == string::npos && aParentName.find("deque") == string::npos)
return true; return true;
// ignore the copy constructor // ignore the copy/move constructors, and those taking an initializer_list
// etc.:
if (consDecl->isCopyConstructor() || consDecl->isMoveConstructor())
return true;
const ParmVarDecl* pParam = consDecl->getParamDecl(0); const ParmVarDecl* pParam = consDecl->getParamDecl(0);
std::string aParam1 = pParam->getOriginalType().getAsString(); std::string aParam1 = pParam->getOriginalType().getAsString();
if (aParam1.find("vector") != string::npos if (aParam1.find("initializer_list") != string::npos
|| aParam1.find("deque") != string::npos
|| aParam1.find("initializer_list") != string::npos
|| aParam1.find("iterator") != string::npos) || aParam1.find("iterator") != string::npos)
return true; return true;