mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:constfields in smoketest..sot

Browse Source 
Change-Id: I59ceda8ff85cc7b348882a6e1c62491b74297801
Reviewed-on: https://gerrit.libreoffice.org/61549
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2018-10-08 10:29:01 +02:00
parent 56940b766e
commit 1de7e818a4
8 changed files with 20 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
smoketest/smoketest.cxx
View File

@@ -106,8 +106,8 @@ private:
{ dispatch_->dispatchWithNotification(url_, arguments_, listener_); } { dispatch_->dispatchWithNotification(url_, arguments_, listener_); }
css::uno::Reference< css::frame::XNotifyingDispatch > dispatch_; css::uno::Reference< css::frame::XNotifyingDispatch > dispatch_;
css::util::URL url_; css::util::URL const url_;
css::uno::Sequence< css::beans::PropertyValue > arguments_; css::uno::Sequence< css::beans::PropertyValue > const arguments_;
css::uno::Reference< css::frame::XDispatchResultListener > listener_; css::uno::Reference< css::frame::XDispatchResultListener > listener_;
}; };

6
soltools/cpp/_eval.c
View File

@@ -43,9 +43,9 @@ struct value
/* operator priority, arity, and conversion type, indexed by tokentype */ /* operator priority, arity, and conversion type, indexed by tokentype */
struct pri struct pri
{ {
char pri; char const pri;
char arity; char const arity;
char ctype; char const ctype;
}; };
static struct pri priority[] = static struct pri priority[] =

2
soltools/cpp/_lex.c
View File

@@ -68,7 +68,7 @@ struct fsm
{ {
int state; /* if in this state */ int state; /* if in this state */
uchar ch[4]; /* and see one of these characters */ uchar ch[4]; /* and see one of these characters */
int nextstate; /* enter this state if +ve */ int const nextstate; /* enter this state if +ve */
}; };
static /*const*/ struct fsm fsm[] = { static /*const*/ struct fsm fsm[] = {

6
soltools/cpp/_nlist.c
View File

@@ -38,9 +38,9 @@ static Nlist *nlist[NLSIZE];
struct kwtab struct kwtab
{ {
char *kw; char * const kw;
int val; int const val;
int flag; int const flag;
}; };
static struct kwtab kwtab[] = static struct kwtab kwtab[] =

8
sot/inc/sysformats.hxx
View File

@@ -28,10 +28,10 @@
struct SotAction_Impl struct SotAction_Impl
{ {
SotClipboardFormatId nFormatId; // Clipboard Id SotClipboardFormatId const nFormatId; // Clipboard Id
sal_uInt16 nAction; // Action Id sal_uInt16 const nAction; // Action Id
SotExchangeActionFlags nFlags; // Action Id SotExchangeActionFlags const nFlags; // Action Id
sal_uInt8 nContextCheckId; // additional check of content in clipboard sal_uInt8 const nContextCheckId; // additional check of content in clipboard
constexpr SotAction_Impl(SotClipboardFormatId _nFormatId, sal_uInt16 _nAction, SotExchangeActionFlags _nFlags, sal_uInt8 _nContextCheckId) constexpr SotAction_Impl(SotClipboardFormatId _nFormatId, sal_uInt16 _nAction, SotExchangeActionFlags _nFlags, sal_uInt8 _nContextCheckId)
: nFormatId(_nFormatId), nAction(_nAction), nFlags(_nFlags), nContextCheckId(_nContextCheckId) {} : nFormatId(_nFormatId), nAction(_nAction), nFlags(_nFlags), nContextCheckId(_nContextCheckId) {}

2
sot/source/base/formats.cxx
View File

@@ -50,7 +50,7 @@ using namespace ::com::sun::star::datatransfer;
struct SotDestinationEntry_Impl struct SotDestinationEntry_Impl
{ {
SotExchangeDest nDestination; SotExchangeDest const nDestination;
const SotAction_Impl* aDefaultActions; const SotAction_Impl* aDefaultActions;
const SotAction_Impl* aMoveActions; const SotAction_Impl* aMoveActions;
const SotAction_Impl* aCopyActions; const SotAction_Impl* aCopyActions;

2
sot/source/sdstor/stgcache.hxx
View File

@@ -100,7 +100,7 @@ class StgPage : public salhelper::SimpleReferenceObject
const sal_Int32 mnPage; // page index const sal_Int32 mnPage; // page index
std::unique_ptr<sal_uInt8[]> std::unique_ptr<sal_uInt8[]>
mpData; // nSize bytes mpData; // nSize bytes
short mnSize; // size of this page short const mnSize; // size of this page
StgPage( short nData, sal_Int32 nPage ); StgPage( short nData, sal_Int32 nPage );
virtual ~StgPage() override; virtual ~StgPage() override;
public: public:

10
sot/source/sdstor/ucbstorage.cxx
View File

@@ -405,7 +405,7 @@ public:
OUString m_aURL; // the full path name to create the content OUString m_aURL; // the full path name to create the content
OUString m_aContentType; OUString m_aContentType;
OUString m_aOriginalContentType; OUString m_aOriginalContentType;
OString m_aKey; OString const m_aKey;
::ucbhelper::Content* m_pContent; // the content that provides the data ::ucbhelper::Content* m_pContent; // the content that provides the data
Reference<XInputStream> m_rSource; // the stream covering the original data of the content Reference<XInputStream> m_rSource; // the stream covering the original data of the content
std::unique_ptr<SvStream> m_pStream; // the stream worked on; for readonly streams it is the original stream of the content std::unique_ptr<SvStream> m_pStream; // the stream worked on; for readonly streams it is the original stream of the content
@@ -416,7 +416,7 @@ public:
bool m_bSourceRead; // Source still contains useful information bool m_bSourceRead; // Source still contains useful information
bool m_bModified; // only modified streams will be sent to the original content bool m_bModified; // only modified streams will be sent to the original content
bool m_bCommited; // sending the streams is coordinated by the root storage of the package bool m_bCommited; // sending the streams is coordinated by the root storage of the package
bool m_bDirect; // the storage and its streams are opened in direct mode; for UCBStorages bool const m_bDirect; // the storage and its streams are opened in direct mode; for UCBStorages
// this means that the root storage does an autocommit when its external // this means that the root storage does an autocommit when its external
// reference is destroyed // reference is destroyed
bool m_bIsOLEStorage;// an OLEStorage on a UCBStorageStream makes this an Autocommit-stream bool m_bIsOLEStorage;// an OLEStorage on a UCBStorageStream makes this an Autocommit-stream
@@ -466,7 +466,7 @@ public:
ErrCode m_nError; ErrCode m_nError;
StreamMode m_nMode; // open mode ( read/write/trunc/nocreate/sharing ) StreamMode m_nMode; // open mode ( read/write/trunc/nocreate/sharing )
bool m_bCommited; // sending the streams is coordinated by the root storage of the package bool m_bCommited; // sending the streams is coordinated by the root storage of the package
bool m_bDirect; // the storage and its streams are opened in direct mode; for UCBStorages bool const m_bDirect; // the storage and its streams are opened in direct mode; for UCBStorages
// this means that the root storage does an autocommit when its external // this means that the root storage does an autocommit when its external
// reference is destroyed // reference is destroyed
bool m_bIsRoot; // marks this storage as root storages that manages all commits and reverts bool m_bIsRoot; // marks this storage as root storages that manages all commits and reverts
@@ -478,7 +478,7 @@ public:
UCBStorageElementList_Impl m_aChildrenList; UCBStorageElementList_Impl m_aChildrenList;
bool m_bRepairPackage; bool const m_bRepairPackage;
Reference< XProgressHandler > m_xProgressHandler; Reference< XProgressHandler > m_xProgressHandler;
UCBStorage_Impl( const ::ucbhelper::Content&, const OUString&, StreamMode, UCBStorage*, bool, UCBStorage_Impl( const ::ucbhelper::Content&, const OUString&, StreamMode, UCBStorage*, bool,
@@ -529,7 +529,7 @@ struct UCBStorageElement_Impl
{ {
OUString m_aName; // the actual URL relative to the root "folder" OUString m_aName; // the actual URL relative to the root "folder"
OUString m_aOriginalName;// the original name in the content OUString m_aOriginalName;// the original name in the content
sal_uLong m_nSize; sal_uLong const m_nSize;
bool m_bIsFolder; // Only true when it is a UCBStorage ! bool m_bIsFolder; // Only true when it is a UCBStorage !
bool m_bIsStorage; // Also true when it is an OLEStorage ! bool m_bIsStorage; // Also true when it is an OLEStorage !
bool m_bIsRemoved; // element will be removed on commit bool m_bIsRemoved; // element will be removed on commit