From 1edb2a1040a7f71e8ac5e4e8e8df176b18b37d07 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Wed, 7 Oct 2015 15:13:59 +0200 Subject: [PATCH] clang-analyzer-deadcode.DeadStores ...introduced with dc5383e2fa487a7599f2e317bba409dc3cde8339 "fdo#84229 - don't set error when seeking beyond end of valid data." Change-Id: Ic26872ce47ff27a0e1170ebc66cdf10587334192 --- sot/source/sdstor/stgstrms.cxx | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sot/source/sdstor/stgstrms.cxx b/sot/source/sdstor/stgstrms.cxx index c913bebc9e0e..2471c005b000 100644 --- a/sot/source/sdstor/stgstrms.cxx +++ b/sot/source/sdstor/stgstrms.cxx @@ -431,12 +431,13 @@ bool StgStrm::Pos2Page( sal_Int32 nBytePos ) SAL_WARN("sot", "seek to index " << nIdx << " beyond page cache size " << m_aPagesCache.size()); // fdo#84229 - handle seek to end and back as eg. XclImpStream expects - nIdx = m_aPagesCache.size(); nPage = STG_EOF; nOffset = 0; // Intriguingly in the past we didn't reset nPos to match the real - // length of the stream thus: nPos = nPageSize * nIdx; so retain - // this behavior for now. + // length of the stream thus: + // nIdx = m_aPagesCache.size(); + // nPos = nPageSize * nIdx; + // so retain this behavior for now. return false; }