mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cid#1607257 Overflowed constant

Browse Source 
this is a false positve, but perhaps we can help coverity work it
out properly with some constexpr

Change-Id: I8398153d6678585dacf4acaf7081ec32094bcda6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174150
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2024-09-28 19:33:58 +02:00
committed by Noel Grandin
parent df389675fc
commit 2009ecbeb1
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
store/source/storcach.cxx
View File

@@ -123,7 +123,7 @@ void EntryCache::destroy (Entry * entry)
} }
// highbit():= log2() + 1 (complexity O(1)) // highbit():= log2() + 1 (complexity O(1))
static int highbit(std::size_t n) static constexpr int highbit(std::size_t n)
{ {
int k = 1; int k = 1;

2
store/source/storcach.hxx
View File

@@ -39,7 +39,7 @@ struct Entry;
class PageCache : class PageCache :
public store::OStoreObject public store::OStoreObject
{ {
static size_t const theTableSize = 32; static size_t constexpr theTableSize = 32;
static_assert((theTableSize & (theTableSize-1)) == 0, "table size should be a power of 2"); static_assert((theTableSize & (theTableSize-1)) == 0, "table size should be a power of 2");
Entry ** m_hash_table; Entry ** m_hash_table;