mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

There doesn't need to be a TemplateSpecializationType here

Browse Source 
On both macOS (libc++) and Windows (MSVC standard library),
compilerplugins/clang/test/getstr.cxx failed four tests without this fix:

> error: 'error' diagnostics expected but not seen:
>   File compilerplugins/clang/test/getstr.cxx Line 29: suspicious use of 'getStr' on an object of type 'rtl::OUStringBuffer'; the result is implicitly cast to a void pointer in a call of 'operator <<' [loplugin:getstr]
>   File compilerplugins/clang/test/getstr.cxx Line 30: directly use object of type 'S' (aka 'rtl::OString') in a call of 'operator <<', instead of calling 'getStr' first [loplugin:getstr]
>   File compilerplugins/clang/test/getstr.cxx Line 34: suspicious use of 'getStr' on an object of type 'rtl::OUStringBuffer'; the result is implicitly cast to a void pointer in a call of 'operator <<' [loplugin:getstr]
>   File compilerplugins/clang/test/getstr.cxx Line 35: directly use object of type 'rtl::OString' in a call of 'operator <<', instead of calling 'getStr' first [loplugin:getstr]

Change-Id: I65406d3d84bb5a89df44c8fd665b6e38d19f38c7
Reviewed-on: https://gerrit.libreoffice.org/81266
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2019-10-21 19:27:12 +02:00
parent 2008880a57
commit 20c6dfde1d
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
compilerplugins/clang/getstr.cxx
View File

@@ -70,7 +70,6 @@ public:
} }
assert(expr->getNumArgs() == 2); assert(expr->getNumArgs() == 2);
if (!loplugin::TypeCheck(expr->getArg(0)->getType()) if (!loplugin::TypeCheck(expr->getArg(0)->getType())
.TemplateSpecializationClass()
.ClassOrStruct("basic_ostream") .ClassOrStruct("basic_ostream")
.StdNamespace()) //TODO: check template args .StdNamespace()) //TODO: check template args
{ {