From 2313d99c019f27956a4d28f96c25ea2477d538b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= Date: Wed, 23 Sep 2020 12:27:31 +0100 Subject: [PATCH] cid#1466970 annotate as false positive MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I2ccb0fe70626c998fbc108464f03f1d4144e600d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103244 Tested-by: Jenkins Reviewed-by: Caolán McNamara --- extensions/source/update/check/updatecheck.cxx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/extensions/source/update/check/updatecheck.cxx b/extensions/source/update/check/updatecheck.cxx index 348ef35faaca..485b4e140947 100644 --- a/extensions/source/update/check/updatecheck.cxx +++ b/extensions/source/update/check/updatecheck.cxx @@ -810,6 +810,7 @@ UpdateCheck::initialize(const uno::Sequence< beans::NamedValue >& rValues, bool downloadPaused = aModel.isDownloadPaused(); enableDownload(true, downloadPaused); + // coverity[lock_order : FALSE] - incorrect report of lock older error with std::recursive_mutex setUIState(downloadPaused ? UPDATESTATE_DOWNLOAD_PAUSED : UPDATESTATE_DOWNLOADING); } @@ -841,7 +842,10 @@ UpdateCheck::initialize(const uno::Sequence< beans::NamedValue >& rValues, if ( bDownloadAvailable ) setUIState( UPDATESTATE_DOWNLOAD_AVAIL ); else + { + // coverity[lock_order : FALSE] - incorrect report of lock order error with std::recursive_mutex setUIState(getUIState(m_aUpdateInfo)); + } } } }